From: Paolo Abeni <pabeni@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net: use indirect call wrappers for skb_copy_datagram_iter()
Date: Wed, 25 Mar 2020 17:24:18 +0100 [thread overview]
Message-ID: <7e385f0c1edca94a882bdadf46f4ddb97d59a64a.camel@redhat.com> (raw)
In-Reply-To: <0f5c5e35-fc51-19c3-2ce3-c8ac17887c6c@gmail.com>
On Wed, 2020-03-25 at 09:07 -0700, Eric Dumazet wrote:
>
> On 3/25/20 9:00 AM, Paolo Abeni wrote:
>
> > For the record, I have 2 others item on my list, I hope to have time to
> > process some day: the ingress dst->input and the default ->enqueue and
> > ->dequeue
>
> What is the default ->enqueue() and ->dequeue() ?
The idea is (or should I say 'was' ?!?) to tie it to NET_SCH_DEFAULT,
so it depends on your config...
> For us, this is FQ.
>
> (Even if we do not select NET_SCH_DEFAULT and leave pfifo_fast as the 'default' qdisc)
... this one will see no benefit.
Just out of sheer curiosity, why don't you set NET_SCH_DEFAULT?
Thanks,
Paolo
next prev parent reply other threads:[~2020-03-25 16:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 2:23 [PATCH net-next] net: use indirect call wrappers for skb_copy_datagram_iter() Eric Dumazet
2020-03-25 4:22 ` Eric Dumazet
2020-03-25 11:52 ` Paolo Abeni
2020-03-25 14:55 ` Willem de Bruijn
2020-03-25 16:00 ` Paolo Abeni
2020-03-25 16:07 ` Eric Dumazet
2020-03-25 16:24 ` Paolo Abeni [this message]
[not found] ` <CANn89iKotU9Tkd6KBgyicHFV72K9gZ+eeKwkPU097=gZZYCjrA@mail.gmail.com>
2020-03-25 16:46 ` Eric Dumazet
2020-03-25 20:58 ` Willem de Bruijn
2020-03-25 15:14 ` Eric Dumazet
2020-03-25 18:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e385f0c1edca94a882bdadf46f4ddb97d59a64a.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).