From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D769C433E0 for ; Thu, 4 Feb 2021 03:34:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F3D9364F5F for ; Thu, 4 Feb 2021 03:34:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234504AbhBDDeZ (ORCPT ); Wed, 3 Feb 2021 22:34:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234478AbhBDDeD (ORCPT ); Wed, 3 Feb 2021 22:34:03 -0500 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61C6DC061573; Wed, 3 Feb 2021 19:33:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Subject:Sender: Reply-To:Cc:Content-ID:Content-Description; bh=Dyu8cZeCdV6PkpUEQxxpmgbQNy767kTV8BXSItnpZnA=; b=yJpz9Kj2v6TMLAoYcPW6SFAO7n OStFZzriY/z5qsc2Z13mTztPKvwUTcQUQa2JW2bbhLJnLS/71N4clrhpJND0ejCzD+lz6JioGs1wZ 3wBGbNT9U9KiGuO0HiOp90jzUsOYvkOCjGLnPKh4IKjvX//wgSel/p4SvLsAIAyECe9xSIrnPFryw N0m4Mu01xxgzR47YBnYjFIoAyURTtA6l9rOM/6Z15PKfosjzf5Vd7pOURkFDeTjss0uj984A9BmJx b8KY0PBHCx8kdUiUgIwjJfgA4yDz49lF8YdxpZpDyUN1R2Ama95uTHJM2w82RCpEzaMMfgakMTo8w qp93ckAA==; Received: from [2601:1c0:6280:3f0::aec2] by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7VOS-0006ta-3J; Thu, 04 Feb 2021 03:33:20 +0000 Subject: Re: [PATCH V2] drivers: net: ethernet: i825xx: Fix couple of spellings and get rid of blank lines too in the file ether1.c To: Bhaskar Chowdhury , linux@armlinux.org.uk, davem@davemloft.net, kuba@kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210204011821.18356-1-unixbhaskar@gmail.com> From: Randy Dunlap Message-ID: <7e5dfce3-1343-4bad-1d64-b8f2eff8e2a6@infradead.org> Date: Wed, 3 Feb 2021 19:33:16 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/3/21 6:32 PM, Bhaskar Chowdhury wrote: > On 18:09 Wed 03 Feb 2021, Randy Dunlap wrote: >> On 2/3/21 5:18 PM, Bhaskar Chowdhury wrote: >>> >>> s/initialsation/initialisation/ >>> s/specifiing/specifying/ >>> >>> Plus get rid of few blank lines. >>> >>> Signed-off-by: Bhaskar Chowdhury >>> --- >>> Changes from V1: >>>    Fix typo in the subject line >>>    Give explanation of all the changes in changelog text >>> >>>  drivers/net/ethernet/i825xx/ether1.c | 9 +++------ >>>  1 file changed, 3 insertions(+), 6 deletions(-) >>> >>> diff --git a/drivers/net/ethernet/i825xx/ether1.c b/drivers/net/ethernet/i825xx/ether1.c >>> index a0bfb509e002..850ea32091ed 100644 >>> --- a/drivers/net/ethernet/i825xx/ether1.c >>> +++ b/drivers/net/ethernet/i825xx/ether1.c >> >> a. don't delete the blank lines >> b. the change below is not described and does not change any whitespace AFAICT. >>   I.e., DDT [don't do that]. >> > But what do you do when things getting automatically inducted in the > patch???(You got to believe me) > > I haven't had touch that bloody function with my keystroke and it gets it on > its own! Bemusing! > > Those blank lines too inducted from the fresh file(means in pristine form) ,so > thought pruning would be good..hence the decision to get rid of those. > > Wondering what the fuck is going on.... Yeah, it seems like you have had editor-doing-too-much-for-you issues before now... -- ~Randy