From: Heiner Kallweit <hkallweit1@gmail.com>
To: Petr Tesarik <ptesarik@suse.cz>
Cc: Realtek linux nic maintainers <nic_swsd@realtek.com>,
netdev@vger.kernel.org
Subject: Re: RTL8402 stops working after hibernate/resume
Date: Wed, 23 Sep 2020 11:57:41 +0200 [thread overview]
Message-ID: <7e6bbb75-d8db-280d-ac5b-86013af39071@gmail.com> (raw)
In-Reply-To: <20200903104122.1e90e03c@ezekiel.suse.cz>
On 03.09.2020 10:41, Petr Tesarik wrote:
> Hi Heiner,
>
> this issue was on the back-burner for some time, but I've got some
> interesting news now.
>
> On Sat, 18 Jul 2020 14:07:50 +0200
> Heiner Kallweit <hkallweit1@gmail.com> wrote:
>
>> [...]
>> Maybe the following gives us an idea:
>> Please do "ethtool -d <if>" after boot and after resume from suspend,
>> and check for differences.
>
> The register dump did not reveal anything of interest - the only
> differences were in the physical addresses after a device reopen.
>
> However, knowing that reloading the driver can fix the issue, I copied
> the initialization sequence from init_one() to rtl8169_resume() and
> gave it a try. That works!
>
> Then I started removing the initialization calls one by one. This
> exercise left me with a call to rtl_init_rxcfg(), which simply sets the
> RxConfig register. In other words, these is the difference between
> 5.8.4 and my working version:
>
> --- linux-orig/drivers/net/ethernet/realtek/r8169_main.c 2020-09-02 22:43:09.361951750 +0200
> +++ linux/drivers/net/ethernet/realtek/r8169_main.c 2020-09-03 10:36:23.915803703 +0200
> @@ -4925,6 +4925,9 @@
>
> clk_prepare_enable(tp->clk);
>
> + if (tp->mac_version == RTL_GIGA_MAC_VER_37)
> + RTL_W32(tp, RxConfig, RX128_INT_EN | RX_DMA_BURST);
> +
> if (netif_running(tp->dev))
> __rtl8169_resume(tp);
>
> This is quite surprising, at least when the device is managed by
> NetworkManager, because then it is closed on wakeup, and the open
> method should call rtl_init_rxcfg() anyway. So, it might be a timing
> issue, or incorrect order of register writes.
>
Thanks for the analysis. If you manually bring down and up the
interface, do you see the same issue?
What is the value of RxConfig when entering the resume function?
> Since I have no idea why the above change fixes my issue, I'm hesitant
> to post it as a patch. It might break other people's systems...
>
> Petr T
>
Heiner
next prev parent reply other threads:[~2020-09-23 9:57 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 8:28 RTL8402 stops working after hibernate/resume Petr Tesarik
2020-07-15 15:22 ` Heiner Kallweit
2020-07-16 8:58 ` Petr Tesarik
2020-07-18 12:07 ` Heiner Kallweit
2020-09-03 8:41 ` Petr Tesarik
2020-09-17 14:10 ` Petr Tesarik
2020-09-23 9:57 ` Heiner Kallweit [this message]
2020-09-24 19:14 ` Petr Tesarik
2020-09-24 19:37 ` Heiner Kallweit
2020-09-24 20:12 ` Heiner Kallweit
2020-09-25 7:30 ` Petr Tesarik
2020-09-25 8:54 ` Petr Tesarik
2020-09-25 9:44 ` Heiner Kallweit
2020-09-25 9:52 ` Petr Tesarik
2020-09-25 12:56 ` Petr Tesarik
2020-09-25 14:47 ` Heiner Kallweit
2020-09-29 19:07 ` Petr Tesarik
2020-09-29 19:41 ` Heiner Kallweit
2020-09-29 20:08 ` Hans de Goede
2020-09-29 20:29 ` Hans de Goede
2020-09-29 20:35 ` Heiner Kallweit
2020-09-29 20:42 ` Heiner Kallweit
2020-09-30 9:04 ` Hans de Goede
2020-09-30 15:47 ` Heiner Kallweit
2020-09-30 16:41 ` Petr Tesarik
2020-09-30 17:13 ` Heiner Kallweit
2020-09-30 17:32 ` Petr Tesarik
2020-09-30 18:00 ` Petr Tesarik
2020-09-30 20:11 ` Heiner Kallweit
2020-09-30 21:44 ` Petr Tesarik
2020-10-01 6:14 ` Heiner Kallweit
2020-09-30 18:10 ` Petr Tesarik
2020-09-29 21:17 ` Petr Tesarik
2020-07-15 15:25 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e6bbb75-d8db-280d-ac5b-86013af39071@gmail.com \
--to=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=ptesarik@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).