From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-170.mta1.migadu.com (out-170.mta1.migadu.com [95.215.58.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04EDD2E405 for ; Tue, 20 Aug 2024 14:24:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724163858; cv=none; b=OvhGxP44wZ8HaarqUJzdnYSWYyb8Sn1AQGjJnrAuFMww3Oj3odB8Uwrz4cQwPZjIksk8PgledHp8O92BlrEvna8mIJOWsbg/pzAfOGEg8We2Zy/aLfCW5Lq+Dl1SWHsRSAo8uw/UcFV9a9OGdtq/t8t5GsxbMdEyUURNtFB6bsY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724163858; c=relaxed/simple; bh=QCZ+RO1FUCsa+gJOU+RlcW8Xr/lVI2nNH4g8BamXv9s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cuDgK8n7wnoBdZoCDRHe8fjonKN+l4+smJZZi8H28y16KsPyVtET3LGTYSZCKvFA17q9JLFezRCJM5YF5iceaULUFtKOeVYbheNL+nlwrFpjeeZKYS+Yv2Mh5OLOTnRbCPK3ptwSfRSXkzEIBxmVwDgNaq33z5nsv0YOhGtpdoM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=JQyh+5//; arc=none smtp.client-ip=95.215.58.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="JQyh+5//" Message-ID: <7e6caa8b-ae79-4eb0-8ccb-d57471e8a3d5@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1724163855; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oIijWWzfx2wkvf+z8Rr+7gk9fjf1EjLJm1Yyu7y8HBk=; b=JQyh+5//XtwDM6g1Mmzckx2y0JJ0joJEPy2uXUHOrLq0UISdfFTTlhBHjg/5kCPiAtbF6k VTdO8EFbZ+HDZWLuO6zGQ1pcuM4qlm1VF0keJjjZyJ3Md5QQ3j1uO99BYRyG1oqRSdYrjX FDFan5rO8bIgUqlPAk866IuFb3Bp+sU= Date: Tue, 20 Aug 2024 10:24:11 -0400 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH net-next v2 1/5] net: xilinx: axienet: Always disable promiscuous mode To: Jakub Kicinski Cc: Radhey Shyam Pandey , netdev@vger.kernel.org, "David S . Miller" , Andrew Lunn , linux-arm-kernel@lists.infradead.org, Michal Simek , Daniel Borkmann , linux-kernel@vger.kernel.org, Paolo Abeni , Eric Dumazet , Simon Horman References: <20240815193614.4120810-1-sean.anderson@linux.dev> <20240815193614.4120810-2-sean.anderson@linux.dev> <20240819183041.2b985755@kernel.org> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson In-Reply-To: <20240819183041.2b985755@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 8/19/24 21:30, Jakub Kicinski wrote: > On Thu, 15 Aug 2024 15:36:10 -0400 Sean Anderson wrote: >> If promiscuous mode is disabled when there are fewer than four multicast >> addresses, then it will to be reflected in the hardware. Fix this by > > it will *not* be reflected? > Something is off with this commit messages, or at least I can't parse > >> always clearing the promiscuous mode flag even when we program multicast >> addresses. >> >> Fixes: 8a3b7a252dca ("drivers/net/ethernet/xilinx: added Xilinx AXI Ethernet driver") > > I think we should ship it as a fix to net? Yes, probably. I put these patches first so they could be easily cherry-picked. --Sean