From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBE34C282CE for ; Fri, 5 Apr 2019 20:51:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B52DC2146F for ; Fri, 5 Apr 2019 20:51:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WK5n2Pjp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726397AbfDEUvx (ORCPT ); Fri, 5 Apr 2019 16:51:53 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:45658 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726204AbfDEUvx (ORCPT ); Fri, 5 Apr 2019 16:51:53 -0400 Received: by mail-wr1-f68.google.com with SMTP id s15so9443505wra.12 for ; Fri, 05 Apr 2019 13:51:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=b+7evtD86Soj2jKZQb5ks7jLLteOebUBuklmB7OOTxA=; b=WK5n2Pjp+Quv5KifqTWBA2Ja3yeW6HpBIQ8q3B0Zr7Hw/NuuVzfNbASZmSJ488FelA Ee0NTpWvabHMJ2EYWVJELiChKU+sM9vKxriTW++TWG3EY0o19IzvBfZb0lwnKHFKF7W2 dMnULV69kOxok+a5Ruxq3MULHYOniIEsCz9lrZwHGKBr2NGZbNT5g1JSktRvkIRjfv/r xTqC8YSlwN8ZYP09o7l0E8A3mhHbwawpEXnLP2f8a7xUA1SsmpEeMtxvK1KQMytN21cL aQqtfJSzXPg+KbqlTwezpwEy2j90zwQS1bkSRQEzCIxH3SraNdjh+fgip//2rNCed4Ia 25yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=b+7evtD86Soj2jKZQb5ks7jLLteOebUBuklmB7OOTxA=; b=aVEnAdSqSmom6nsUWIue9KdjR9ID7Opoa/L0Onx4BEYNAUKl1Py8J96lKEH+7YffXe Qk6Gn8M9iZYR/CSWvTEHnbXLaHc2pe5EG0UoJPsurD1pQzOjDMUv2UgPKvEsVVAtn1i9 8VZkM27ghAbfmyyIiqvgU1HUt5FP290FEAsUua8YcAUIEZAONy/WPvOuEnAbjXb4avSj Cg5hpfbLPNOhiRpFsBT2rv+5sYb6dzlvZ+jnUSdepHWN3Xo7eozgCI0GBrA4YRvAFSFh N0h3GKBF+QjHgGwbbP5q/5cNk3p6rX/KLrmJxcrCPEuSE9iLPU4HeOcIP+IcFOMPBrlW QrNQ== X-Gm-Message-State: APjAAAX56Nc2DHPh19R2ZSIZYVkNktxPpn83gB3yuAybuB9hqZXngfA0 ukH6+VfSuQ7zF3O32l11ENH/Xmzv X-Google-Smtp-Source: APXvYqx6oRL6X8RvVpEkRpZoXaIUxQyWlHNl4QsTSqkAkiSO1A2NYwk1cI8X7QByAzLv3Ma+/ukaxg== X-Received: by 2002:a5d:69c7:: with SMTP id s7mr9664815wrw.71.1554497511065; Fri, 05 Apr 2019 13:51:51 -0700 (PDT) Received: from ?IPv6:2003:ea:8be1:dd00:c5f4:1013:b1cb:d123? (p200300EA8BE1DD00C5F41013B1CBD123.dip0.t-ipconnect.de. [2003:ea:8be1:dd00:c5f4:1013:b1cb:d123]) by smtp.googlemail.com with ESMTPSA id z140sm5900085wmc.27.2019.04.05.13.51.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Apr 2019 13:51:50 -0700 (PDT) Subject: Re: [PATCH net-next] net: phy: improve link partner capability detection To: Andrew Lunn Cc: Florian Fainelli , David Miller , "netdev@vger.kernel.org" References: <20190405194821.GI23536@lunn.ch> <6a86f31f-dda8-77d9-aace-9ad1ad770a28@gmail.com> <20190405202729.GK23536@lunn.ch> <20190405204319.GM23536@lunn.ch> From: Heiner Kallweit Message-ID: <7e6fc94d-5da9-b87d-a0d3-3e2ee5ff5961@gmail.com> Date: Fri, 5 Apr 2019 22:51:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190405204319.GM23536@lunn.ch> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 05.04.2019 22:43, Andrew Lunn wrote: >> Right. BMSR_ESTATEN should not be set on a Fast PHY. Handling of this >> case didn't change. >> >>> A Fast MAC connected to a Giga PHY. The MAC driver will of used >>> phy_set_max_speed() to indicate its limits. In that case, MII_STAT1000 >>> does exist and we should report what the peer is advertising. >>> >> That's what we're doing now with this patch. > > Hi Heiner > > What i don't get is why we need to do anything based on the MAC. All > we need to do is look at BMSR_ESTATEN, and from that decided if we > should look at MII_STAT1000 or not. When reporting what the peer can > do, we should not care what the local MAC can do. > Do we have a misunderstanding? What you describe is exactly what we're doing now. BMSR_ESTATEN is read by genphy_read_abilities(). I just don't want to read BMSR whenever genphy_read_status() is called. > Andrew > Heiner