From: Andrew Lunn <andrew@lunn.ch>
To: Yongzhao Chen <yongzhao.derek@gmail.com>
Cc: Christian Marangi <ansuelsmth@gmail.com>,
netdev@vger.kernel.org, Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: phy: qca83xx: read resolved QCA8337 link status
Date: Thu, 1 Oct 2026 20:46:43 +0200 [thread overview]
Message-ID: <7eed302b-d455-447f-9ce9-f15468b9792b@lunn.ch> (raw)
In-Reply-To: <20261001181634.1508-1-yongzhao.derek@gmail.com>
> This covers the resolved downshift case only.
It is good testing, thanks.
> It does not show whether
> BMSR can report link up while register 0x11 is still unresolved, and
> it does not change the SPEED_UNKNOWN limitation from my previous reply.
Greed.
> Given the traffic failure, I would like to target net for v2. Three
> questions:
>
> 1. Is net appropriate, or should this stay in net-next?
The traffic failure was however because of the error with setting the
DACs?
> 2. Is 272833b9b3b3 ("net: phy: add support for qca8k switch internal
> PHY in at803x") the right Fixes target? It added the QCA8337 entry
> without .read_status; I have not checked whether the problem
> predates it. Christian, as its author, is now on Cc.
Reporting the correct downshift has nothing to do with that, as far as
i understand. Correctly reporting downshift i would put to net-next.
> 3. Compared with genphy_read_status(), the helper takes the forced-mode
> speed from register 0x11 rather than BMCR and adds MDI-X reporting,
> and the added genphy_read_master_slave() call runs on every poll. Is
> that scope acceptable for net, or would you prefer a narrower fix?
net is fixing broken things, especially regressions. net-next is new
features.
Andrew
next prev parent reply other threads:[~2026-10-01 18:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 22:07 [PATCH net-next] net: phy: qca83xx: read resolved QCA8337 link status Yongzhao Chen
2026-09-29 0:40 ` Andrew Lunn
2026-09-30 21:23 ` Yongzhao Chen
2026-09-30 21:33 ` Andrew Lunn
2026-10-01 18:16 ` Yongzhao Chen
2026-10-01 18:46 ` Andrew Lunn [this message]
2026-10-02 20:35 ` Yongzhao Chen
2026-10-03 14:38 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7eed302b-d455-447f-9ce9-f15468b9792b@lunn.ch \
--to=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yongzhao.derek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox