From: Eric Dumazet <eric.dumazet@gmail.com>
To: Chintan Shah <chintsha@cisco.com>,
davem@davemloft.net, kuznet@ms2.inr.ac.ru, jmorris@namei.org,
yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: kamensky@cisco.com, takondra@cisco.com,
xe-linux-external@cisco.com, enkechen@cisco.com
Subject: Re: [PATCH] net: disable UDP punt on sockets in RCV_SHUTDWON
Date: Fri, 4 May 2018 16:44:52 -0700 [thread overview]
Message-ID: <7ef94995-9c5b-4f53-e1e3-e12e74817e9f@gmail.com> (raw)
In-Reply-To: <1525468117-61242-1-git-send-email-chintsha@cisco.com>
On 05/04/2018 02:08 PM, Chintan Shah wrote:
> A UDP application which opens multiple sockets with same local
> address/port combination (using SO_REUSEPORT/SO_REUSEADDR socket options);
> and issues connect to a remote socket (using one of these local socket).
> Now if the same socket, which issued connect, issues shutdown (SHUT_RD);
> packets would still be queued to this socket (if sent from same remote
> client, which the local socket connected to), and not delivered to the
> other socket in the normal state.
>
Confusing changelog.
sk_shutdown is on a different cache line, so this additional fetch would cause
loss of performance if many sockets are scanned in the hash bucket.
If you are trying to add full 4-tuple hash table to UDP, and accept() ability,
this would require a bit more than this hack...
prev parent reply other threads:[~2018-05-04 23:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 21:08 [PATCH] net: disable UDP punt on sockets in RCV_SHUTDWON Chintan Shah
2018-05-04 23:44 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ef94995-9c5b-4f53-e1e3-e12e74817e9f@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=chintsha@cisco.com \
--cc=davem@davemloft.net \
--cc=enkechen@cisco.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kamensky@cisco.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=takondra@cisco.com \
--cc=xe-linux-external@cisco.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).