From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F4FB1367 for ; Sun, 1 Oct 2023 06:36:54 +0000 (UTC) Received: from omta034.useast.a.cloudfilter.net (omta034.useast.a.cloudfilter.net [44.202.169.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E36F6C2 for ; Sat, 30 Sep 2023 23:36:52 -0700 (PDT) Received: from eig-obgw-5004a.ext.cloudfilter.net ([10.0.29.221]) by cmsmtp with ESMTP id mlWmqFZLIIBlVmq42qir3K; Sun, 01 Oct 2023 06:36:26 +0000 Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with ESMTPS id mq4Rqu20OXQGamq4SqtCnQ; Sun, 01 Oct 2023 06:36:52 +0000 X-Authority-Analysis: v=2.4 cv=DJGcXgBb c=1 sm=1 tr=0 ts=65191384 a=1YbLdUo/zbTtOZ3uB5T3HA==:117 a=P7XfKmiOJ4/qXqHZrN7ymg==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=bhdUkHdE2iEA:10 a=wYkD_t78qR0A:10 a=NEAV23lmAAAA:8 a=AGRr4plBAAAA:8 a=J1Y8HTJGAAAA:8 a=1XWaLZrsAAAA:8 a=VwQbUJbxAAAA:8 a=20KFwNOVAAAA:8 a=cm27Pg_UAAAA:8 a=YSKGN3ub9cUXa_79IdMA:9 a=QEXdDO2ut3YA:10 a=bOnWt3ThIoLzEnqt84vq:22 a=y1Q9-5lHfBjTkpIzbSAN:22 a=AjGcO6oz07-iQ99wixmX:22 a=xmb-EsYY8bH0VWELuYED:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=YW4LnEq/eBLDUviFpnXJ6qtKfen1E/plxXVxSih4JEM=; b=bsDCHjTJh4jyfLGIOdd4ITxnUQ GOWCqpr1c7oQ8vZuXFQHPBt3eemH/1DQRxz9UqneUkoUu97nqWG+Ofw3JqALssKkJWmfn7r26axKe ApVhcDQVz2U9cZrqlmNq/Oz1Yyw4K6GP5wf7nLF/CpitDYmXnVsTyQIMMA1iv5zsNDvHiLQ+3LAOX /bFYvYg6I1zFZq3d1wOWdGXZ4H5D45rbcNumhNF0ZyAErQugxCCCQlTafqLVA1gq7yeObWlZaxzxk 15u/wUEjnaIDqESwnQX4y+/Y9A0U4k+UYy1Hz7sFbifoFL7aGTl913ct2yxeWfYybsQDKAnFSnzdg nEccV3sg==; Received: from [94.239.20.48] (port=51586 helo=[192.168.1.98]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1qmq4Q-001KEL-2q; Sun, 01 Oct 2023 01:36:51 -0500 Message-ID: <7f0b1ca5-c0e9-0415-58ab-6fb6bcf9d73f@embeddedor.com> Date: Sun, 1 Oct 2023 08:36:46 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 4/5] cxgb4: Annotate struct sched_table with __counted_by Content-Language: en-US To: Kees Cook , Raju Rangoju Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, "Gustavo A. R. Silva" , Nathan Chancellor , Nick Desaulniers , Tom Rix , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, llvm@lists.linux.dev References: <20230929181042.work.990-kees@kernel.org> <20230929181149.3006432-4-keescook@chromium.org> From: "Gustavo A. R. Silva" In-Reply-To: <20230929181149.3006432-4-keescook@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 94.239.20.48 X-Source-L: No X-Exim-ID: 1qmq4Q-001KEL-2q X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.1.98]) [94.239.20.48]:51586 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 50 X-Org: HG=hgshared;ORG=hostgator; X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfJM0DzH+/e84hancLHJt618CytykhS3bdyUBhK1lbUdVQL1m+N7Vet17kt9sJxVyWKpOuMymTrTTdxXazdAhykahZV8Rqo5rCkPT+g4qnuOt9Zc6on5d vqcFj6Bf9ftqdzCZRVWTaovJLRsfa/QrPllrdb530DzlcVNgyA1+JgDOEzYdxck+w3wcPVaDYzU1AkjENvEnKCf5OSTIfksIDpg= X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On 9/29/23 20:11, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct sched_table. > > [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: Raju Rangoju > Cc: "David S. Miller" > Cc: Eric Dumazet > Cc: Jakub Kicinski > Cc: Paolo Abeni > Cc: netdev@vger.kernel.org > Signed-off-by: Kees Cook Reviewed-by: Gustavo A. R. Silva Thanks -- Gustavo > --- > drivers/net/ethernet/chelsio/cxgb4/sched.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/chelsio/cxgb4/sched.h b/drivers/net/ethernet/chelsio/cxgb4/sched.h > index 5f8b871d79af..6b3c778815f0 100644 > --- a/drivers/net/ethernet/chelsio/cxgb4/sched.h > +++ b/drivers/net/ethernet/chelsio/cxgb4/sched.h > @@ -82,7 +82,7 @@ struct sched_class { > > struct sched_table { /* per port scheduling table */ > u8 sched_size; > - struct sched_class tab[]; > + struct sched_class tab[] __counted_by(sched_size); > }; > > static inline bool can_sched(struct net_device *dev)