From: David Ahern <dsahern@gmail.com>
To: Jiri Pirko <jiri@resnulli.us>, David Ahern <dsahern@gmail.com>
Cc: netdev@vger.kernel.org, stephen@networkplumber.org,
jakub.kicinski@netronome.com, saeedm@mellanox.com,
mlxsw@mellanox.com, f.fainelli@gmail.com
Subject: Re: [patch iproute2-next v4 0/2] devlink: couple forgotten flash patches
Date: Sun, 15 Sep 2019 11:58:33 -0600 [thread overview]
Message-ID: <7f32dc69-7cc1-4488-a1b6-94db64748630@gmail.com> (raw)
In-Reply-To: <20190914060012.GC2276@nanopsycho.orion>
On 9/14/19 12:00 AM, Jiri Pirko wrote:
> Fri, Sep 13, 2019 at 07:25:07PM CEST, dsahern@gmail.com wrote:
>> On 9/12/19 12:29 PM, Jiri Pirko wrote:
>>> From: Jiri Pirko <jiri@mellanox.com>
>>>
>>> I was under impression they are already merged, but apparently they are
>>> not. I just rebased them on top of current iproute2 net-next tree.
>>>
>>
>> they were not forgotten; they were dropped asking for changes.
>>
>> thread is here:
>> https://lore.kernel.org/netdev/20190604134450.2839-3-jiri@resnulli.us/
>
> Well not really. The path was discussed in the thread. However, that is
> unrelated to the changes these patches do. The flashing itself is
> already there and present. These patches only add status.
>
> Did I missed something?
>
you are thinking like a kernel developer and not a user.
The second patch has a man page change that should state that firmware
files are expected to be in /lib/firmware and that path is added by the
kernel so the path passed on the command line needs to drop that part.
next prev parent reply other threads:[~2019-09-15 17:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 11:29 [patch iproute2-next v4 0/2] devlink: couple forgotten flash patches Jiri Pirko
2019-09-12 11:29 ` [patch iproute2-next v4 1/2] devlink: implement flash update status monitoring Jiri Pirko
2019-09-12 11:29 ` [patch iproute2-next v4 2/2] devlink: implement flash " Jiri Pirko
2019-09-13 17:25 ` [patch iproute2-next v4 0/2] devlink: couple forgotten flash patches David Ahern
2019-09-14 6:00 ` Jiri Pirko
2019-09-15 17:58 ` David Ahern [this message]
2019-09-16 5:31 ` Jiri Pirko
2019-09-16 10:09 ` Jiri Pirko
2019-09-16 14:49 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f32dc69-7cc1-4488-a1b6-94db64748630@gmail.com \
--to=dsahern@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@resnulli.us \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox