From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C218BC10F1E for ; Tue, 20 Dec 2022 06:49:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233116AbiLTGtA (ORCPT ); Tue, 20 Dec 2022 01:49:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229500AbiLTGs6 (ORCPT ); Tue, 20 Dec 2022 01:48:58 -0500 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E2AC115B; Mon, 19 Dec 2022 22:48:50 -0800 (PST) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 8F2BD24DBD3; Tue, 20 Dec 2022 14:48:38 +0800 (CST) Received: from EXMBX173.cuchost.com (172.16.6.93) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 20 Dec 2022 14:48:38 +0800 Received: from [192.168.120.49] (171.223.208.138) by EXMBX173.cuchost.com (172.16.6.93) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 20 Dec 2022 14:48:36 +0800 Message-ID: <7f4339df-6616-120f-f16a-cd38a2b6ea1d@starfivetech.com> Date: Tue, 20 Dec 2022 14:48:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2 2/9] dt-bindings: net: snps,dwmac: Update the maxitems number of resets and reset-names To: Krzysztof Kozlowski , , , , CC: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Richard Cochran , Andrew Lunn , Heiner Kallweit , Peter Geis References: <20221216070632.11444-1-yanhong.wang@starfivetech.com> <20221216070632.11444-3-yanhong.wang@starfivetech.com> <040b56b1-c65c-34c3-e4a1-5cae4428d1d2@linaro.org> Content-Language: en-US From: yanhong wang In-Reply-To: <040b56b1-c65c-34c3-e4a1-5cae4428d1d2@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [171.223.208.138] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX173.cuchost.com (172.16.6.93) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2022/12/16 19:03, Krzysztof Kozlowski wrote: > On 16/12/2022 08:06, Yanhong Wang wrote: >> Some boards(such as StarFive VisionFive v2) require more than one value >> which defined by resets property, so the original definition can not >> meet the requirements. In order to adapt to different requirements, >> adjust the maxitems number from 1 to 3.. >> >> Signed-off-by: Yanhong Wang >> --- >> .../devicetree/bindings/net/snps,dwmac.yaml | 15 +++++++++++---- >> 1 file changed, 11 insertions(+), 4 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >> index e26c3e76ebb7..7870228b4cd3 100644 >> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml >> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >> @@ -133,12 +133,19 @@ properties: >> - ptp_ref >> >> resets: >> - maxItems: 1 >> - description: >> - MAC Reset signal. >> + minItems: 1 >> + maxItems: 3 >> + additionalItems: true >> + items: >> + - description: MAC Reset signal >> >> reset-names: >> - const: stmmaceth >> + minItems: 1 >> + maxItems: 3 >> + additionalItems: true >> + contains: >> + enum: >> + - stmmaceth > > No, this is highly unspecific and you know affect all the schemas using > snps,dwmac.yaml. Both lists must be specific - for your device and for > others. > I have tried to define the resets in "starfive,jh71x0-dwmac.yaml", but it can not over-write the maxItems limit in "snps,dwmac.yaml",therefore, it will report error "reset-names: ['stmmaceth', 'ahb'] is too long" running "make dt_binding_check". Do you have any suggestions to deal with this situation? > Best regards, > Krzysztof >