From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E19BC43381 for ; Tue, 26 Feb 2019 17:19:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 17EF120652 for ; Tue, 26 Feb 2019 17:19:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728630AbfBZRTK (ORCPT ); Tue, 26 Feb 2019 12:19:10 -0500 Received: from opengridcomputing.com ([72.48.214.68]:42384 "EHLO smtp.opengridcomputing.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727416AbfBZRTK (ORCPT ); Tue, 26 Feb 2019 12:19:10 -0500 Received: from [10.10.0.239] (cody.ogc.int [10.10.0.239]) by smtp.opengridcomputing.com (Postfix) with ESMTPSA id 820162265A; Tue, 26 Feb 2019 11:19:09 -0600 (CST) Subject: Re: [PATCH v1 iproute2-next 1/4] rdma: add helper rd_sendrecv_msg() To: Leon Romanovsky Cc: dsahern@gmail.com, stephen@networkplumber.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org References: <20190223092615.GM23561@mtr-leonro.mtl.com> <20190223093122.GO23561@mtr-leonro.mtl.com> From: Steve Wise Message-ID: <7f48fc85-45ab-fe7d-9614-4c5eb50f8401@opengridcomputing.com> Date: Tue, 26 Feb 2019 11:19:12 -0600 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190223093122.GO23561@mtr-leonro.mtl.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/23/2019 3:31 AM, Leon Romanovsky wrote: > On Sat, Feb 23, 2019 at 11:26:15AM +0200, Leon Romanovsky wrote: >> On Thu, Feb 21, 2019 at 08:19:03AM -0800, Steve Wise wrote: >>> This function sends the constructed netlink message and then >>> receives the response, displaying any error text. >>> >>> Change 'rdma dev set' to use it. >>> >>> Signed-off-by: Steve Wise >>> --- >>> rdma/dev.c | 2 +- >>> rdma/rdma.h | 1 + >>> rdma/utils.c | 21 +++++++++++++++++++++ >>> 3 files changed, 23 insertions(+), 1 deletion(-) >>> >>> diff --git a/rdma/dev.c b/rdma/dev.c >>> index 60ff4b31e320..d2949c378f08 100644 >>> --- a/rdma/dev.c >>> +++ b/rdma/dev.c >>> @@ -273,7 +273,7 @@ static int dev_set_name(struct rd *rd) >>> mnl_attr_put_u32(rd->nlh, RDMA_NLDEV_ATTR_DEV_INDEX, rd->dev_idx); >>> mnl_attr_put_strz(rd->nlh, RDMA_NLDEV_ATTR_DEV_NAME, rd_argv(rd)); >>> >>> - return rd_send_msg(rd); >>> + return rd_sendrecv_msg(rd, seq); >>> } >>> >>> static int dev_one_set(struct rd *rd) >>> diff --git a/rdma/rdma.h b/rdma/rdma.h >>> index 547bb5749a39..20be2f12c4f8 100644 >>> --- a/rdma/rdma.h >>> +++ b/rdma/rdma.h >>> @@ -115,6 +115,7 @@ bool rd_check_is_key_exist(struct rd *rd, const char *key); >>> */ >>> int rd_send_msg(struct rd *rd); >>> int rd_recv_msg(struct rd *rd, mnl_cb_t callback, void *data, uint32_t seq); >>> +int rd_sendrecv_msg(struct rd *rd, unsigned int seq); >>> void rd_prepare_msg(struct rd *rd, uint32_t cmd, uint32_t *seq, uint16_t flags); >>> int rd_dev_init_cb(const struct nlmsghdr *nlh, void *data); >>> int rd_attr_cb(const struct nlattr *attr, void *data); >>> diff --git a/rdma/utils.c b/rdma/utils.c >>> index 069d44fece10..a6f2826c9605 100644 >>> --- a/rdma/utils.c >>> +++ b/rdma/utils.c >>> @@ -664,6 +664,27 @@ int rd_recv_msg(struct rd *rd, mnl_cb_t callback, void *data, unsigned int seq) >>> return ret; >>> } >>> >>> +static int null_cb(const struct nlmsghdr *nlh, void *data) >>> +{ >>> + return MNL_CB_OK; >>> +} >>> + >>> +int rd_sendrecv_msg(struct rd *rd, unsigned int seq) >>> +{ >>> + int ret; >>> + >>> + ret = rd_send_msg(rd); >>> + if (ret) { >>> + perror(NULL); >> This is more or less already done in rd_send_msg() and that function >> prints something in case of execution error. So the missing piece >> is to update rd_recv_msg(), so all places will "magically" print errors >> and not only dev_set_name(). >> >>> + goto out; >>> + } >>> + ret = rd_recv_msg(rd, null_cb, rd, seq); > Will this "null_cb" work for all send/recv flows or only in flows where > response can be error only? Only those flows where no nl attributes are expected to be returned. > Will we need this recv_msg if we implement > extack support? I'm not sure how extack works.  Do you know? Thanks! Steve.