From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikolay Aleksandrov Subject: Re: [SPAM]Re: [PATCH net-next 5/6] net: bridge: get msgtype from nlmsghdr in mdb ops Date: Thu, 18 May 2017 20:01:12 +0300 Message-ID: <7f4c1954-bf78-9160-64d0-ed45cad388e6@cumulusnetworks.com> References: <20170517212709.6473-1-vivien.didelot@savoirfairelinux.com> <20170517212709.6473-6-vivien.didelot@savoirfairelinux.com> <87efvmf9fl.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "moderated list:ETHERNET BRIDGE" , kernel@savoirfairelinux.com, linux-kernel@vger.kernel.org, "David S. Miller" To: Vivien Didelot , netdev@vger.kernel.org Return-path: In-Reply-To: <87efvmf9fl.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bridge-bounces@lists.linux-foundation.org Errors-To: bridge-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org On 5/18/17 6:53 PM, Vivien Didelot wrote: > Hi Nikolay, > > Nikolay Aleksandrov writes: > >>> + int msgtype = nlh->nlmsg_type; >> >> minor nits: >> nlmsg_type is a u16, also please keep the order and arrange these from longest >> to shortest > > The reverse christmas tree \o/ > > Hum, __br_mdb_notify takes an int type, and struct nlmsghdr defines it > as a __u16. Does u16 still make sense here instead of int? > > > Thanks, > > Vivien > Either way is fine as long as the value is unchanged, and since the rest of the code uses an int then lets be consistent and leave it or if you decide change all. Cheers, Nik