From: Jiayuan Chen <jiayuan.chen@linux.dev>
To: Eric Dumazet <edumazet@google.com>
Cc: netdev@vger.kernel.org, Antonius <antonius@bluedragonsec.com>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
"Jason Xing" <kerneljasonxing@gmail.com>,
"Kuniyuki Iwashima" <kuniyu@google.com>,
"Michal Luczaj" <mhal@rbox.co>,
"Mina Almasry" <almasrymina@google.com>,
"Eric Biggers" <ebiggers@google.com>,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
"Soheil Hassas Yeganeh" <soheil@google.com>,
"Alexander Duyck" <alexanderduyck@fb.com>,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH net v1] net: skb: fix cross-cache free of KFENCE-allocated skb head
Date: Thu, 2 Apr 2026 16:38:34 +0800 [thread overview]
Message-ID: <7f4e3b36-3e9e-4db5-9423-cbf4174e30d5@linux.dev> (raw)
In-Reply-To: <CANn89iLLwk9G6K8r=hOxsQQ2AsW751E+2pOoud9c-R+R-3i6hg@mail.gmail.com>
On 4/2/26 4:03 PM, Eric Dumazet wrote:
> On Wed, Apr 1, 2026 at 9:15 PM Jiayuan Chen <jiayuan.chen@linux.dev> wrote:
>> If we no longer care about the cost of accessing a struct page in the
>> free path, which the original commit was trying to avoid, this is
>> indeed the simplest fix — kfree() correctly handles objects via
>> virt_to_slab.
> We only have SLUB in modern kernels, kmem_cache_free() needs to touch it.
>
> Using is_kfence_address() in net/core/skbuff.c is pushing too hard in
> my opinion.
Thanks, I understand.
prev parent reply other threads:[~2026-04-02 8:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 3:31 [PATCH net v1] net: skb: fix cross-cache free of KFENCE-allocated skb head Jiayuan Chen
2026-04-02 4:01 ` Eric Dumazet
2026-04-02 4:15 ` Jiayuan Chen
2026-04-02 8:03 ` Eric Dumazet
2026-04-02 8:38 ` Jiayuan Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f4e3b36-3e9e-4db5-9423-cbf4174e30d5@linux.dev \
--to=jiayuan.chen@linux.dev \
--cc=alexanderduyck@fb.com \
--cc=almasrymina@google.com \
--cc=antonius@bluedragonsec.com \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=ebiggers@google.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kerneljasonxing@gmail.com \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhal@rbox.co \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=soheil@google.com \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox