From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9432B54FA4 for ; Tue, 27 Feb 2024 07:48:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709020134; cv=none; b=iROE31LfSJ7RKKQGHODx9aegD56k9OhuB3c4VGarcuTtmMeLG14a7BwmjBOk2R3dUm/qUJOCbUT32btfZzHWXcMmB22vBamtIc69v8rQpxRPti3szGkZMhIFHGh1Pq4M8awLzNUwwYCGSYN5zmjik28bKnMV/2L3cgtR5e4INZE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709020134; c=relaxed/simple; bh=0XcpYIVycFq8C6EZqoO1e5SnrQdaeiWBYSh8TFw+qrY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TYJM02zenyv/VtO1AUZ55gEdgYdNppeKYP18KfdVBmdhf/OAzB74wcrqpGYv+XwvgCdDByTIBrlLOwOQEhCPMktVwz39vi9M/POLu/HzREWe7VyCvbtW7M0vKALYxDicq8GQwkNTZeNwRtEARvON9KBsgHeGALa8C+cP41tgzdU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=TesDGQWl; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="TesDGQWl" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-a3f4464c48dso459618566b.3 for ; Mon, 26 Feb 2024 23:48:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709020131; x=1709624931; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=zpa7FJE7ovtFcXBy2ufebK/95x4a764UoBJ00w2JWHM=; b=TesDGQWl4/6lKitHd++dlrK/uNzm/LVSbj7P2qTVyxfRy0C1IYj1UuoWmMf6Mn3bsL jD1uAHNmQxA5xEhGrpF/0TNLOSFnZBAtGoMSNBUUf8ciHFwJrvLcGDDaBWOWxmTHbJj+ m4scNBB1JllEIcJni5hyZ38j9S1aWeiU1vJmq5OYI3+AgjCGApm++Lvw4gWpVEBd5vXs nMnZIcJAH36tFfJTXP46zOqC2f49c4ZIMi4M+FYYL0Mh9LST3fL+HSbUM+gcGLbH+W3s 5qEx+oEBUWGRq0boLFarOJKxJIubePm5H9E3fO68MydT7GTpVdfdoKOxw/HXg2w8j07z LIEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709020131; x=1709624931; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zpa7FJE7ovtFcXBy2ufebK/95x4a764UoBJ00w2JWHM=; b=sZU7mz6GAPOg+G+dxWnAEXawgvqIppTqQ341hJmh5RuSI0DLLjU/wSzCWcen8UETQi CVro85/X0dBJe1OBxcAdv8np7lOATkYmkGuYa4x/nW5RH/lgFoocGRvcViZi/ETqWWq1 xn8rImef0A9k/ZLqOEVlgy02A2t7FvWJ9y+Tlj8A38taE/I+T5TcgBuZLc+/sfnUPmxm GXus6AlxwVHyRU4KhDhaK2zaKz/Rp27rFKjvNlvLG4yRQP5xlvf+/s5KhbIFOPb2pE5/ PtQTwNDOq71gXmRfxi/382AhebO4P+Qjq7aq/Ah6LhMkAInVXBkaypcjJdOZtXVGoQ8f bB7g== X-Gm-Message-State: AOJu0Yw3QEg5+rn2f+3n91yoGwKovQhao3pvsq4JQqz+46HIPJXKe7OR 1+tmOwa2nNqQ+GkYiOecehjbbHtF3plhqmzOz0FoWRzmQGDv8zcVThKx1wQ3f2Q= X-Google-Smtp-Source: AGHT+IFLsOEBbPXwnKa00McbfaYLvGgBP0506INWeHuKc2pJp33JhOhXvHnYbVXwL+K77BweHSD+og== X-Received: by 2002:a17:906:3488:b0:a43:ccd:a816 with SMTP id g8-20020a170906348800b00a430ccda816mr4908976ejb.31.1709020130888; Mon, 26 Feb 2024 23:48:50 -0800 (PST) Received: from [192.168.1.20] ([178.197.222.116]) by smtp.gmail.com with ESMTPSA id vg15-20020a170907d30f00b00a4319de07c6sm488962ejc.127.2024.02.26.23.48.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Feb 2024 23:48:50 -0800 (PST) Message-ID: <7f722ffc-b0b5-4bd7-a46b-3ce5ae61ad5d@linaro.org> Date: Tue, 27 Feb 2024 08:48:47 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v4 6/6] net: hisi_femac: remove unused compatible strings To: Yang Xiwen , Yisen Zhuang , Salil Mehta , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , Heiner Kallweit , Russell King Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20240222-net-v4-0-eea68f93f090@outlook.com> <20240222-net-v4-6-eea68f93f090@outlook.com> <90ab2113-f3f7-4d1f-83ca-aa57cbe63a79@linaro.org> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 27/02/2024 08:36, Yang Xiwen wrote: > On 2/27/2024 2:53 PM, Krzysztof Kozlowski wrote: >> On 27/02/2024 02:51, Yang Xiwen wrote: >>> On 2/26/2024 3:55 PM, Krzysztof Kozlowski wrote: >>>> On 22/02/2024 13:43, Yang Xiwen via B4 Relay wrote: >>>>> From: Yang Xiwen >>>>> >>>>> The only documented SoC Hi3516DV300 does not receive any updates from 8 >>>>> years ago. With the recent driver changes, it unlikely works for this >>>>> SoC anymore. Remove the binding for this SoC. >>>>> >>>>> Also it's hard to get the version number and it's unknown how the >>>>> version can be used. Remove them until it's really needed. >>>>> >>>>> Signed-off-by: Yang Xiwen >>>>> --- >>>>> drivers/net/ethernet/hisilicon/hisi_femac.c | 4 +--- >>>>> 1 file changed, 1 insertion(+), 3 deletions(-) >>>>> >>>>> diff --git a/drivers/net/ethernet/hisilicon/hisi_femac.c b/drivers/net/ethernet/hisilicon/hisi_femac.c >>>>> index eab91e011d11..9466ca9da2bb 100644 >>>>> --- a/drivers/net/ethernet/hisilicon/hisi_femac.c >>>>> +++ b/drivers/net/ethernet/hisilicon/hisi_femac.c >>>>> @@ -990,9 +990,7 @@ static int hisi_femac_drv_resume(struct platform_device *pdev) >>>>> #endif >>>>> >>>>> static const struct of_device_id hisi_femac_match[] = { >>>>> - {.compatible = "hisilicon,hisi-femac-v1",}, >>>>> - {.compatible = "hisilicon,hisi-femac-v2",}, >>>>> - {.compatible = "hisilicon,hi3516cv300-femac",}, >>>>> + {.compatible = "hisilicon,hisi-femac",}, >>>> >>>> What is happening here? Removal could be justified, but then order of >>>> your patches is totally wrong. But that hisi-femac is a no-go or provide >>>> proper rationale. >>> >>> I don't understand exactly... In dts, we commonly have a SoC specific >>> compatible string first, generic compatible string the second. e.g. >>> >>> compatible = "hisilicon,hi3798mv200-perictrl", "syscon", "simple-mfd". >> >> There is no generic compatible here. hi3798mv200 is soc. >> >>> >>> So i think this is recommended. Or does it mean we only need them in >> >> It is allowed for certain cases and recommended for even fewer ones. Do >> you want to say you have fully discoverable features here and you do not >> need any properties? Or you want to say that all possible hardware will >> have exactly the same programming interface (registers etc)? > > Of course not. Take FEMAC for example. The FEMAC core on Hi3516 and If they have different programming interface then you cannot use generic compatible as fallback. > Hi3798 can programmed in the same way. They use the same > resources(resets and clocks). Though still a bit different in hardware, > basically the fifo depth etc.. > > Hi3516 FEMAC is not special enough to have a new compatible string, nor > do hi3798 FEMAC. Nor do i think we need those undocumented version > numbers, i.e. "hisilicon,hisi-femac-v1/2". As i observed, this driver is > generic enough to handle all the FEMAC cores i know, no matter which > version nor which SoC. This can also be concluded from the driver, the > driver defined 3 compatibles but they are all treated the same. > > Should I remove all of them, and only leave a generic > "hisilicon,hisi-femac" instead? No. Use one SoC specific compatible as fallback. That's what we ask almost every time... Best regards, Krzysztof