From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 238F8C282D7 for ; Sat, 2 Feb 2019 17:05:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D763420856 for ; Sat, 2 Feb 2019 17:05:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L5B9P0gU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726433AbfBBRFQ (ORCPT ); Sat, 2 Feb 2019 12:05:16 -0500 Received: from mail-ot1-f67.google.com ([209.85.210.67]:41020 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725828AbfBBRFQ (ORCPT ); Sat, 2 Feb 2019 12:05:16 -0500 Received: by mail-ot1-f67.google.com with SMTP id u16so8777375otk.8 for ; Sat, 02 Feb 2019 09:05:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=yo6s5M2aPefVAOocUEZjA/uDVWPE3BNf5Kp/Pckz2Y8=; b=L5B9P0gUy2amqWPZzDIHjYzksWWelLeoGh3YE3Cd0ghnNjyFcIMsUsLU9ZI7F1ePhm LkKUZxFV9Ph1uCAUPaj5hjtsE7F257r9uLFv82GW5PzeJxKo6UH6uKFlAaxJMS7dws/H 1vxqRxFSYl7X3o+8vHSYa8K503v7pqZtb6RqjrVLMXqEwdYa4sIgWxY5x1w5OggdvHP/ /4iXTwvg1mvihNAYY6lAGL0r7si2MtWMM2oY5bTYiRYXXwn4tvpSxZffCQgCJ6E+W2Eb 4e7/dqO+EBsi8yiV9lg4BZrSIN5mqVyKwSI99HpqrpCbo0pSN/EnXg1RKwENV4x1Egbl yKYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=yo6s5M2aPefVAOocUEZjA/uDVWPE3BNf5Kp/Pckz2Y8=; b=jvDrzth/jvaZkiKg1O0m3Z28BxO7OdriY8qo+wBkBM8XWBU6chuOXdKQNfvq6OKRf7 4hxr7JYLjXlHKMx6BKgsv23hDz6vNKROJBVRgHDYmbf8ZZa1K9oSschu56Fke2QwSul4 6wra3U0Lf0vplTfKTiFNTwRRLEG9feOMxHwdSx+lbazGG5Q2kwmugSOFtcxagVj2WO0z Xk2V62QS+r+W+uqUyqcefJTXUmQIfwSTtvqr+m7bA7mfpwRau0kX2eE1MlhxJl1HR2iQ iyfXSVuKmuh5aLKAtxBEKDnv1oR3TheDVcvmFxKTCTo3mo5oGOPqKXyjM65xBwGlM81W tSpQ== X-Gm-Message-State: AJcUukcAQtsqbaH6obINDjIqFB/K5OYhV8FYa2NRUKGXCXB+jkEBw99Y 1gNABqwFxYJrCMrNZ+9i8wzxdxHO X-Google-Smtp-Source: ALg8bN7LDsux7XrDJRVCJObFN6eGzs3lFj7WUOUB4YRwVvR8BP/Lm+ktB9uGlItCpcMD6bqP3svi1Q== X-Received: by 2002:a9d:7855:: with SMTP id c21mr30426082otm.363.1549127114513; Sat, 02 Feb 2019 09:05:14 -0800 (PST) Received: from [192.168.1.2] (ip68-228-73-187.oc.oc.cox.net. [68.228.73.187]) by smtp.googlemail.com with ESMTPSA id d5sm4237192oth.78.2019.02.02.09.05.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 02 Feb 2019 09:05:13 -0800 (PST) Subject: Re: [PATCH] net: dsa: slave: Don't propagate flag changes on down slave interfaces To: Rundong Ge , andrew@lunn.ch Cc: vivien.didelot@gmail.com, davem@davemloft.net, netdev@vger.kernel.org References: <20190202142935.3090-1-rdong.ge@gmail.com> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9qfUATKC9NgZjRvBztfqy4 a9BQwACgnzGuH1BVeT2J0Ra+ZYgkx7DaPR0= Message-ID: <7f8fadc6-1bb5-03b5-4f5e-a407e9116399@gmail.com> Date: Sat, 2 Feb 2019 09:05:11 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190202142935.3090-1-rdong.ge@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Le 2/2/19 à 6:29 AM, Rundong Ge a écrit : > The unbalance of master's promiscuity or allmulti will happen after ifdown > and ifup a slave interface which is in a bridge. > > When we ifdown a slave interface , both the 'dsa_slave_close' and > 'dsa_slave_change_rx_flags' will clear the master's flags. The flags > of master will be decrease twice. > In the other hand, if we ifup the slave interface again, since the > slave's flags were cleared the 'dsa_slave_open' won't set the master's > flag, only 'dsa_slave_change_rx_flags' that triggered by 'br_add_if' > will set the master's flags. The flags of master is increase once. > > Only propagating flag changes when a slave interface is up makes > sure this does not happen. The 'vlan_dev_change_rx_flags' had the > same problem and was fixed, and changes here follows that fix. VLAN code under net/8021q/vlan_dev.c::vlan_dev_change_rx_flags() appears to do the same thing that you are proposing, so this looks fine to me. Since that is a bugfix, we should probably add: Fixes: 91da11f870f0 ("net: Distributed Switch Architecture protocol support") ? > > Signed-off-by: Rundong Ge > --- > net/dsa/slave.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/net/dsa/slave.c b/net/dsa/slave.c > index a3fcc1d..b5e4482 100644 > --- a/net/dsa/slave.c > +++ b/net/dsa/slave.c > @@ -140,11 +140,14 @@ static int dsa_slave_close(struct net_device *dev) > static void dsa_slave_change_rx_flags(struct net_device *dev, int change) > { > struct net_device *master = dsa_slave_to_master(dev); > - > - if (change & IFF_ALLMULTI) > - dev_set_allmulti(master, dev->flags & IFF_ALLMULTI ? 1 : -1); > - if (change & IFF_PROMISC) > - dev_set_promiscuity(master, dev->flags & IFF_PROMISC ? 1 : -1); > + if (dev->flags & IFF_UP) { > + if (change & IFF_ALLMULTI) > + dev_set_allmulti(master, > + dev->flags & IFF_ALLMULTI ? 1 : -1); > + if (change & IFF_PROMISC) > + dev_set_promiscuity(master, > + dev->flags & IFF_PROMISC ? 1 : -1); > + } > } > > static void dsa_slave_set_rx_mode(struct net_device *dev) > -- Florian