From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B502C43331 for ; Fri, 3 Apr 2020 21:02:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6AC5D206F5 for ; Fri, 3 Apr 2020 21:02:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pKW79Jxz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728023AbgDCVC6 (ORCPT ); Fri, 3 Apr 2020 17:02:58 -0400 Received: from mail-wm1-f45.google.com ([209.85.128.45]:52196 "EHLO mail-wm1-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726368AbgDCVC6 (ORCPT ); Fri, 3 Apr 2020 17:02:58 -0400 Received: by mail-wm1-f45.google.com with SMTP id z7so8516591wmk.1 for ; Fri, 03 Apr 2020 14:02:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=nEXVJYWITTJ5p6Nwz5MLlphsW4M43kjWWJy0LTCYHvA=; b=pKW79JxzprWcHP2lSVLzIDuBMsDFkcr0cwsNV9FKHJBZSwugOAOETtOWks72Ob4gOh EVp0Lk9k+Fu4iZbmQv1XQFAL1nQdUxx5KapUtKWwOEGd0UHv88nlg2tCDN4mdsFT89T2 1c4o8D73M1z2xJbRgYDXVUxl6p31WtZKxhFmUJu716DQgbMIKsG3zy/Ld9oU+m0GUu3Y Qe7P4Sf3bKbL2HxTin7G0sHaq5XKVcEwxFXyQMAIEE018F6OvHA+hqav/+oaLxL3MANT SE7ZvAfOiABBMdbucnGtqk3c59avdfOo2DoKErtUL8akH83s5NNgi0LiT0jowzz7Gc5j MyBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nEXVJYWITTJ5p6Nwz5MLlphsW4M43kjWWJy0LTCYHvA=; b=Z5ZXmvH5lydLAVWS3Igrk7WuPA4Vobo4nKPC7td6Gcb5auZzpuE0gdzkvPM5Vv90Tf RLrBYecaja/xtTdy8Vyl1TLThekbGF7AGTkctgxHDGSyhStKmExnAKg4pnqtaB/W6fu2 BMAc6+d68FE6L2EfXY1jIEasJHRx6ij1Hw7ipfU2cLecry2qlICs8urhQxKP/hrQ14ja jyNcE//su6Q0S1JIjiC7RUkyJiU5CfcKEdQkYhQAuWP9fEpdLdAGp3ZW7JjfqbNGk+7M LCHL+Fv3mhadX7mnFtZLK5edWe0FU2ne97yNUObvzoUXFrJrDXLeuYnc+Tp8F1aWgVq/ jy0g== X-Gm-Message-State: AGi0PuarMBw8eeAkv0CTeFJh43KugVJYwGKIkzfqL6ylA5XHzxRRsYsn DGXxT5xDyQNPWIlwjsGCu/0= X-Google-Smtp-Source: APiQypLJjitYlDMxR+3BnOWsql3C0Jqa+8wHwX3SAKDTGAHuEq1Tm3laqg+FIAbUxBOdqNPXkDi9CQ== X-Received: by 2002:a1c:4d7:: with SMTP id 206mr10340157wme.5.1585947776157; Fri, 03 Apr 2020 14:02:56 -0700 (PDT) Received: from ?IPv6:2003:ea:8f29:6000:5844:50ff:2f28:ec08? (p200300EA8F296000584450FF2F28EC08.dip0.t-ipconnect.de. [2003:ea:8f29:6000:5844:50ff:2f28:ec08]) by smtp.googlemail.com with ESMTPSA id a13sm13313421wrh.80.2020.04.03.14.02.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Apr 2020 14:02:55 -0700 (PDT) Subject: Re: question about drivers/net/dsa/sja1105/sja1105_main.c To: Vladimir Oltean , Julia Lawall Cc: netdev , Joe Perches , Russell King - ARM Linux admin , Andrew Lunn , Florian Fainelli References: From: Heiner Kallweit Message-ID: <7fc8f8d5-285a-9ec0-23c5-c867347c4feb@gmail.com> Date: Fri, 3 Apr 2020 23:02:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 03.04.2020 16:36, Vladimir Oltean wrote: > Hi Julia, > > On Fri, 3 Apr 2020 at 16:46, Julia Lawall wrote: >> >> Hello, >> >> The function sja1105_static_config_reload in sja1105_main.c contains the >> code: >> >> if (!an_enabled) { >> int speed = SPEED_UNKNOWN; >> >> if (bmcr & BMCR_SPEED1000) >> speed = SPEED_1000; >> else if (bmcr & BMCR_SPEED100) >> speed = SPEED_100; >> else if (bmcr & BMCR_SPEED10) >> speed = SPEED_10; >> >> sja1105_sgmii_pcs_force_speed(priv, speed); >> } >> >> The last test bmcr & BMCR_SPEED10 does not look correct, because according >> to include/uapi/linux/mii.h, BMCR_SPEED10 is 0. What should be done >> instead? >> It's right that this is not correct. You can check genphy_read_status_fixed() for how it's done there. >> thanks, >> julia > > Thanks for pointing out, you raise a good point. > Correct usage would be: > > include/uapi/linux/mii.h: > #define BMCR_SPEED_MASK 0x2040 > > drivers/net/dsa/sja1105/sja1105_main.c: > int speed = SPEED_UNKNOWN; > > if (bmcr & BMCR_SPEED_MASK == BMCR_SPEED1000) > speed = SPEED_1000; > else if (bmcr & BMCR_SPEED_MASK == BMCR_SPEED100) > speed = SPEED_100; > else if (bmcr & BMCR_SPEED_MASK == BMCR_SPEED10) > speed = SPEED_10; > > but the BMCR_SPEED_MASK doesn't exist, it looks like. I believe that > is because drivers (or the PHY library) don't typically need to read > the speed from the MII_BMCR register, they just need to write it. If > the PHY library maintainers think there is any value in defining > BMCR_SPEED_MASK as part of the UAPI, we can do that. Otherwise, the > definition can be restricted to drivers/net/dsa/sja1105/sja1105.h. > > Thanks, > -Vladimir >