From: Edward Cree <ecree.xilinx@gmail.com>
To: Antoine Tenart <atenart@kernel.org>, Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
netdev@vger.kernel.org
Subject: Re: [PATCH net] net: avoid race between device unregistration and set_channels
Date: Wed, 15 Jan 2025 11:04:58 +0000 [thread overview]
Message-ID: <7fe79d84-70ba-5bad-58ed-6bfa1a28e555@gmail.com> (raw)
In-Reply-To: <173693410183.5893.12485926901643155644@kwain>
On 15/01/2025 09:41, Antoine Tenart wrote:
> Quoting Edward Cree (2025-01-15 03:51:12)
>> Would __dev_ethtool() need a similar check?
>
> It doesn't because it calls __dev_get_by_name() and returns -ENODEV in
> case dismantle started.
>
So, to check I'm understanding correctly - this is because
ethnl_default_set_doit() calls ethnl_parse_header_dev_get()
before it takes rtnl, whereas ethtool takes rtnl before it
calls __dev_get_by_name()?
Subtle enough difference that the commit message should
probably explain it.
next prev parent reply other threads:[~2025-01-15 11:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 16:18 [PATCH net] net: avoid race between device unregistration and set_channels Antoine Tenart
2025-01-14 10:09 ` Edward Cree
2025-01-14 10:41 ` Antoine Tenart
2025-01-14 19:24 ` Jakub Kicinski
2025-01-15 2:51 ` Edward Cree
2025-01-15 9:41 ` Antoine Tenart
2025-01-15 11:04 ` Edward Cree [this message]
2025-01-15 11:12 ` Antoine Tenart
2025-01-15 9:39 ` Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fe79d84-70ba-5bad-58ed-6bfa1a28e555@gmail.com \
--to=ecree.xilinx@gmail.com \
--cc=atenart@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).