Re: [PATCH] Stochastic Fair Blue queue discipline

[Juliusz Chroboczek <Juliusz.Chroboczek@pps.jussieu.fr>]

>> > no net_random/srandom32 is per CPU and likely does the wrong thing for you.

>> Why is that?  I'm only using this to initialise a global data
>> structure, why should it matter that I use per-cpu state?

> Because they're independent and there is no guarantee you always 
> run on the same CPU and sampling them randomly will not necessarily
> give you a good random number sequence.

I'm sorry to be such a pain, but I still don't understand.

Random32 is initialised from get_random_bytes; so the per-cpu
pseudo-random sequences should be uncorrelated.  I fail to see how an
arbitrary interleaving of uncorrelated good pseudo-random sequences
can fail to be good.

Looking at line 448 of sch_sfq.c in Linus' current HEAD, I see that
somebody else thinks the same as I do.  So please let me know if sfq
needs fixed, or whether I can use net_random in sfb.

Thanks,

                                        Juliusz