netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Juliusz Chroboczek <Juliusz.Chroboczek@pps.jussieu.fr>
To: Patrick McHardy <kaber@trash.net>
Cc: Andi Kleen <andi@firstfloor.org>, netdev@vger.kernel.org
Subject: Re: [PATCH] Stochastic Fair Blue queue discipline
Date: Thu, 10 Apr 2008 13:17:53 +0200	[thread overview]
Message-ID: <7izls2uffi.fsf@lanthane.pps.jussieu.fr> (raw)
In-Reply-To: <47FD6F85.5080003@trash.net> (Patrick McHardy's message of "Thu\, 10 Apr 2008 03\:38\:13 +0200")

> - traffic schedulers shouldn't depend on perfect random,
> its more about statistical multiplexing.

Okay, I've been thinking about this, and I'm not quite sure that what
sfq and sfb want is a pseudo-random sequence in the first place.

Sfq and sfb only draw random numbers in order to change hashing
functions periodically, so as not to have an innocent flow stuck
within a hash bucket with a non-reactive flow.  For sfb it doesn't
matter much (collisions in a Bloom filter are so rare as to be almost
nonexistent), but for sfq, it is fairly important.

Now assuming jhash is any good, i.e. that a single bit change in the
input changes all output bits with roughly similar probability (and
I don't know whether it is), it shouldn't matter much what sequence of
u32 we use for the perturbation as long as it doesn't repeat values
too often.  Something as simple as a static counter might actually be
good enough.

So I'd argue that the wise thing is to make sure of is that jhash is
good (in the sense above), and not bother too much with the PRNG.

                                        Juliusz

  reply	other threads:[~2008-04-10 11:18 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-07 22:37 [PATCH] Stochastic Fair Blue queue discipline Juliusz Chroboczek
2008-04-08  0:04 ` Patrick McHardy
2008-04-08  0:56   ` Patrick McHardy
2008-04-08 15:28   ` Juliusz Chroboczek
2008-04-08  8:20 ` Andi Kleen
2008-04-08 12:11   ` Patrick McHardy
2008-04-08 15:39     ` Juliusz Chroboczek
2008-04-08 15:45       ` Patrick McHardy
2008-04-09 15:48         ` Juliusz Chroboczek
2008-04-09 16:00           ` Patrick McHardy
2008-04-08 15:38   ` Juliusz Chroboczek
2008-04-08 16:32     ` Andi Kleen
2008-04-08 17:35       ` Juliusz Chroboczek
2008-04-08 17:53         ` Andi Kleen
2008-04-09 15:45           ` Juliusz Chroboczek
2008-04-09 17:49             ` Andi Kleen
2008-04-10  1:23               ` Patrick McHardy
2008-04-10  1:38                 ` Patrick McHardy
2008-04-10 11:17                   ` Juliusz Chroboczek [this message]
2008-04-11 13:07                     ` Patrick McHardy
2008-04-10 14:04                   ` Stephen Hemminger
2008-04-10  7:36                 ` Andi Kleen
2008-04-08 16:44 ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7izls2uffi.fsf@lanthane.pps.jussieu.fr \
    --to=juliusz.chroboczek@pps.jussieu.fr \
    --cc=andi@firstfloor.org \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).