From: Junio C Hamano <gitster@pobox.com>
To: Krzysztof Halasa <khc@pm.waw.pl>
Cc: "Linus Torvalds" <torvalds@linux-foundation.org>,
"Harvey Harrison" <harvey.harrison@gmail.com>,
"Håkon Løvdal" <hlovdal@gmail.com>,
"Hannes Eder" <hannes@hanneseder.net>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/27] drivers/net: fix sparse warnings: make do-while a compound statement
Date: Wed, 24 Dec 2008 22:17:15 -0800 [thread overview]
Message-ID: <7vd4fgdbis.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <m3myemqqgp.fsf@maximus.localdomain> (Krzysztof Halasa's message of "Wed, 24 Dec 2008 03:03:50 +0100")
Krzysztof Halasa <khc@pm.waw.pl> writes:
> Linus Torvalds <torvalds@linux-foundation.org> writes:
> ...
>> Another example of "common vs non-common" is this:
>>
>> if (0 <= x)
>> do something..
>>
>> is something that crazy people do (sadly, one of the crazy people taught
>> the git maintainer C programming, so now even sane people do it). It's
>> crazy because it's uncommon, which means that most people have to think
>> about it A LOT MORE than about
>>
>> if (x >= 0)
>> do something..
>
> No. It's crazy not because it's uncommon, but because this is how we
> have been taught in school.
>
> I don't know reasons for "0 >= x" but I know one for
> if (0 == x)
> do something..
>
> It's because people sometimes write "=" instead of "==" and "0 = x"
> doesn't make sense to gcc.
It does not have anything to do with the assignment confusion.
It is "textual order should reflect actual order" (aka "have number line
in your head when you write your comparison conditional"):
http://thread.gmane.org/gmane.comp.version-control.git/3903/focus=4126
Even if it may make logical sense, I would not suggest using it when other
people are not familiar with the convention, though.
next prev parent reply other threads:[~2008-12-25 6:17 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-22 19:14 [PATCH 00/27] drivers/net: fix sparse warnings Hannes Eder
2008-12-22 19:14 ` [PATCH 01/27] drivers/net: fix sparse warning: use ANSI-style function declaration Hannes Eder
2008-12-26 7:53 ` David Miller
2008-12-22 19:15 ` [PATCH 02/27] drivers/net: fix sparse warnings: make do-while a compound statement Hannes Eder
2008-12-22 22:14 ` Krzysztof Halasa
2008-12-22 23:44 ` Håkon Løvdal
2008-12-23 16:31 ` Krzysztof Halasa
2008-12-23 17:26 ` Harvey Harrison
2008-12-23 17:36 ` Krzysztof Halasa
2008-12-23 18:08 ` Linus Torvalds
2008-12-23 23:18 ` Krzysztof Halasa
2008-12-23 23:38 ` Linus Torvalds
2008-12-24 2:03 ` Krzysztof Halasa
2008-12-24 2:10 ` Linus Torvalds
2008-12-25 17:02 ` Krzysztof Halasa
2008-12-25 6:17 ` Junio C Hamano [this message]
2008-12-29 14:35 ` Hannes Eder
2008-12-26 7:55 ` David Miller
2008-12-22 19:15 ` [PATCH 03/27] drivers/net: fix sparse warning: returning void-valued expression Hannes Eder
2008-12-26 0:17 ` David Miller
2008-12-26 14:39 ` Hannes Eder
2008-12-26 19:59 ` Randy Dunlap
2008-12-27 19:11 ` Hannes Eder
2008-12-27 19:20 ` Sam Ravnborg
2008-12-27 21:38 ` [PATCH] Makefile: disable sparse warning "returning void-valued expression" Hannes Eder
2008-12-27 21:57 ` Sam Ravnborg
2008-12-26 7:56 ` [PATCH 03/27] drivers/net: fix sparse warning: returning void-valued expression David Miller
2008-12-22 19:15 ` [PATCH 04/27] drivers/net: fix sparse warnings: make symbols static Hannes Eder
2008-12-26 7:57 ` David Miller
2008-12-22 19:15 ` [PATCH 05/27] drivers/net/arcnet: " Hannes Eder
2008-12-26 7:57 ` David Miller
2008-12-22 19:15 ` [PATCH 06/27] drivers/net/atlx: " Hannes Eder
2008-12-26 7:58 ` David Miller
2008-12-22 19:15 ` [PATCH 07/27] drivers/net/bonding: fix sparse warnings: move decls to header file Hannes Eder
2008-12-26 7:59 ` David Miller
2008-12-22 19:16 ` [PATCH 08/27] drivers/net/cxgb3: comment out dead code Hannes Eder
2008-12-26 7:59 ` David Miller
2008-12-22 19:16 ` [PATCH 09/27] drivers/net/e1000e: fix sparse warnings: make symbols static Hannes Eder
2008-12-22 19:16 ` [PATCH 10/27] drivers/net/enic: fix sparse warning: make symbol static Hannes Eder
2008-12-26 8:01 ` David Miller
2008-12-22 19:16 ` [PATCH 11/27] drivers/net/igb: remove dead code (function 'igb_read_pci_cfg') Hannes Eder
2008-12-22 22:30 ` Jeff Kirsher
2008-12-26 8:03 ` David Miller
2008-12-22 19:16 ` [PATCH 12/27] drivers/net/irda: fix sparse warnings: make symbols static Hannes Eder
2008-12-26 8:03 ` David Miller
2008-12-22 19:16 ` [PATCH 13/27] drivers/net/ixgbe: " Hannes Eder
2008-12-26 8:04 ` David Miller
2008-12-22 19:16 ` [PATCH 14/27] drivers/net/netxen: fix sparse warnings: use NULL pointer instead of plain integer Hannes Eder
2008-12-26 8:04 ` David Miller
2008-12-22 19:17 ` [PATCH 15/27] drivers/net/qlge: fix sparse warnings: make symbols static Hannes Eder
2008-12-26 8:05 ` David Miller
2008-12-22 19:17 ` [PATCH 16/27] drivers/net/skfp: " Hannes Eder
2008-12-26 8:06 ` David Miller
2008-12-22 19:17 ` [PATCH 17/27] drivers/net/tokenring: " Hannes Eder
2008-12-26 8:07 ` David Miller
2008-12-22 19:17 ` [PATCH 18/27] drivers/net/tulip: fix sparse warnings: make do-while a compound statement Hannes Eder
2008-12-26 8:07 ` David Miller
2008-12-22 19:17 ` [PATCH 19/27] drivers/net/usb: fix sparse warnings: make symbols static Hannes Eder
2008-12-26 8:08 ` David Miller
2008-12-22 19:17 ` [PATCH 20/27] drivers/net/wan: fix sparse warnings: make do-while a compound statement Hannes Eder
2008-12-22 22:09 ` Krzysztof Halasa
2008-12-22 19:18 ` [PATCH 21/27] drivers/net/wan: fix sparse warning: make symbol static Hannes Eder
2008-12-26 8:11 ` David Miller
2008-12-22 19:18 ` [PATCH 22/27] drivers/net/wan/z85230.c: fix sparse warnings: un-EXPORT symbols Hannes Eder
2008-12-26 8:12 ` David Miller
2008-12-22 19:18 ` [PATCH 23/27] drivers/net/wireless: fix sparse warnings: make symbols static Hannes Eder
2008-12-26 8:13 ` David Miller
2008-12-22 19:18 ` [PATCH 24/27] drivers/net/wireless/ath9k: " Hannes Eder
2008-12-22 19:18 ` [PATCH 25/27] drivers/net/wireless/b43: " Hannes Eder
2008-12-26 8:13 ` David Miller
2008-12-22 19:18 ` [PATCH 26/27] drivers/net/wireless/ipw2x00: " Hannes Eder
2008-12-26 8:14 ` David Miller
2008-12-22 19:19 ` [PATCH 27/27] drivers/net/wireless/prism54: " Hannes Eder
2008-12-26 8:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd4fgdbis.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=hannes@hanneseder.net \
--cc=harvey.harrison@gmail.com \
--cc=hlovdal@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).