From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA140C282C0 for ; Wed, 23 Jan 2019 15:09:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9610C21019 for ; Wed, 23 Jan 2019 15:09:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=cumulusnetworks.com header.i=@cumulusnetworks.com header.b="aiHSrMza" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726093AbfAWPJt (ORCPT ); Wed, 23 Jan 2019 10:09:49 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:38821 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725930AbfAWPJt (ORCPT ); Wed, 23 Jan 2019 10:09:49 -0500 Received: by mail-wm1-f68.google.com with SMTP id m22so2287529wml.3 for ; Wed, 23 Jan 2019 07:09:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cumulusnetworks.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=2fDq5lK0FToCTcc+aw7qvtP8vlMEhNwpNYYwlaHFUUQ=; b=aiHSrMzaVg3CE1w/A7Bx6H+fxFphKuQcYNiAABQJqjBZ2ewosVBH00xMumkhSgJt0M OjWNuaUMjZkzKQltJymud6ujZ0JUcTFwOyowhdI0ncUwJ52GWvodiQ2tMIbzfmHG8Y5l MmF9Q5rRXefiMoQw2Zchn7TWHvVUYPD3/7EgE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2fDq5lK0FToCTcc+aw7qvtP8vlMEhNwpNYYwlaHFUUQ=; b=Fp09xTWVlWE72bXafI/+EqYNbC9rjbf1vS3tnlZRdNa7AA/33T/l3UAv8IHHEJ8SX0 Bkfp6PbHJc/oHrlFPff6FWDSUU2kbIbml2TWuZ6ZowfKIs+d3KN0rVwwGrSIPH+ZRcaT eNFpKi6Jpee0Vu9lsbjSnU80dBJYaNunLxTzan/PVTbMaO4dZPKgllpy8x9TLMqU5tJb PdL6EeLpqlqaowyn4q+0ieCwDn58FlOhzMtH6T4l1AXke5WA+p49EceGJ0WQWlzN5FUo hFOv1ST4QuwtdqDi3fhsFEIGErNDh7Wym8sls+W+mPIqKzQmgGHH3GF7leJIzgq0RbEh uG3A== X-Gm-Message-State: AJcUukftNbEvnSLWYbFuqvR8A1C5hqdFLDbYci6OEc3z580qvZ0Jz7de OJn14E8jquPdPnDI5gnEIT4JaOpZgcxQ9w== X-Google-Smtp-Source: ALg8bN6f09PsOFMjLrIMfZ2pccMak+WoJNX5LYs0YVWNjeNxshfNueE9CyXzmNN7kqWdjuqIGWtJQw== X-Received: by 2002:a1c:87cc:: with SMTP id j195mr3067960wmd.2.1548256186552; Wed, 23 Jan 2019 07:09:46 -0800 (PST) Received: from [192.168.0.107] (79-100-158-105.ip.btc-net.bg. [79.100.158.105]) by smtp.gmail.com with ESMTPSA id h13sm79853667wrp.61.2019.01.23.07.09.44 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Wed, 23 Jan 2019 07:09:45 -0800 (PST) Subject: Re: [PATCH iproute2-next] Introduce ip-brctl shell script To: Stefano Brivio , David Ahern Cc: Phil Sutter , Eric Garver , Tomas Dolezal , Stephen Hemminger , Lennert Buytenhek , netdev@vger.kernel.org References: From: Nikolay Aleksandrov Message-ID: <800cb3d3-c749-3f36-83ea-0375e67fbd33@cumulusnetworks.com> Date: Wed, 23 Jan 2019 17:09:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 18/01/2019 19:00, Stefano Brivio wrote: > This script wraps 'ip' and 'bridge' tools to provide a drop-in replacement > of the standalone 'brctl' utility. > > It's bug-to-bug compatible with brctl as of bridge-utils version 1.6, > has no dependencies other than a POSIX shell, and it's less than half > the binary size of brctl on x86_64. > > As many users (including myself) seem to find brctl usage vastly more > intuitive than ip-link, possibly due to habit, this might be a lightweight > approach to provide brctl syntax without the need to maintain bridge-utils > any longer. > > Signed-off-by: Stefano Brivio > Acked-by: Phil Sutter > --- > man/man8/Makefile | 5 +- > man/man8/ip-brctl.8 | 187 +++++++++++++++ > misc/Makefile | 9 +- > misc/ip-brctl.in | 572 ++++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 770 insertions(+), 3 deletions(-) > create mode 100644 man/man8/ip-brctl.8 > create mode 100755 misc/ip-brctl.in Hi, IMO the effort should be towards improving iproute2 to be easier to use and more intuitive. We should be pushing people to use the new tools instead of trying to find workarounds to keep the old tools alive. I do like to idea of deprecating bridge-utils, but I think it should be done via improving ip/bridge enough to be pleasant to use. We will have to maintain this compatibility layer forever if it gets accepted and we'll never get rid of brctl this way. Thanks, Nik