From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19EF0C433B4 for ; Mon, 5 Apr 2021 10:06:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E0D9361396 for ; Mon, 5 Apr 2021 10:06:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241037AbhDEKHB (ORCPT ); Mon, 5 Apr 2021 06:07:01 -0400 Received: from dvalin.narfation.org ([213.160.73.56]:49582 "EHLO dvalin.narfation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232609AbhDEKHB (ORCPT ); Mon, 5 Apr 2021 06:07:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=narfation.org; s=20121; t=1617617213; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XbUClHyNVcrpyxtLGnmQfRsXLJPQQq7/WW7r7YRB4U8=; b=xmgycBd6jFwJGIyZ0fTL+ZYgns1dXgFWcxQ7KEF0KrviJ3DrpA4NxXEQDle4f87bzvBpih 9vbCZPPXtKrqz9mCRC1XBWxAJ94xDJd7GVxvcauQKr58nhqjQDLmEoCAsYGIVBl6EMmrSJ M05QBAa5u1f0ISJMVIAA0cfQB9RuUn0= From: Sven Eckelmann To: Marek Lindner , Simon Wunderlich , Antonio Quartulli , "David S. Miller" , Jakub Kicinski , Tetsuo Handa Cc: netdev@vger.kernel.org Subject: Re: [PATCH] batman-adv: initialize "struct batadv_tvlv_tt_vlan_data"->reserved field Date: Mon, 05 Apr 2021 12:06:40 +0200 Message-ID: <8010915.lm9TqgPHxW@sven-l14> In-Reply-To: References: <20210405053306.3437-1-penguin-kernel@I-love.SAKURA.ne.jp> <6915766.LLSpSeZOKX@sven-l14> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3037839.BsjkTRi589"; micalg="pgp-sha512"; protocol="application/pgp-signature" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org --nextPart3037839.BsjkTRi589 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii"; protected-headers="v1" From: Sven Eckelmann To: Marek Lindner , Simon Wunderlich , Antonio Quartulli , "David S. Miller" , Jakub Kicinski , Tetsuo Handa Cc: netdev@vger.kernel.org Subject: Re: [PATCH] batman-adv: initialize "struct batadv_tvlv_tt_vlan_data"->reserved field Date: Mon, 05 Apr 2021 12:06:40 +0200 Message-ID: <8010915.lm9TqgPHxW@sven-l14> In-Reply-To: References: <20210405053306.3437-1-penguin-kernel@I-love.SAKURA.ne.jp> <6915766.LLSpSeZOKX@sven-l14> On Monday, 5 April 2021 12:02:02 CEST Tetsuo Handa wrote: [...] > > Thanks but this patch is incomplete. Please also fix > > batadv_tt_prepare_tvlv_global_data (exactly the same way) > > Indeed. Hmm, batadv_send_tt_request() is already using kzalloc(). > Which approach ( "->reserved = 0" or "kzalloc()") do you prefer for > batadv_tt_prepare_tvlv_global_data() and batadv_tt_prepare_tvlv_local_data() ? Lets stick with the approach you've used in your v1 version - "->reserved = 0" Kind regards, Sven --nextPart3037839.BsjkTRi589 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEF10rh2Elc9zjMuACXYcKB8Eme0YFAmBq4TAACgkQXYcKB8Em e0YECw//YNoDX1Tn+ziyePJtIE2EapUiR/gDV3yPPeNI4/zlp8MHcdVowEEvM+gK cZsj/KscJ7Wm2ysf3xfzOvZFnKC5FGRZhgdTBtVSPaPY3SE90W3UHG12mkDXx+86 mDIYmNhHZQr6XNpQ7bFkri2e8kHGWDCWOU1a0homGSaGHXu0pbEL3IWfkpvm7Q84 PPa5wqSvpX6b3CREo6g7B3h2TlryEFHuKgV/g0Q5AVPlk1hw+DPb+Ay1maX/ZXu3 sb6f+hau2Q6q5m9rSRud/2zeFY0OgVed+s0CjZ2RMpXNgPi0J1e/x1vN+73VobTW jY814qkLWGAEcP8CbHsHhW4PwDL2sTnRVuPElV130I9/oddSey6fBUCs6LjVr5Sf rs0Im1Lkd2wbQYa7Z89Xi8CuzLy/6UoHlRdEEF1TxfFDAM3rpdsG004BI+iH9qG1 a2Sn/YO0QghqgDximniltSOA8XP85b9+5NQdqOvj7zThlIssnjjhalg2FHWdzfim 6sVShcIUTy1RI9Y/x2VMQ2iqIi53UvAJlHf6swQI9jt5dgUEDzcYFtWrA8IlOFau YTtDWq5xDRJ4ayAZNo4m9SqokPhG1M8rssRVH3xbc1M1bRjyEts1CXwEB6l/NVTa zwXaxRHt95tfaVkmLFw6YZI5G+Aqkrpt/kS+daAzl+cAwGjAd1Q= =ZL1p -----END PGP SIGNATURE----- --nextPart3037839.BsjkTRi589--