From: liuyonglong <liuyonglong@huawei.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: David Miller <davem@davemloft.net>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linuxarm@huawei.com>,
<salil.mehta@huawei.com>, <yisen.zhuang@huawei.com>,
<shiju.jose@huawei.com>
Subject: Re: [PATCH net] net: hns: fix LED configuration for marvell phy
Date: Thu, 25 Jul 2019 14:56:59 +0800 [thread overview]
Message-ID: <8017d9ff-2991-f94f-e611-4d1bac12e93b@huawei.com> (raw)
In-Reply-To: <20190725042829.GB14276@lunn.ch>
On 2019/7/25 12:28, Andrew Lunn wrote:
> On Thu, Jul 25, 2019 at 11:00:08AM +0800, liuyonglong wrote:
>>> Revert "net: hns: fix LED configuration for marvell phy"
>>> This reverts commit f4e5f775db5a4631300dccd0de5eafb50a77c131.
>>>
>>> Andrew Lunn says this should be handled another way.
>>>
>>> Signed-off-by: David S. Miller <davem@davemloft.net>
>>
>>
>> Hi Andrew:
>>
>> I see this patch have been reverted, can you tell me the better way to do this?
>> Thanks very much!
>
> Please take a look at the work Matthias Kaehlcke is doing. It has not
> got too far yet, but when it is complete, it should define a generic
> way to configure PHY LEDs.
>
> Andrew
>
Hi Andrew
https://lore.kernel.org/patchwork/patch/1097185/
You are discussing about the DT configuration, is Matthias Kaehlcke's work
also provide a generic way to configure PHY LEDS using ACPI?
next prev parent reply other threads:[~2019-07-25 6:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 5:59 [PATCH net] net: hns: fix LED configuration for marvell phy Yonglong Liu
2019-07-23 1:19 ` David Miller
2019-07-25 3:00 ` liuyonglong
2019-07-25 4:28 ` Andrew Lunn
2019-07-25 6:56 ` liuyonglong [this message]
2019-07-25 13:08 ` Andrew Lunn
2019-07-25 13:37 ` liuyonglong
2019-07-28 13:24 ` Pavel Machek
2019-07-28 22:14 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8017d9ff-2991-f94f-e611-4d1bac12e93b@huawei.com \
--to=liuyonglong@huawei.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=shiju.jose@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox