From mboxrd@z Thu Jan  1 00:00:00 1970
From: Denys Fedoryshchenko <nuclearcat@nuclearcat.com>
Subject: Re: ppp/pppoe, still panic 4.15.3 in ppp_push
Date: Wed, 14 Feb 2018 18:49:19 +0200
Message-ID: <802ba894fee75e34576d39aed5022dc8@nuclearcat.com>
References: <529b334cd9394782fcd26d96732765a1@nuclearcat.com>
 <20180214160739.GF1422@alphalink.fr>
 <3ffb97617fd5dcb436848b5522850b7f@nuclearcat.com>
 <20180214164728.GG1422@alphalink.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>
To: Guillaume Nault <g.nault@alphalink.fr>
Return-path: <netdev-owner@vger.kernel.org>
Received: from nuclearcat.com ([144.76.183.226]:35890 "EHLO nuclearcat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1032900AbeBNQtW (ORCPT <rfc822;netdev@vger.kernel.org>);
        Wed, 14 Feb 2018 11:49:22 -0500
In-Reply-To: <20180214164728.GG1422@alphalink.fr>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 2018-02-14 18:47, Guillaume Nault wrote:
> On Wed, Feb 14, 2018 at 06:29:34PM +0200, Denys Fedoryshchenko wrote:
>> On 2018-02-14 18:07, Guillaume Nault wrote:
>> > On Wed, Feb 14, 2018 at 03:17:23PM +0200, Denys Fedoryshchenko wrote:
>> > > Hi,
>> > >
>> > > Upgraded kernel to 4.15.3, still it crashes after while (several
>> > > hours,
>> > > cannot do bisect, as it is production server).
>> > >
>> > > dev ppp # gdb ppp_generic.o
>> > > GNU gdb (Gentoo 7.12.1 vanilla) 7.12.1
>> > > <<skipped>>
>> > > Reading symbols from ppp_generic.o...done.
>> > > (gdb) list *ppp_push+0x73
>> > > 0x681 is in ppp_push (drivers/net/ppp/ppp_generic.c:1663).
>> > > 1658			list = list->next;
>> > > 1659			pch = list_entry(list, struct channel, clist);
>> > > 1660
>> > > 1661			spin_lock(&pch->downl);
>> > > 1662			if (pch->chan) {
>> > > 1663				if (pch->chan->ops->start_xmit(pch->chan, skb))
>> > > 1664					ppp->xmit_pending = NULL;
>> > > 1665			} else {
>> > > 1666				/* channel got unregistered */
>> > > 1667				kfree_skb(skb);
>> > >
>> > >
>> > I expect a memory corruption. Do you have the possibility to run with
>> > KASAN by any chance?
>> I will try to enable it tonight. For now i reverted "drivers, net, 
>> ppp:
>> convert ppp_file.refcnt from atomic_t to refcount_t" for test.
>> 
> This commit looks good to me. Do you have doubts about it because it's
> new in 4.15? Does it mean that your last known-good kernel is 4.14?

I am just doing "manual" bisect, checking all possibilities, and picking 
patch to revert randomly.
Yes, correct, my known-good is 4.14.2.