Re: [PATCH net-next v2 02/15] tools: ynl: create local attribute helpers

[Nicolas Dichtel <nicolas.dichtel@6wind.com>]

Le 26/02/2024 à 22:20, Jakub Kicinski a écrit :
> Don't use mnl attr helpers, we're trying to remove the libmnl
> dependency. Create both signed and unsigned helpers, libmnl
> had unsigned helpers, so code generator no longer needs
> the mnl_type() hack.
> 
> The new helpers are written from first principles, but are
> hopefully not too buggy.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> --
> v2:
>  - NLA_ALIGN(sizeof(struct nlattr)) -> NLA_HDRLEN;
>  - ...put_strz() -> ...put_str()
>  - use ynl_attr_data() in ynl_attr_get_{str,s8,u8}()
[snip]
> +static inline __s8 ynl_attr_get_s8(const struct nlattr *attr)
> +{
> +	return *(__s8 *)ynl_attr_data(attr);
> +}
> +
> +static inline __s16 ynl_attr_get_s16(const struct nlattr *attr)
> +{
> +	__s16 tmp;
> +
> +	memcpy(&tmp, (unsigned char *)(attr + 1), sizeof(tmp));
The same would work here, am I wrong?
return *(__s16 *)ynl_attr_data(attr);

Same for all kind of int.