From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D86FC636CB for ; Fri, 16 Jul 2021 20:13:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 44690613FB for ; Fri, 16 Jul 2021 20:13:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233490AbhGPUQG (ORCPT ); Fri, 16 Jul 2021 16:16:06 -0400 Received: from www62.your-server.de ([213.133.104.62]:39720 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229896AbhGPUQF (ORCPT ); Fri, 16 Jul 2021 16:16:05 -0400 Received: from sslproxy01.your-server.de ([78.46.139.224]) by www62.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92.3) (envelope-from ) id 1m4UCf-0006dK-96; Fri, 16 Jul 2021 22:12:57 +0200 Received: from [85.5.47.65] (helo=linux.home) by sslproxy01.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m4UCe-000QgN-RO; Fri, 16 Jul 2021 22:12:56 +0200 Subject: Re: [PATCH v2 bpf-nxt] Documentation/bpf: Add heading and example for extensions in filter.rst To: Alexei Starovoitov , John Fastabend Cc: "Roy, UjjaL" , Song Liu , Alexei Starovoitov , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , "David S . Miller" , Jakub Kicinski , Jonathan Corbet , Paul Walmsley , Palmer Dabbelt , Albert Ou , Nathan Chancellor , Nick Desaulniers , Networking , BPF , Linux Doc Mailing List , open list , linux-riscv , Clang-Built-Linux ML References: <20210712173723.1597-1-royujjal@gmail.com> <60ee2dc76ac1c_196e22088d@john-XPS-13-9370.notmuch> From: Daniel Borkmann Message-ID: <80579c8d-ecdb-4334-9912-c04f75f7a6d3@iogearbox.net> Date: Fri, 16 Jul 2021 22:12:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.103.2/26234/Fri Jul 16 10:18:39 2021) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 7/16/21 3:48 AM, Alexei Starovoitov wrote: > On Tue, Jul 13, 2021 at 5:20 PM John Fastabend wrote: >> >> Roy, UjjaL wrote: >>> [1] https://www.kernel.org/doc/html/latest/bpf/ >>> >>> Add new heading for extensions to make it more readable. Also, add one >>> more example of filtering interface index for better understanding. >>> >>> Signed-off-by: Roy, UjjaL >>> Acked-by: Song Liu >> >> Looks OK to me. I thought the original was readable without the header, but >> if it helps someone seems easy enough to do. >> >> Acked-by: John Fastabend > > I cannot figure out how to apply this patch, because I see: > Applying: Documentation/bpf: Add heading and example for extensions in > filter.rst > fatal: empty ident name (for <>) not allowed > > Any idea? Same happened on my side. Maybe not sent via git-send-email(1)? Anyway, I've applied manually meanwhile.