From: David Ahern <dsahern@gmail.com>
To: Antony Antony <antony@phenome.org>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: Eyal Birger <eyal.birger@gmail.com>, netdev@vger.kernel.org
Subject: Re: [PATCH iproute2-next] ip xfrm: support setting/printing XFRMA_IF_ID attribute in states/policies
Date: Wed, 10 Apr 2019 11:50:32 -0700 [thread overview]
Message-ID: <805ebffd-96e5-6060-dc34-d959b624e066@gmail.com> (raw)
In-Reply-To: <20190406035732.7giilcz25yxgke5e@AntonyAntony.local>
On 4/5/19 8:57 PM, Antony Antony wrote:
> On Fri, Apr 05, 2019 at 03:07:58PM -0700, Stephen Hemminger wrote:
>> On Thu, 4 Apr 2019 19:07:38 +0300
>> Eyal Birger <eyal.birger@gmail.com> wrote:
>>
>>> The XFRMA_IF_ID attribute is set in policies/states for them to be
>>> associated with an XFRM interface (4.19+).
>>>
>>> Add support for setting / displaying this attribute.
>>>
>>> Note that 0 is a valid value therefore set XFRMA_IF_ID if any value
>>> was provided in command line.
>>>
>>> Tested-by: Antony Antony <antony@phenome.org>
>>> Signed-off-by: Eyal Birger <eyal.birger@gmail.com>
>>
>> This is already handled by an earlier patch, that I just applied
>
> Do you mean commit 286446c1
> https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=286446c1e8c7f5f6eca4959015aa9e482b7adb11
>
> Matt's patch is to support link.
> e.g ip link add ipsec0 type xfrm dev enp0s5 if_id 0xAB
>
> Eyal's patch for xfrm state and policy.
> e.g
> ip xfrm policy add src 10.1.1.200/32 dst 10.1.1.100/32 dir in tmpl src
> 172.16.1.200 dst 172.16.1.100 proto esp reqid 2 mode tunnel if_id 10
>
> Thanks for applying Matt's patch. We need for both patches.
>
> -antony
>
Stephen: since you took Matt's, I am assuming you will take the xfrm
patch too.
prev parent reply other threads:[~2019-04-10 18:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 16:07 [PATCH iproute2-next] ip xfrm: support setting/printing XFRMA_IF_ID attribute in states/policies Eyal Birger
2019-04-04 17:13 ` Stephen Hemminger
2019-04-05 6:59 ` Eyal Birger
2019-04-05 22:07 ` Stephen Hemminger
2019-04-06 3:57 ` Antony Antony
2019-04-10 18:50 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=805ebffd-96e5-6060-dc34-d959b624e066@gmail.com \
--to=dsahern@gmail.com \
--cc=antony@phenome.org \
--cc=eyal.birger@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).