From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08999C10F11 for ; Wed, 10 Apr 2019 18:50:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CCAAA2070D for ; Wed, 10 Apr 2019 18:50:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="o49edWD2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731930AbfDJSug (ORCPT ); Wed, 10 Apr 2019 14:50:36 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:33292 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727905AbfDJSuf (ORCPT ); Wed, 10 Apr 2019 14:50:35 -0400 Received: by mail-pg1-f195.google.com with SMTP id k19so2101973pgh.0 for ; Wed, 10 Apr 2019 11:50:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Ud/YqCpJpx13QdDRvye5gNE3EdTSYq+lTGUL2Mrxad0=; b=o49edWD2UKdCzKprJhNQ7Ik221vQzjRe1IrNXsd+PmVvKQp0Ky2aK2063P5MtMAs3k OSWsL/WZ0X6i5Isis2F/uGImD15Wj/aVqgxrWJP2LsFakg2hVap9MFnz8HJeQTI+KrU2 sDVFgHKIVbn01kSDKq/chM8VeUYCwO1M+OrKxQrOXc7hvX2WOhzpqgdaAh279VJfp6So 3twCcR2NPsOgkt5ZVAfcRTDpKlc5xd2XXhKIeHuP8roYSxkuKuNaTVDjgBx+bEB2LlOg /P9QYzVb59tZsxOPdsOHvwVTkmfkgt1CLlGSxz9CjDYr+4wsCPKlogaFhrSDrREEkH9X I/JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Ud/YqCpJpx13QdDRvye5gNE3EdTSYq+lTGUL2Mrxad0=; b=qqejgyW7Pg/zW7CqdIKvm2qc42UM93IGzhxN8mahXs1JcwpH/nELv742qrCWX7PoRG /Hz7gjMwbTIavmhjGP4JARG4rUcH1pV60H+UZwaApFbSifuGqOw9psL0TQzUM4tsjv/E FzPNArxVU62p5ii1u8os5Aw3h2GtlxQLdWUNoVJKqM34XgsnWuZE3guFIF3L45S51IX5 qRq80JsOdOuxodgO9ni2yb+jTr21Q1HlsRikkvW+/v/aE6yg56MqrCmNWCTLZQ9/u5O+ DB08gE9jieG4tQ4e7LhQg76Pp1S53WfEPu1QWRe90T/UsJG7ZXoY+hAHFQGgBxE4q/Je o85A== X-Gm-Message-State: APjAAAWF6+pBKK4Rp+53IsfAXHAaBmombsacUBp+hor7cnLREV9YknVC H2pvKiGBkuc28ZWzFeuMtgkNtrxp X-Google-Smtp-Source: APXvYqweH9loKZLPLjxT6q5v8TYRAhTKgJXT4zOubuvfIfYtWX+r+Cit4fS+t7RLNb8JH8rthj59pA== X-Received: by 2002:a65:5682:: with SMTP id v2mr43300538pgs.100.1554922234704; Wed, 10 Apr 2019 11:50:34 -0700 (PDT) Received: from [10.40.10.244] (fw.cumulusnetworks.com. [216.129.126.126]) by smtp.googlemail.com with ESMTPSA id f7sm64728367pga.56.2019.04.10.11.50.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Apr 2019 11:50:33 -0700 (PDT) Subject: Re: [PATCH iproute2-next] ip xfrm: support setting/printing XFRMA_IF_ID attribute in states/policies To: Antony Antony , Stephen Hemminger Cc: Eyal Birger , netdev@vger.kernel.org References: <20190404160738.18687-1-eyal.birger@gmail.com> <20190405150758.6c442d60@shemminger-XPS-13-9360> <20190406035732.7giilcz25yxgke5e@AntonyAntony.local> From: David Ahern Message-ID: <805ebffd-96e5-6060-dc34-d959b624e066@gmail.com> Date: Wed, 10 Apr 2019 11:50:32 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190406035732.7giilcz25yxgke5e@AntonyAntony.local> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 4/5/19 8:57 PM, Antony Antony wrote: > On Fri, Apr 05, 2019 at 03:07:58PM -0700, Stephen Hemminger wrote: >> On Thu, 4 Apr 2019 19:07:38 +0300 >> Eyal Birger wrote: >> >>> The XFRMA_IF_ID attribute is set in policies/states for them to be >>> associated with an XFRM interface (4.19+). >>> >>> Add support for setting / displaying this attribute. >>> >>> Note that 0 is a valid value therefore set XFRMA_IF_ID if any value >>> was provided in command line. >>> >>> Tested-by: Antony Antony >>> Signed-off-by: Eyal Birger >> >> This is already handled by an earlier patch, that I just applied > > Do you mean commit 286446c1 > https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=286446c1e8c7f5f6eca4959015aa9e482b7adb11 > > Matt's patch is to support link. > e.g ip link add ipsec0 type xfrm dev enp0s5 if_id 0xAB > > Eyal's patch for xfrm state and policy. > e.g > ip xfrm policy add src 10.1.1.200/32 dst 10.1.1.100/32 dir in tmpl src > 172.16.1.200 dst 172.16.1.100 proto esp reqid 2 mode tunnel if_id 10 > > Thanks for applying Matt's patch. We need for both patches. > > -antony > Stephen: since you took Matt's, I am assuming you will take the xfrm patch too.