From: Florian Fainelli <f.fainelli@gmail.com>
To: Doug Berger <opendmb@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: bcmgenet: ensure EXT_ENERGY_DET_MASK is clear
Date: Mon, 28 Jun 2021 20:47:04 -0700 [thread overview]
Message-ID: <8076667b-59e7-5289-362d-5cc55bfb56f5@gmail.com> (raw)
In-Reply-To: <79839c8f-4c4d-a70d-178c-1d7674e2b429@gmail.com>
On 6/25/2021 3:03 PM, Florian Fainelli wrote:
> On 6/25/21 2:57 PM, Doug Berger wrote:
>> Setting the EXT_ENERGY_DET_MASK bit allows the port energy detection
>> logic of the internal PHY to prevent the system from sleeping. Some
>> internal PHYs will report that energy is detected when the network
>> interface is closed which can prevent the system from going to sleep
>> if WoL is enabled when the interface is brought down.
>>
>> Since the driver does not support waking the system on this logic,
>> this commit clears the bit whenever the internal PHY is powered up
>> and the other logic for manipulating the bit is removed since it
>> serves no useful function.
>>
>> Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file")
>> Signed-off-by: Doug Berger <opendmb@gmail.com>
>
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
>
Doug, it looks like this patch introduces an unused "reg" variable
warning at lines 3296 and 4137 which is why the patch was marked as
"Changes Requested":
https://patchwork.kernel.org/project/netdevbpf/patch/20210625215732.209588-1-opendmb@gmail.com/
https://patchwork.hopto.org/static/nipa//507371/12345957/build_32bit
--
Florian
prev parent reply other threads:[~2021-06-29 3:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 21:57 [PATCH net] net: bcmgenet: ensure EXT_ENERGY_DET_MASK is clear Doug Berger
2021-06-25 22:03 ` Florian Fainelli
2021-06-29 3:47 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8076667b-59e7-5289-362d-5cc55bfb56f5@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).