* Re: Linux 4.15-rc3 (uml + bpf_perf_event.h) [not found] <CA+55aFz9O9R8u3ori-QNPz4ALU+0B=Es0gd+oWmsce5qxugxXA@mail.gmail.com> @ 2017-12-11 2:42 ` Randy Dunlap 2017-12-11 8:32 ` Richard Weinberger 0 siblings, 1 reply; 8+ messages in thread From: Randy Dunlap @ 2017-12-11 2:42 UTC (permalink / raw) To: Linus Torvalds, Linux Kernel Mailing List Cc: richard -rw- weinberger, netdev@vger.kernel.org On 12/10/2017 06:08 PM, Linus Torvalds wrote: > Another week, another rc. > um (uml) won't build on i386 or x86_64: CC init/main.o In file included from ../include/linux/perf_event.h:18:0, from ../include/linux/trace_events.h:10, from ../include/trace/syscall.h:7, from ../include/linux/syscalls.h:82, from ../init/main.c:20: ../include/uapi/linux/bpf_perf_event.h:11:32: fatal error: asm/bpf_perf_event.h: No such file or directory #include <asm/bpf_perf_event.h> ^ compilation terminated. ../scripts/Makefile.build:310: recipe for target 'init/main.o' failed Should that be <asm-generic/bpf_perf_event.h> ? -- ~Randy ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Linux 4.15-rc3 (uml + bpf_perf_event.h) 2017-12-11 2:42 ` Linux 4.15-rc3 (uml + bpf_perf_event.h) Randy Dunlap @ 2017-12-11 8:32 ` Richard Weinberger 2017-12-11 10:19 ` Daniel Borkmann 0 siblings, 1 reply; 8+ messages in thread From: Richard Weinberger @ 2017-12-11 8:32 UTC (permalink / raw) To: Randy Dunlap, netdev@vger.kernel.org Cc: Linus Torvalds, Linux Kernel Mailing List Randy, Am Montag, 11. Dezember 2017, 03:42:12 CET schrieb Randy Dunlap: > On 12/10/2017 06:08 PM, Linus Torvalds wrote: > > Another week, another rc. > > um (uml) won't build on i386 or x86_64: > > CC init/main.o > In file included from ../include/linux/perf_event.h:18:0, > from ../include/linux/trace_events.h:10, > from ../include/trace/syscall.h:7, > from ../include/linux/syscalls.h:82, > from ../init/main.c:20: > ../include/uapi/linux/bpf_perf_event.h:11:32: fatal error: > asm/bpf_perf_event.h: No such file or directory #include > <asm/bpf_perf_event.h> > ^ > compilation terminated. > ../scripts/Makefile.build:310: recipe for target 'init/main.o' failed > How do you trigger that build failure? Can you share your .config? Thanks, //richard -- sigma star gmbh - Eduard-Bodem-Gasse 6 - 6020 Innsbruck - Austria ATU66964118 - FN 374287y ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Linux 4.15-rc3 (uml + bpf_perf_event.h) 2017-12-11 8:32 ` Richard Weinberger @ 2017-12-11 10:19 ` Daniel Borkmann 2017-12-11 17:27 ` Randy Dunlap 2017-12-11 18:49 ` Richard Weinberger 0 siblings, 2 replies; 8+ messages in thread From: Daniel Borkmann @ 2017-12-11 10:19 UTC (permalink / raw) To: Richard Weinberger, Randy Dunlap, netdev@vger.kernel.org Cc: Linus Torvalds, Linux Kernel Mailing List, alexei.starovoitov, brueckner Hi Randy, hi Richard, [ +Hendrik for c895f6f703ad7dd2f ] On 12/11/2017 09:32 AM, Richard Weinberger wrote: > Randy, > > Am Montag, 11. Dezember 2017, 03:42:12 CET schrieb Randy Dunlap: >> On 12/10/2017 06:08 PM, Linus Torvalds wrote: >>> Another week, another rc. >> >> um (uml) won't build on i386 or x86_64: >> >> CC init/main.o >> In file included from ../include/linux/perf_event.h:18:0, >> from ../include/linux/trace_events.h:10, >> from ../include/trace/syscall.h:7, >> from ../include/linux/syscalls.h:82, >> from ../init/main.c:20: >> ../include/uapi/linux/bpf_perf_event.h:11:32: fatal error: >> asm/bpf_perf_event.h: No such file or directory #include >> <asm/bpf_perf_event.h> >> ^ >> compilation terminated. >> ../scripts/Makefile.build:310: recipe for target 'init/main.o' failed > > How do you trigger that build failure? > Can you share your .config? Hmm, too bad kbuild bot doesn't catch issues on uml. I'm not too familiar with uml, but looks like it's the only special case where there's no arch/um/include/uapi/asm/. What is the usual convention to pull in such headers in this case? Something like the below, would that fix it for you? Thanks for your help, Daniel arch/um/include/asm/bpf_perf_event.h | 1 + include/asm-generic/bpf_perf_event.h | 1 + 2 files changed, 2 insertions(+) create mode 100644 arch/um/include/asm/bpf_perf_event.h create mode 100644 include/asm-generic/bpf_perf_event.h diff --git a/arch/um/include/asm/bpf_perf_event.h b/arch/um/include/asm/bpf_perf_event.h new file mode 100644 index 0000000..3097758 --- /dev/null +++ b/arch/um/include/asm/bpf_perf_event.h @@ -0,0 +1 @@ +#include <asm-generic/bpf_perf_event.h> diff --git a/include/asm-generic/bpf_perf_event.h b/include/asm-generic/bpf_perf_event.h new file mode 100644 index 0000000..67112e5 --- /dev/null +++ b/include/asm-generic/bpf_perf_event.h @@ -0,0 +1 @@ +#include <uapi/asm-generic/bpf_perf_event.h> -- 2.9.5 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: Linux 4.15-rc3 (uml + bpf_perf_event.h) 2017-12-11 10:19 ` Daniel Borkmann @ 2017-12-11 17:27 ` Randy Dunlap 2017-12-11 17:32 ` Daniel Borkmann 2017-12-11 18:19 ` Richard Weinberger 2017-12-11 18:49 ` Richard Weinberger 1 sibling, 2 replies; 8+ messages in thread From: Randy Dunlap @ 2017-12-11 17:27 UTC (permalink / raw) To: Daniel Borkmann, Richard Weinberger, netdev@vger.kernel.org Cc: Linus Torvalds, Linux Kernel Mailing List, alexei.starovoitov, brueckner On 12/11/2017 02:19 AM, Daniel Borkmann wrote: > Hi Randy, hi Richard, [ +Hendrik for c895f6f703ad7dd2f ] > > On 12/11/2017 09:32 AM, Richard Weinberger wrote: >> Randy, >> >> Am Montag, 11. Dezember 2017, 03:42:12 CET schrieb Randy Dunlap: >>> On 12/10/2017 06:08 PM, Linus Torvalds wrote: >>>> Another week, another rc. >>> >>> um (uml) won't build on i386 or x86_64: >>> >>> CC init/main.o >>> In file included from ../include/linux/perf_event.h:18:0, >>> from ../include/linux/trace_events.h:10, >>> from ../include/trace/syscall.h:7, >>> from ../include/linux/syscalls.h:82, >>> from ../init/main.c:20: >>> ../include/uapi/linux/bpf_perf_event.h:11:32: fatal error: >>> asm/bpf_perf_event.h: No such file or directory #include >>> <asm/bpf_perf_event.h> >>> ^ >>> compilation terminated. >>> ../scripts/Makefile.build:310: recipe for target 'init/main.o' failed >> >> How do you trigger that build failure? >> Can you share your .config? Richard, it's just defconfig on both i386 and x86_64. > Hmm, too bad kbuild bot doesn't catch issues on uml. I'm not too familiar > with uml, but looks like it's the only special case where there's no > arch/um/include/uapi/asm/. What is the usual convention to pull in such > headers in this case? Something like the below, would that fix it for you? > > Thanks for your help, > Daniel Yes, that patch works. Thanks. > arch/um/include/asm/bpf_perf_event.h | 1 + > include/asm-generic/bpf_perf_event.h | 1 + > 2 files changed, 2 insertions(+) > create mode 100644 arch/um/include/asm/bpf_perf_event.h > create mode 100644 include/asm-generic/bpf_perf_event.h > > diff --git a/arch/um/include/asm/bpf_perf_event.h b/arch/um/include/asm/bpf_perf_event.h > new file mode 100644 > index 0000000..3097758 > --- /dev/null > +++ b/arch/um/include/asm/bpf_perf_event.h > @@ -0,0 +1 @@ > +#include <asm-generic/bpf_perf_event.h> > diff --git a/include/asm-generic/bpf_perf_event.h b/include/asm-generic/bpf_perf_event.h > new file mode 100644 > index 0000000..67112e5 > --- /dev/null > +++ b/include/asm-generic/bpf_perf_event.h > @@ -0,0 +1 @@ > +#include <uapi/asm-generic/bpf_perf_event.h> > -- ~Randy ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Linux 4.15-rc3 (uml + bpf_perf_event.h) 2017-12-11 17:27 ` Randy Dunlap @ 2017-12-11 17:32 ` Daniel Borkmann 2017-12-11 18:19 ` Richard Weinberger 1 sibling, 0 replies; 8+ messages in thread From: Daniel Borkmann @ 2017-12-11 17:32 UTC (permalink / raw) To: Randy Dunlap, Richard Weinberger, netdev@vger.kernel.org Cc: Linus Torvalds, Linux Kernel Mailing List, alexei.starovoitov, brueckner On 12/11/2017 06:27 PM, Randy Dunlap wrote: > On 12/11/2017 02:19 AM, Daniel Borkmann wrote: >> Hi Randy, hi Richard, [ +Hendrik for c895f6f703ad7dd2f ] >> >> On 12/11/2017 09:32 AM, Richard Weinberger wrote: >>> Randy, >>> >>> Am Montag, 11. Dezember 2017, 03:42:12 CET schrieb Randy Dunlap: >>>> On 12/10/2017 06:08 PM, Linus Torvalds wrote: >>>>> Another week, another rc. >>>> >>>> um (uml) won't build on i386 or x86_64: >>>> >>>> CC init/main.o >>>> In file included from ../include/linux/perf_event.h:18:0, >>>> from ../include/linux/trace_events.h:10, >>>> from ../include/trace/syscall.h:7, >>>> from ../include/linux/syscalls.h:82, >>>> from ../init/main.c:20: >>>> ../include/uapi/linux/bpf_perf_event.h:11:32: fatal error: >>>> asm/bpf_perf_event.h: No such file or directory #include >>>> <asm/bpf_perf_event.h> >>>> ^ >>>> compilation terminated. >>>> ../scripts/Makefile.build:310: recipe for target 'init/main.o' failed >>> >>> How do you trigger that build failure? >>> Can you share your .config? > > Richard, it's just defconfig on both i386 and x86_64. > >> Hmm, too bad kbuild bot doesn't catch issues on uml. I'm not too familiar >> with uml, but looks like it's the only special case where there's no >> arch/um/include/uapi/asm/. What is the usual convention to pull in such >> headers in this case? Something like the below, would that fix it for you? >> >> Thanks for your help, >> Daniel > > Yes, that patch works. Thanks. Thanks, I'd get it out later today, and route it via bpf tree. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Linux 4.15-rc3 (uml + bpf_perf_event.h) 2017-12-11 17:27 ` Randy Dunlap 2017-12-11 17:32 ` Daniel Borkmann @ 2017-12-11 18:19 ` Richard Weinberger 1 sibling, 0 replies; 8+ messages in thread From: Richard Weinberger @ 2017-12-11 18:19 UTC (permalink / raw) To: Randy Dunlap Cc: Daniel Borkmann, netdev@vger.kernel.org, Linus Torvalds, Linux Kernel Mailing List, alexei.starovoitov, brueckner Am Montag, 11. Dezember 2017, 18:27:40 CET schrieb Randy Dunlap: > On 12/11/2017 02:19 AM, Daniel Borkmann wrote: > > Hi Randy, hi Richard, [ +Hendrik for c895f6f703ad7dd2f ] > > > > On 12/11/2017 09:32 AM, Richard Weinberger wrote: > >> Randy, > >> > >> Am Montag, 11. Dezember 2017, 03:42:12 CET schrieb Randy Dunlap: > >>> On 12/10/2017 06:08 PM, Linus Torvalds wrote: > >>>> Another week, another rc. > >>> > >>> um (uml) won't build on i386 or x86_64: > >>> CC init/main.o > >>> > >>> In file included from ../include/linux/perf_event.h:18:0, > >>> > >>> from ../include/linux/trace_events.h:10, > >>> from ../include/trace/syscall.h:7, > >>> from ../include/linux/syscalls.h:82, > >>> > >>> from ../init/main.c:20: > >>> ../include/uapi/linux/bpf_perf_event.h:11:32: fatal error: > >>> asm/bpf_perf_event.h: No such file or directory #include > >>> <asm/bpf_perf_event.h> > >>> > >>> ^ > >>> > >>> compilation terminated. > >>> ../scripts/Makefile.build:310: recipe for target 'init/main.o' failed > >> > >> How do you trigger that build failure? > >> Can you share your .config? > > Richard, it's just defconfig on both i386 and x86_64. How odd, here it used to build. ...until I did a make mrproper, and tried again. ;-\ Thanks, //richard ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Linux 4.15-rc3 (uml + bpf_perf_event.h) 2017-12-11 10:19 ` Daniel Borkmann 2017-12-11 17:27 ` Randy Dunlap @ 2017-12-11 18:49 ` Richard Weinberger 2017-12-11 18:56 ` Randy Dunlap 1 sibling, 1 reply; 8+ messages in thread From: Richard Weinberger @ 2017-12-11 18:49 UTC (permalink / raw) To: Daniel Borkmann Cc: Randy Dunlap, netdev@vger.kernel.org, Linus Torvalds, Linux Kernel Mailing List, alexei.starovoitov, brueckner Am Montag, 11. Dezember 2017, 11:19:54 CET schrieb Daniel Borkmann: > Hi Randy, hi Richard, [ +Hendrik for c895f6f703ad7dd2f ] > > On 12/11/2017 09:32 AM, Richard Weinberger wrote: > > Randy, > > > > Am Montag, 11. Dezember 2017, 03:42:12 CET schrieb Randy Dunlap: > >> On 12/10/2017 06:08 PM, Linus Torvalds wrote: > >>> Another week, another rc. > >> > >> um (uml) won't build on i386 or x86_64: > >> CC init/main.o > >> > >> In file included from ../include/linux/perf_event.h:18:0, > >> > >> from ../include/linux/trace_events.h:10, > >> from ../include/trace/syscall.h:7, > >> from ../include/linux/syscalls.h:82, > >> > >> from ../init/main.c:20: > >> ../include/uapi/linux/bpf_perf_event.h:11:32: fatal error: > >> asm/bpf_perf_event.h: No such file or directory #include > >> <asm/bpf_perf_event.h> > >> > >> ^ > >> > >> compilation terminated. > >> ../scripts/Makefile.build:310: recipe for target 'init/main.o' failed > > > > How do you trigger that build failure? > > Can you share your .config? > > Hmm, too bad kbuild bot doesn't catch issues on uml. I'm not too familiar > with uml, but looks like it's the only special case where there's no > arch/um/include/uapi/asm/. What is the usual convention to pull in such > headers in this case? Something like the below, would that fix it for you? > > Thanks for your help, > Daniel > > arch/um/include/asm/bpf_perf_event.h | 1 + > include/asm-generic/bpf_perf_event.h | 1 + > 2 files changed, 2 insertions(+) > create mode 100644 arch/um/include/asm/bpf_perf_event.h > create mode 100644 include/asm-generic/bpf_perf_event.h > > diff --git a/arch/um/include/asm/bpf_perf_event.h > b/arch/um/include/asm/bpf_perf_event.h new file mode 100644 > index 0000000..3097758 > --- /dev/null > +++ b/arch/um/include/asm/bpf_perf_event.h > @@ -0,0 +1 @@ > +#include <asm-generic/bpf_perf_event.h> > diff --git a/include/asm-generic/bpf_perf_event.h > b/include/asm-generic/bpf_perf_event.h new file mode 100644 > index 0000000..67112e5 > --- /dev/null > +++ b/include/asm-generic/bpf_perf_event.h > @@ -0,0 +1 @@ > +#include <uapi/asm-generic/bpf_perf_event.h> Hmm, what about this? diff --git a/arch/um/include/asm/Kbuild b/arch/um/include/asm/Kbuild index 50a32c33d729..fb35ec000433 100644 --- a/arch/um/include/asm/Kbuild +++ b/arch/um/include/asm/Kbuild @@ -27,3 +27,4 @@ generic-y += trace_clock.h generic-y += word-at-a-time.h generic-y += xor.h generic-y += kprobes.h +generic-y += bpf_perf_event.h -- sigma star gmbh - Eduard-Bodem-Gasse 6 - 6020 Innsbruck - Austria ATU66964118 - FN 374287y ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: Linux 4.15-rc3 (uml + bpf_perf_event.h) 2017-12-11 18:49 ` Richard Weinberger @ 2017-12-11 18:56 ` Randy Dunlap 0 siblings, 0 replies; 8+ messages in thread From: Randy Dunlap @ 2017-12-11 18:56 UTC (permalink / raw) To: Richard Weinberger, Daniel Borkmann Cc: netdev@vger.kernel.org, Linus Torvalds, Linux Kernel Mailing List, alexei.starovoitov, brueckner On 12/11/2017 10:49 AM, Richard Weinberger wrote: > Am Montag, 11. Dezember 2017, 11:19:54 CET schrieb Daniel Borkmann: >> Hi Randy, hi Richard, [ +Hendrik for c895f6f703ad7dd2f ] >> >> On 12/11/2017 09:32 AM, Richard Weinberger wrote: >>> Randy, >>> >>> Am Montag, 11. Dezember 2017, 03:42:12 CET schrieb Randy Dunlap: >>>> On 12/10/2017 06:08 PM, Linus Torvalds wrote: >>>>> Another week, another rc. >>>> >>>> um (uml) won't build on i386 or x86_64: >>>> CC init/main.o >>>> >>>> In file included from ../include/linux/perf_event.h:18:0, >>>> >>>> from ../include/linux/trace_events.h:10, >>>> from ../include/trace/syscall.h:7, >>>> from ../include/linux/syscalls.h:82, >>>> >>>> from ../init/main.c:20: >>>> ../include/uapi/linux/bpf_perf_event.h:11:32: fatal error: >>>> asm/bpf_perf_event.h: No such file or directory #include >>>> <asm/bpf_perf_event.h> >>>> >>>> ^ >>>> >>>> compilation terminated. >>>> ../scripts/Makefile.build:310: recipe for target 'init/main.o' failed >>> >>> How do you trigger that build failure? >>> Can you share your .config? >> >> Hmm, too bad kbuild bot doesn't catch issues on uml. I'm not too familiar >> with uml, but looks like it's the only special case where there's no >> arch/um/include/uapi/asm/. What is the usual convention to pull in such >> headers in this case? Something like the below, would that fix it for you? >> >> Thanks for your help, >> Daniel >> >> arch/um/include/asm/bpf_perf_event.h | 1 + >> include/asm-generic/bpf_perf_event.h | 1 + >> 2 files changed, 2 insertions(+) >> create mode 100644 arch/um/include/asm/bpf_perf_event.h >> create mode 100644 include/asm-generic/bpf_perf_event.h >> >> diff --git a/arch/um/include/asm/bpf_perf_event.h >> b/arch/um/include/asm/bpf_perf_event.h new file mode 100644 >> index 0000000..3097758 >> --- /dev/null >> +++ b/arch/um/include/asm/bpf_perf_event.h >> @@ -0,0 +1 @@ >> +#include <asm-generic/bpf_perf_event.h> >> diff --git a/include/asm-generic/bpf_perf_event.h >> b/include/asm-generic/bpf_perf_event.h new file mode 100644 >> index 0000000..67112e5 >> --- /dev/null >> +++ b/include/asm-generic/bpf_perf_event.h >> @@ -0,0 +1 @@ >> +#include <uapi/asm-generic/bpf_perf_event.h> > > Hmm, what about this? > > diff --git a/arch/um/include/asm/Kbuild b/arch/um/include/asm/Kbuild > index 50a32c33d729..fb35ec000433 100644 > --- a/arch/um/include/asm/Kbuild > +++ b/arch/um/include/asm/Kbuild > @@ -27,3 +27,4 @@ generic-y += trace_clock.h > generic-y += word-at-a-time.h > generic-y += xor.h > generic-y += kprobes.h > +generic-y += bpf_perf_event.h > That also works for arch/um. thanks, -- ~Randy ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-12-11 18:56 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CA+55aFz9O9R8u3ori-QNPz4ALU+0B=Es0gd+oWmsce5qxugxXA@mail.gmail.com>
2017-12-11 2:42 ` Linux 4.15-rc3 (uml + bpf_perf_event.h) Randy Dunlap
2017-12-11 8:32 ` Richard Weinberger
2017-12-11 10:19 ` Daniel Borkmann
2017-12-11 17:27 ` Randy Dunlap
2017-12-11 17:32 ` Daniel Borkmann
2017-12-11 18:19 ` Richard Weinberger
2017-12-11 18:49 ` Richard Weinberger
2017-12-11 18:56 ` Randy Dunlap
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).