From: Eric Dumazet <eric.dumazet@gmail.com>
To: Christoph Paasch <cpaasch@apple.com>, netdev@vger.kernel.org
Cc: Eric Dumazet <edumazet@google.com>,
Yuchung Cheng <ycheng@google.com>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next 2/5] tcp: TFO: search for correct cookie and accept data
Date: Sun, 16 Dec 2018 22:30:51 -0800 [thread overview]
Message-ID: <80ac109a-6e97-e24b-beea-37c047be4f55@gmail.com> (raw)
In-Reply-To: <20181214224007.54813-3-cpaasch@apple.com>
On 12/14/2018 02:40 PM, Christoph Paasch wrote:
> This change allows to search for the right cookie and accepts old ones
> (announcing a new one if it has changed).
>
> __tcp_fastopen_cookie_gen_with_ctx() allows to generate a cookie based
> on a given TFO-context. A later patch will cleanup the duplicate code.
How long is kept the secondary (old) context ?
I do not know exact crypto_cipher_encrypt_one() cost, but it looks like
your patch could double the cost of some TFO based attacks ?
next prev parent reply other threads:[~2018-12-17 6:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 22:40 [PATCH net-next 0/5] tcp: Introduce a TFO key-pool for clean cookie-rotation Christoph Paasch
2018-12-14 22:40 ` [PATCH net-next 1/5] tcp: Create list of TFO-contexts Christoph Paasch
2018-12-17 6:31 ` Eric Dumazet
2018-12-17 15:49 ` Christoph Paasch
2018-12-17 16:07 ` Eric Dumazet
2018-12-17 16:04 ` Eric Dumazet
2018-12-17 21:57 ` Christoph Paasch
2018-12-17 22:01 ` Eric Dumazet
2018-12-17 22:50 ` Christoph Paasch
2018-12-14 22:40 ` [PATCH net-next 2/5] tcp: TFO: search for correct cookie and accept data Christoph Paasch
2018-12-17 6:30 ` Eric Dumazet [this message]
2018-12-17 22:59 ` Christoph Paasch
2018-12-14 22:40 ` [PATCH net-next 3/5] tcp: Print list of TFO-keys from proc Christoph Paasch
2018-12-17 6:32 ` Eric Dumazet
2018-12-17 16:52 ` Yuchung Cheng
2018-12-17 23:35 ` Christoph Paasch
2018-12-17 23:49 ` Yuchung Cheng
2018-12-14 22:40 ` [PATCH net-next 4/5] tcp: Allow getsockopt of listener's keypool Christoph Paasch
2018-12-14 22:40 ` [PATCH net-next 5/5] tcp: TFO - cleanup code duplication Christoph Paasch
2018-12-17 6:33 ` Eric Dumazet
2018-12-18 0:16 ` Christoph Paasch
2018-12-16 20:19 ` [PATCH net-next 0/5] tcp: Introduce a TFO key-pool for clean cookie-rotation David Miller
2018-12-17 5:54 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80ac109a-6e97-e24b-beea-37c047be4f55@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=cpaasch@apple.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).