From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCDFCC0502A for ; Sat, 27 Aug 2022 15:52:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233587AbiH0PwO (ORCPT ); Sat, 27 Aug 2022 11:52:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233264AbiH0PwN (ORCPT ); Sat, 27 Aug 2022 11:52:13 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B27162F64C for ; Sat, 27 Aug 2022 08:52:11 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id kk26so8085225ejc.11 for ; Sat, 27 Aug 2022 08:52:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=blackwall-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=3YczR2Egl4ZFRyscdYYWi5wk2fHwMzSOUnVWfHdBreM=; b=XzCjQYL7pcKNpZS+XZ/jvaKcz044RvIp2Kqny5OT1idIVch+NIlfnHsadgKWYFDb0E LrNd0hKaoyAkJgnlUbgT753luKRo2WarLndU46VH401AIJex/4AHi+GjE2AERqIw4E67 KcTGvWm0Cb47y9tZiiVeDXe5aGt3zgsJdX1yvhdGB9sF/Z6qTtvJ64moVxFbEZ3rr5yl pikp+Km8ABi40dgWtLH8Rsk1foqkvANAJBLYdZG/VUu8A9htUuS+ZXPGuaLcw/QxhNIa TflL902OKXy2G0jqaGBSpTTwIag6f4IKoc6DsHiVXpu3AccPpZkYXLscSaqqcDhfEPOK 8xYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=3YczR2Egl4ZFRyscdYYWi5wk2fHwMzSOUnVWfHdBreM=; b=a3lLUmeS8UowjEoHqZI3nMzeH5lJJaz798M3nbAfUbdbUm8bULMaVkmf3Ie1RDw91G rMSeariXtqiIppNvTSaBFbd8rrYoFHnQvD8S/wGcGaqHGYXiBi2aFLndO0guKH0O0jVb kRLy/tK6mQY1NZ/BHtGhzCGj+UkOWKi0gHnHaPUmW+dtC2kK+OYkuRMmvsWsb0iR1yeo yBawbzRcWaAErZ8i74kpGUU6oRvrFM3OkzglfM70xKRJwS/CV1pSQC6Y08rrAShw8hxU OlKeiNnQnwUv1UHlc+jTnUQAnm8fJhyW3BdK7zi1I+m3PZFLVTzqQE/lA2bsPPUSIzZ+ LKAg== X-Gm-Message-State: ACgBeo0AcHhHb4BQjF77JgqBM4409r3OtR0zdMnqHD+3/Cc/YaatdIgd jI4qQ3B68ju8b3FqEvNLQ0alRg== X-Google-Smtp-Source: AA6agR4UGFSDEBI+Zywo6Rd/RBwcZqB0s8dtcq4AUgPmhKGokDX6cNXLGrVlY+XIvgUPkPzXaFkbVA== X-Received: by 2002:a17:907:724e:b0:740:e3e5:c01d with SMTP id ds14-20020a170907724e00b00740e3e5c01dmr4496051ejc.38.1661615530225; Sat, 27 Aug 2022 08:52:10 -0700 (PDT) Received: from [192.168.0.111] (87-243-81-1.ip.btc-net.bg. [87.243.81.1]) by smtp.gmail.com with ESMTPSA id z13-20020a05640235cd00b0044847e0e8ccsm257324edc.28.2022.08.27.08.52.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 27 Aug 2022 08:52:09 -0700 (PDT) Message-ID: <80c8a02f-95b9-8e96-b05c-016b43876c15@blackwall.org> Date: Sat, 27 Aug 2022 18:52:07 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v5 net-next 2/6] net: switchdev: add support for offloading of fdb locked flag Content-Language: en-US To: Ido Schimmel , Hans Schultz Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Florian Fainelli , Andrew Lunn , Vivien Didelot , Vladimir Oltean , Eric Dumazet , Paolo Abeni , Kurt Kanzenbach , Hauke Mehrtens , Woojung Huh , UNGLinuxDriver@microchip.com, Sean Wang , Landen Chao , DENG Qingfang , Matthias Brugger , Claudiu Manoil , Alexandre Belloni , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Shuah Khan , Christian Marangi , Daniel Borkmann , Yuwei Wang , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bridge@lists.linux-foundation.org, linux-kselftest@vger.kernel.org References: <20220826114538.705433-1-netdev@kapio-technology.com> <20220826114538.705433-3-netdev@kapio-technology.com> From: Nikolay Aleksandrov In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 27/08/2022 18:46, Ido Schimmel wrote: > On Fri, Aug 26, 2022 at 01:45:34PM +0200, Hans Schultz wrote: >> diff --git a/include/net/switchdev.h b/include/net/switchdev.h >> index 7dcdc97c0bc3..437945179373 100644 >> --- a/include/net/switchdev.h >> +++ b/include/net/switchdev.h >> @@ -247,7 +247,10 @@ struct switchdev_notifier_fdb_info { >> const unsigned char *addr; >> u16 vid; >> u8 added_by_user:1, >> + sticky:1, > > If mv88e6xxx reports entries with 'is_local=1, locked=1, blackhole=1', > then the 'sticky' bit can be removed for now (we will need it some day > to support sticky entries notified from the bridge). This takes care of > the discrepancy Nik mentioned here: > > https://lore.kernel.org/netdev/d1de0337-ae16-7dca-b212-1a4e85129c31@blackwall.org/ > +1 >> is_local:1, >> + locked:1, >> + blackhole:1, >> offloaded:1; >> };