From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jose Abreu <jose.abreu@synopsys.com>
Subject: Re: [PATCH net-next 3/4] net: phy-c45: Implement reset/suspend/resume
 callbacks
Date: Mon, 22 Oct 2018 13:47:48 +0100
Message-ID: <8114f345-0efb-9a64-b867-2cfe2fba09ab@synopsys.com>
References: <cover.1540204182.git.joabreu@synopsys.com>
 <b65cd0978587224eb1496ad60d224394525b8ba6.1540204183.git.joabreu@synopsys.com>
 <20181022122839.GB24112@lunn.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Cc: <netdev@vger.kernel.org>, Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Joao Pinto <joao.pinto@synopsys.com>
To: Andrew Lunn <andrew@lunn.ch>, Jose Abreu <jose.abreu@synopsys.com>,
        Russell King - ARM Linux <linux@armlinux.org.uk>
Return-path: <netdev-owner@vger.kernel.org>
Received: from us01smtprelay-2.synopsys.com ([198.182.60.111]:48916 "EHLO
        smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727218AbeJVVGW (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 22 Oct 2018 17:06:22 -0400
In-Reply-To: <20181022122839.GB24112@lunn.ch>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Hello,

On 22-10-2018 13:28, Andrew Lunn wrote:
>>  EXPORT_SYMBOL_GPL(gen10g_resume);
>> @@ -327,7 +381,7 @@ struct phy_driver genphy_10g_driver = {
>>  	.phy_id         = 0xffffffff,
>>  	.phy_id_mask    = 0xffffffff,
>>  	.name           = "Generic 10G PHY",
>> -	.soft_reset	= gen10g_no_soft_reset,
>> +	.soft_reset	= gen10g_soft_reset,
>>  	.config_init    = gen10g_config_init,
>>  	.features       = 0,
>>  	.aneg_done	= genphy_c45_aneg_done,
> Hi Jose
>
> You need to be careful here. There is a reason this is called
> gen10g_no_soft_reset, rather than having an empty
> gen10g_soft_reset. Some PHYs break when you do a reset.  So adding a
> gen10g_soft_reset is fine, but don't change this here, without first
> understanding the history, and talking to Russell King.

Hmm, the reset function only interacts with standard PCS
registers, which should always be available ...

>>From my tests I need to do at least 1 reset during power-up so in
ultimate case I can add a feature quirk or similar.

Russell, can you please comment ?

Thanks and Best Regards,
Jose Miguel Abreu

>
> 	      Andrew