Re: [PATCH net-next v4 1/2] net: hsr: require valid EOT supervision TLV

[Luka Gejak <luka.gejak@linux.dev>]

On April 2, 2026 1:30:57 AM GMT+02:00, Fernando Fernandez Mancera <fmancera@suse.de> wrote:
>On 4/1/26 7:05 PM, Luka Gejak wrote:
>> On Wed Apr 1, 2026 at 11:52 AM CEST, Fernando Fernandez Mancera wrote:
>>> On 4/1/26 11:23 AM, luka.gejak@linux.dev wrote:
>>>> From: Luka Gejak <luka.gejak@linux.dev>
>>>> 
>>>> Supervision frames are only valid if terminated with a zero-length EOT
>>>> TLV. The current check fails to reject non-EOT entries as the terminal
>>>> TLV, potentially allowing malformed supervision traffic.
>>>> 
>>>> Fix this by strictly requiring the terminal TLV to be HSR_TLV_EOT
>>>> with a length of zero.
>>>> 
>>>> Reviewed-by: Felix Maurer <fmaurer@redhat.com>
>>>> Signed-off-by: Luka Gejak <luka.gejak@linux.dev>
>>>> ---
>>> 
>>> Hi,
>>> 
>>> This has not been reviewed by Felix. Felix provided his Reviewed-by tag
>>> for the v1 which was completely different than this.
>>> 
>>> Revisions of this patch:
>>> 
>>> v3: https://lore.kernel.org/all/20260329112313.17164-4-luka.gejak@linux.dev/
>>> 
>>> v2: https://lore.kernel.org/all/20260326154715.38405-4-luka.gejak@linux.dev/
>>> 
>>> v1:
>>> https://lore.kernel.org/all/20260324143503.187642-4-luka.gejak@linux.dev/
>>> 
>>> Are these contributions LLM/AI generated? I believe so based on the
>>> email history.
>>> 
>>> AI generated review on rtl8723bs:
>>> https://lore.kernel.org/all/B2394A3C-25FD-4CEA-8557-3E68F1F60357@linux.dev/
>>> 
>>> Another AI generated review on rtl8723bs:
>>> https://lore.kernel.org/all/3831D599-655E-40B2-9E5D-9DF956013088@linux.dev/
>>> 
>>> Likely an AI generated review on a 1 year old HSR patch:
>>> https://lore.kernel.org/all/DHFG26KI6L23.1YCOVQ5SSYMO5@linux.dev/
>>> 
>>> If these are indeed, AI generated contributions or reviews they should
>>> be disclosed beforehand. Also there is the Assisted-by: tag. Also note
>>> that developer must take full responsibility for the contribution which
>>> means understanding it completely.
>>> 
>>> https://docs.kernel.org/process/coding-assistants.html#signed-off-by-and-developer-certificate-of-origin
>>> 
>>> Thanks,
>>> Fernando.
>> 
>> HI Fernando,
>> One more question, should I include Assisted-by tag in v5 if AI was not
>> used for writing code but only for formating and translation of the
>> emails to English as I previously mentioned.
>> 
>
>I think yes, you should. I also think that AI was actually used for the generated code and also for spotting the valid and invalid issues. If you don't have a real environment for HSR, why would you look into it?
>
>Sorry, it is not my intention to be harsh but there are some things that don't add up for me. Maybe I am being too careful here and you just coincidentally found these problems.
>
>> Best regards,
>> Luka Gejak
>> 
>

Hi Fernando,
I understand the concern. To clarify, I am a student, and I discovered
these issues while reading the HSR source to learn about network 
redundancy. Since I lack industrial hardware, I verified the logic 
using network namespaces and veth pairs on my Arch laptop. The code 
and logic are entirely my. As previously mentioned, I only use AI for 
English translation and formatting to ensure my communication is 
clear. As requested, I will wait for Felix's review before proceeding 
with any changes for v5.
Best regards,
Luka Gejak