From: David Ahern <dsahern@kernel.org>
To: Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, Willem de Bruijn <willemb@google.com>,
Jonathan Davies <jonathan.davies@nutanix.com>,
eric.dumazet@gmail.com
Subject: Re: [PATCH net 0/2] net: two fixes for qdisc_pkt_len_init()
Date: Wed, 25 Sep 2024 20:26:55 -0600 [thread overview]
Message-ID: <814042a4-15e5-4288-a526-37213ddda710@kernel.org> (raw)
In-Reply-To: <20240924150257.1059524-1-edumazet@google.com>
On 9/24/24 9:02 AM, Eric Dumazet wrote:
> Inspired by one syzbot report.
>
> At least one qdisc (fq_codel) depends on qdisc_skb_cb(skb)->pkt_len
> having a sane value (not zero)
>
> With the help of af_packet, syzbot was able to fool qdisc_pkt_len_init()
> to precisely set qdisc_skb_cb(skb)->pkt_len to zero.
>
> First patch fixes this issue.
>
> Second one (a separate one to help future bisections) adds
> more sanity check to SKB_GSO_DODGY users.
>
> Eric Dumazet (2):
> net: avoid potential underflow in qdisc_pkt_len_init() with UFO
> net: add more sanity checks to qdisc_pkt_len_init()
>
> net/core/dev.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
LGTM. For the set:
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2024-09-26 2:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-24 15:02 [PATCH net 0/2] net: two fixes for qdisc_pkt_len_init() Eric Dumazet
2024-09-24 15:02 ` [PATCH net 1/2] net: avoid potential underflow in qdisc_pkt_len_init() with UFO Eric Dumazet
2024-09-26 9:07 ` Willem de Bruijn
2024-09-26 18:00 ` Jonathan Davies
2024-09-24 15:02 ` [PATCH net 2/2] net: add more sanity checks to qdisc_pkt_len_init() Eric Dumazet
2024-09-25 17:51 ` Joe Damato
2024-09-25 18:00 ` Eric Dumazet
2024-09-25 18:24 ` Joe Damato
2024-09-25 18:27 ` Stephen Hemminger
2024-09-25 18:55 ` Eric Dumazet
2024-09-25 19:01 ` Eric Dumazet
2024-09-25 19:15 ` Joe Damato
2024-09-25 19:07 ` Joe Damato
2024-09-25 19:08 ` Eric Dumazet
2024-09-26 9:13 ` Willem de Bruijn
2024-09-26 9:17 ` Willem de Bruijn
2024-09-26 9:19 ` Eric Dumazet
2024-10-01 9:57 ` Paolo Abeni
2024-09-26 2:26 ` David Ahern [this message]
2024-10-01 10:10 ` [PATCH net 0/2] net: two fixes for qdisc_pkt_len_init() patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=814042a4-15e5-4288-a526-37213ddda710@kernel.org \
--to=dsahern@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=jonathan.davies@nutanix.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).