* [PATCH net] net: clear skb->tstamp in bridge forwarding path
@ 2019-01-08 17:45 Paolo Abeni
2019-01-10 11:02 ` Nikolay Aleksandrov
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Paolo Abeni @ 2019-01-08 17:45 UTC (permalink / raw)
To: netdev
Cc: David S. Miller, Roopa Prabhu, Nikolay Aleksandrov, mcroce,
Eric Dumazet
Matteo reported forwarding issues inside the linux bridge,
if the enslaved interfaces use the fq qdisc.
Similar to commit 8203e2d844d3 ("net: clear skb->tstamp in
forwarding paths"), we need to clear the tstamp field in
the bridge forwarding path.
Fixes: 80b14dee2bea ("net: Add a new socket option for a future transmit time.")
Fixes: fb420d5d91c1 ("tcp/fq: move back to CLOCK_MONOTONIC")
Reported-and-tested-by: Matteo Croce <mcroce@redhat.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
---
net/bridge/br_forward.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/bridge/br_forward.c b/net/bridge/br_forward.c
index 5372e2042adf..2cb8da465b98 100644
--- a/net/bridge/br_forward.c
+++ b/net/bridge/br_forward.c
@@ -65,6 +65,7 @@ EXPORT_SYMBOL_GPL(br_dev_queue_push_xmit);
int br_forward_finish(struct net *net, struct sock *sk, struct sk_buff *skb)
{
+ skb->tstamp = 0;
return NF_HOOK(NFPROTO_BRIDGE, NF_BR_POST_ROUTING,
net, sk, skb, NULL, skb->dev,
br_dev_queue_push_xmit);
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH net] net: clear skb->tstamp in bridge forwarding path
2019-01-08 17:45 [PATCH net] net: clear skb->tstamp in bridge forwarding path Paolo Abeni
@ 2019-01-10 11:02 ` Nikolay Aleksandrov
2019-01-10 15:47 ` Roopa Prabhu
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Nikolay Aleksandrov @ 2019-01-10 11:02 UTC (permalink / raw)
To: Paolo Abeni, netdev; +Cc: David S. Miller, Roopa Prabhu, mcroce, Eric Dumazet
On 08/01/2019 19:45, Paolo Abeni wrote:
> Matteo reported forwarding issues inside the linux bridge,
> if the enslaved interfaces use the fq qdisc.
>
> Similar to commit 8203e2d844d3 ("net: clear skb->tstamp in
> forwarding paths"), we need to clear the tstamp field in
> the bridge forwarding path.
>
> Fixes: 80b14dee2bea ("net: Add a new socket option for a future transmit time.")
> Fixes: fb420d5d91c1 ("tcp/fq: move back to CLOCK_MONOTONIC")
> Reported-and-tested-by: Matteo Croce <mcroce@redhat.com>
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> ---
> net/bridge/br_forward.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/bridge/br_forward.c b/net/bridge/br_forward.c
> index 5372e2042adf..2cb8da465b98 100644
> --- a/net/bridge/br_forward.c
> +++ b/net/bridge/br_forward.c
> @@ -65,6 +65,7 @@ EXPORT_SYMBOL_GPL(br_dev_queue_push_xmit);
>
> int br_forward_finish(struct net *net, struct sock *sk, struct sk_buff *skb)
> {
> + skb->tstamp = 0;
> return NF_HOOK(NFPROTO_BRIDGE, NF_BR_POST_ROUTING,
> net, sk, skb, NULL, skb->dev,
> br_dev_queue_push_xmit);
>
Acked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net] net: clear skb->tstamp in bridge forwarding path
2019-01-08 17:45 [PATCH net] net: clear skb->tstamp in bridge forwarding path Paolo Abeni
2019-01-10 11:02 ` Nikolay Aleksandrov
@ 2019-01-10 15:47 ` Roopa Prabhu
2019-01-11 9:36 ` Eric Dumazet
2019-01-12 2:28 ` David Miller
3 siblings, 0 replies; 5+ messages in thread
From: Roopa Prabhu @ 2019-01-10 15:47 UTC (permalink / raw)
To: Paolo Abeni
Cc: netdev, David S. Miller, Nikolay Aleksandrov, mcroce,
Eric Dumazet
On Tue, Jan 8, 2019 at 9:45 AM Paolo Abeni <pabeni@redhat.com> wrote:
>
> Matteo reported forwarding issues inside the linux bridge,
> if the enslaved interfaces use the fq qdisc.
>
> Similar to commit 8203e2d844d3 ("net: clear skb->tstamp in
> forwarding paths"), we need to clear the tstamp field in
> the bridge forwarding path.
>
> Fixes: 80b14dee2bea ("net: Add a new socket option for a future transmit time.")
> Fixes: fb420d5d91c1 ("tcp/fq: move back to CLOCK_MONOTONIC")
> Reported-and-tested-by: Matteo Croce <mcroce@redhat.com>
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Acked-by: Roopa Prabhu <roopa@cumulusnetworks.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net] net: clear skb->tstamp in bridge forwarding path
2019-01-08 17:45 [PATCH net] net: clear skb->tstamp in bridge forwarding path Paolo Abeni
2019-01-10 11:02 ` Nikolay Aleksandrov
2019-01-10 15:47 ` Roopa Prabhu
@ 2019-01-11 9:36 ` Eric Dumazet
2019-01-12 2:28 ` David Miller
3 siblings, 0 replies; 5+ messages in thread
From: Eric Dumazet @ 2019-01-11 9:36 UTC (permalink / raw)
To: Paolo Abeni, netdev
Cc: David S. Miller, Roopa Prabhu, Nikolay Aleksandrov, mcroce
On 01/08/2019 09:45 AM, Paolo Abeni wrote:
> Matteo reported forwarding issues inside the linux bridge,
> if the enslaved interfaces use the fq qdisc.
>
> Similar to commit 8203e2d844d3 ("net: clear skb->tstamp in
> forwarding paths"), we need to clear the tstamp field in
> the bridge forwarding path.
>
> Fixes: 80b14dee2bea ("net: Add a new socket option for a future transmit time.")
> Fixes: fb420d5d91c1 ("tcp/fq: move back to CLOCK_MONOTONIC")
> Reported-and-tested-by: Matteo Croce <mcroce@redhat.com>
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> ---
Reviewed-by: Eric Dumazet <edumazet@google.com>
Sorry for the delay, I have been traveling last days.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net] net: clear skb->tstamp in bridge forwarding path
2019-01-08 17:45 [PATCH net] net: clear skb->tstamp in bridge forwarding path Paolo Abeni
` (2 preceding siblings ...)
2019-01-11 9:36 ` Eric Dumazet
@ 2019-01-12 2:28 ` David Miller
3 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2019-01-12 2:28 UTC (permalink / raw)
To: pabeni; +Cc: netdev, roopa, nikolay, mcroce, eric.dumazet
From: Paolo Abeni <pabeni@redhat.com>
Date: Tue, 8 Jan 2019 18:45:05 +0100
> Matteo reported forwarding issues inside the linux bridge,
> if the enslaved interfaces use the fq qdisc.
>
> Similar to commit 8203e2d844d3 ("net: clear skb->tstamp in
> forwarding paths"), we need to clear the tstamp field in
> the bridge forwarding path.
>
> Fixes: 80b14dee2bea ("net: Add a new socket option for a future transmit time.")
> Fixes: fb420d5d91c1 ("tcp/fq: move back to CLOCK_MONOTONIC")
> Reported-and-tested-by: Matteo Croce <mcroce@redhat.com>
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Applied and queued up for -stable.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-12 2:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-08 17:45 [PATCH net] net: clear skb->tstamp in bridge forwarding path Paolo Abeni
2019-01-10 11:02 ` Nikolay Aleksandrov
2019-01-10 15:47 ` Roopa Prabhu
2019-01-11 9:36 ` Eric Dumazet
2019-01-12 2:28 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).