From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43CD8C282C8 for ; Mon, 28 Jan 2019 20:50:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0F210214DA for ; Mon, 28 Jan 2019 20:50:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m0IKL0PS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726984AbfA1Uuz (ORCPT ); Mon, 28 Jan 2019 15:50:55 -0500 Received: from mail-it1-f194.google.com ([209.85.166.194]:35604 "EHLO mail-it1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726719AbfA1Uuy (ORCPT ); Mon, 28 Jan 2019 15:50:54 -0500 Received: by mail-it1-f194.google.com with SMTP id p197so693797itp.0 for ; Mon, 28 Jan 2019 12:50:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=5sALDV6+ZhMCHKU1hi3m5Aewj1rtLl8Tx8ysBZD7kHE=; b=m0IKL0PSDE6dEMzLFGJ4q5/DBqJI87k9syiv9+CkMI4bYwCcy/eG3ZscsQJniUYoG0 Op4Ez/paB1ez2VJuQduPiFJSA9j+i3LAVDg9tIZj1kP+g+hcCY/7jiT1CgjfyrMc3jEn +z1HXRY7rNwZR1ied6R6U7GrMOqZpzSedtnAng4fnnrYI+V+XHLbh6H7jYbOCRQPG9e2 xOzLgQYJ54Lb1Sn4IKDb8O1fM9Wk1FYTFnyagfHCmIQDRSJ9JTw13Pt+/KAf2ttIaSvl ppgYzi3hyLO6rlftmb18iMXhTrkUrEK7LDrWI4X1w+ThyE29BjUrcMb6ZXYtccf+Wxg1 FFuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5sALDV6+ZhMCHKU1hi3m5Aewj1rtLl8Tx8ysBZD7kHE=; b=nIQUd5C7GVAV1VR60qHi6X2mgle1mtA4epPIaSnd+HV1FDNFsEKGpHKyqUyeq6hxn5 ItkQykPB2wRrf79oBFepdJ2MmdwX6dAZ5kRJHdmyrKzbgO30YiwKKGr504aZj6aAimic 0BZ2emSJDvcTe7HjE8ulwJRbZG3vJIqumhKcCi2n7PYozdCYoS1TQe1gQqll7pYZaKPf FaKOWLAH6PxFaxRSh5AdGQf4gpQEsydkzFHi6nL8oLPdV8+5E5uvnVttZeb24aQQn+Kr JyB5GhlDddTAeSU6HTxPszfCa/uLxhaxTBja/Rc/SSxlwwYwbw1BoKE4FCQFiSxjZ1wK 08fw== X-Gm-Message-State: AJcUukenxb1YBMuplQsMn/Ppnc/hRETIr895N3LTLFKdwjPvVknMk7/B ARu5hk2v4g+O6M5x5lCKEos= X-Google-Smtp-Source: ALg8bN6+yYYqEEtMnBOx0m5Tm4Qz3D6T05I26ADnNfNJq9YXy9qQVMJ9pNubLBC93qLTW1RJRpy+/w== X-Received: by 2002:a24:1aca:: with SMTP id 193mr11457835iti.150.1548708653945; Mon, 28 Jan 2019 12:50:53 -0800 (PST) Received: from [192.168.86.250] ([184.63.162.180]) by smtp.gmail.com with ESMTPSA id j8sm270308itb.30.2019.01.28.12.50.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Jan 2019 12:50:53 -0800 (PST) Subject: Re: [PATCH bpf-next v4 2/7] samples/bpf: xdp_redirect_cpu have not need for read_trace_pipe To: Maciej Fijalkowski , daniel@iogearbox.net, ast@kernel.org Cc: netdev@vger.kernel.org, jakub.kicinski@netronome.com, brouer@redhat.com References: <20190128191613.11705-1-maciejromanfijalkowski@gmail.com> <20190128191613.11705-3-maciejromanfijalkowski@gmail.com> From: John Fastabend Message-ID: <816ed0c1-3b83-91bd-a1f2-53ca9f5bf19d@gmail.com> Date: Mon, 28 Jan 2019 12:50:40 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190128191613.11705-3-maciejromanfijalkowski@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 1/28/19 11:16 AM, Maciej Fijalkowski wrote: > From: Jesper Dangaard Brouer > > The sample xdp_redirect_cpu is not using helper bpf_trace_printk. > Thus it makes no sense that the --debug option us reading > from /sys/kernel/debug/tracing/trace_pipe via read_trace_pipe. > Simply remove it. > > Signed-off-by: Jesper Dangaard Brouer Acked-by: John Fastabend