From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [net-next, RFC, 4/8] net: core: add recycle capabilities on skbs
 via page_pool API
Date: Sat, 8 Dec 2018 14:36:01 -0800
Message-ID: <81861872-5abc-277c-cfae-d8fdc3a697e6@gmail.com>
References: <154413874729.21735.10644578158550468689.stgit@firesoul>
 <20181208095758.GA32028@strlen.de>
 <72f33f12-9222-cbe7-6ff2-e4b4f86fb17c@gmail.com>
 <20181208145728.GA10660@apalos>
 <db053651-5de2-26c3-8fae-1a077a665dd0@gmail.com>
 <20181208211153.68f1424e@redhat.com> <20181208201447.GA17821@apalos>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Florian Westphal <fw@strlen.de>, netdev@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= <toke@toke.dk>,
        ard.biesheuvel@linaro.org, Jason Wang <jasowang@redhat.com>,
        =?UTF-8?B?QmrDtnJuVMO2cGVs?= <bjorn.topel@intel.com>, w@1wt.eu,
        Saeed Mahameed <saeedm@mellanox.com>,
        mykyta.iziumtsev@gmail.com,
        Daniel Borkmann <borkmann@iogearbox.net>,
        Alexei Starovoitov <alexei.starovoitov@gmail.com>,
        Tariq Toukan <tariqt@mellanox.com>
To: Ilias Apalodimas <ilias.apalodimas@linaro.org>,
        Jesper Dangaard Brouer <brouer@redhat.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pf1-f180.google.com ([209.85.210.180]:34167 "EHLO
        mail-pf1-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726115AbeLHWgF (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sat, 8 Dec 2018 17:36:05 -0500
Received: by mail-pf1-f180.google.com with SMTP id h3so3594235pfg.1
        for <netdev@vger.kernel.org>; Sat, 08 Dec 2018 14:36:05 -0800 (PST)
In-Reply-To: <20181208201447.GA17821@apalos>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>



On 12/08/2018 12:14 PM, Ilias Apalodimas wrote:
> On Sat, Dec 08, 2018 at 09:11:53PM +0100, Jesper Dangaard Brouer wrote:
>>>  
>>> I want to make sure you guys thought about splice() stuff, and
>>> skb_try_coalesce(), and GRO, and skb cloning, and ...
>>
>> Thanks for the pointers. To Ilias, we need to double check skb_try_coalesce()
>> code path, as it does look like we don't handle this correctly.
>>
> 
> Noted. We did check skb cloning, but not this one indeed

There is also TCP RX zero copy to consider ( tcp_zerocopy_receive() )
but more generally all paths that can grab pages from skbs.