From: Jeremy Kerr <jk@codeconstruct.com.au>
To: Adam Young <admiyo@amperemail.onmicrosoft.com>,
Adam Young <admiyo@os.amperecomputing.com>,
Matt Johnston <matt@codeconstruct.com.au>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Sudeep Holla <sudeep.holla@arm.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Huisong Li <lihuisong@huawei.com>
Subject: Re: [net-next v32 2/2] mctp pcc: Implement MCTP over PCC Transport
Date: Mon, 16 Mar 2026 10:23:56 +0800 [thread overview]
Message-ID: <81939fbe065bca0169b84198b9fefac5f188f4e0.camel@codeconstruct.com.au> (raw)
In-Reply-To: <b2811dac-5bb0-4d9f-882d-a8b40e49a37d@amperemail.onmicrosoft.com>
Hi Adam,
> I just realized that I am reporting the number of bytes sent including
> the pcc header. I suspect that will mess up the byte accounting: these
> are being reported on MCTP links, and they have no way of knowing that
> they should be removing the PCC header length. Should I be removing the
> pcc Header length from the byte counts for packets-sent?
No, that's fine, keep it as-is. The TX/RXed headers are part of the data
sent/received over the transport so can be justifiably included in the
stats.
Cheers,
Jeremy
prev parent reply other threads:[~2026-03-16 2:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 21:36 [net-next v32 0/2] MCTP Over PCC Transport Adam Young
2026-03-03 21:36 ` [net-next v32 1/2] mailbox: pcc: functions for reading and writing PCC extended data Adam Young
2026-03-16 3:57 ` Adam Young
2026-03-03 21:36 ` [net-next v32 2/2] mctp pcc: Implement MCTP over PCC Transport Adam Young
2026-03-04 1:12 ` Jeremy Kerr
2026-03-13 16:22 ` Adam Young
2026-03-16 2:23 ` Jeremy Kerr [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81939fbe065bca0169b84198b9fefac5f188f4e0.camel@codeconstruct.com.au \
--to=jk@codeconstruct.com.au \
--cc=Jonathan.Cameron@huawei.com \
--cc=admiyo@amperemail.onmicrosoft.com \
--cc=admiyo@os.amperecomputing.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=lihuisong@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeconstruct.com.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox