From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E4FA1E8826; Fri, 12 Jun 2026 18:07:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781287676; cv=none; b=PpFLOCIyjok4Ug8yV/4Qo/xA88iAZkbEm1CodXQ+/2mORbEYRYfDpDbfyIZfyswuUcwt7XdKqQFtk22e7Z3vdlzEhsj4y/pzosWhnDdsINLj25ZBCkR0+ieeDXKwm3TPECsrZjCnlSkDqI5xVaQ8LxWAxru3l/H894YJU2j7Fvk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781287676; c=relaxed/simple; bh=8eRT8ZuFM44s1O9IpyOVo2ijLPjKIwnkXzhApRlDln8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Sdx18zvRPorWTEOzV1Wa9/p0db+McpfXLyt05cxNyuQykRulDLO/KR1Xeoi96wO7RLx6LNFmJBOVBtmoQppIRHbM+XsHwFLO0QE5/3Z0P7pl/Bt6E+UvvabY6dGDsguSiDW6WY64W2ljqDVz0QotOZ2AvYJNwTJyNvnYveJSfqE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YZw0HBQT; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YZw0HBQT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BC74B1F000E9; Fri, 12 Jun 2026 18:07:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781287674; bh=VDAc4dbWKH4fNV2T21Pns9VB8fFCL+sCAgaQsmPOa2M=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=YZw0HBQTvGOG9hGwGe0OzoQDR5U9pjaZSBSoAjbUCMuyMOoKpLjNivdJWMOnAt98p Tuvk755hU6wIZlhx/9NS5+i0Z9v0DR3Y9PoXp1+1LRtRS0AmvReXGxmM9rUG1uqJTw RJuvNufxqrvF4R1CaPsx38hv8WW5o5S6O4G5uNTKhctGAG9HPHW2qHFuVmorPQGNPt LtrZ+KxstR+3kvnXwMZrJqEtGhbw0DbjKRT9Ajtz2vqbX7AFbg4hCYKHK8zTM4PTsV +Rc9scpHd9KikMq+Vhq+inNhCSvAwDFf0hIz69gqhopDxe6WvtGxYciZSwiaSjSCEk mUEg/T5BvqStg== Message-ID: <81c24adb-c0b9-4db5-80cb-e30dfdd5e83a@kernel.org> Date: Fri, 12 Jun 2026 20:07:50 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/5] binder: Remove mmap_lock fallback Content-Language: en-US To: Dave Hansen , linux-kernel@vger.kernel.org Cc: Alice Ryhl , Andrew Morton , =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOl?= =?UTF-8?Q?g?= , Carlos Llamas , Christian Brauner , David Ahern , "David S. Miller" , Greg Kroah-Hartman , "Liam R. Howlett" , linux-mm@kvack.org, Lorenzo Stoakes , netdev@vger.kernel.org, Shakeel Butt , Suren Baghdasaryan , Todd Kjos References: <20260610230409.A44D29FA@davehans-spike.ostc.intel.com> <20260610230417.77D64DBB@davehans-spike.ostc.intel.com> From: "Vlastimil Babka (SUSE)" Autocrypt: addr=vbabka@kernel.org; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSNWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBrZXJuZWwub3JnPsLBsAQTAQoAWhYhBKlA1DSZLC6OmRA9UCJPp+fM gqZkBQJqFFy6GxSAAAAAAAQADm1hbnUyLDIuNSsxLjEyLDIsMgIbAwUJGtCBUAULCQgHAwUV CgkICwUWAgMBAAIeBQIXgAAKCRAiT6fnzIKmZJIUEADFx/tREzUImHrEwVHeSvDFmA7tJysI UVrlvrM09E7GIuzphzv7jYmo8n3ANpCczLEVr4G0syYQdTigaZgv3+FQDIIzhKih1IHhu1Ei XHlywNWKnQxxQEUNi5Mwx43wQz5XVw9F1A7gtKBKNtfogO511hAbrzagrYajyQacEJ/+sfhZ 9Da8ltHIXD8pcYaHUfQgEusCgmEd9+KrUwrTbckFKmYq5chuE6yJ4J0EmWknL096jIE6CnzF FRslQ3B1UKDjxVsm1ZHfir5NeWszLkTvGFsddFaWTgh8UycESG6VQzKXjjewXu2pG7YQYRpj QKm1W5X2TkwWkXRBZTmfmbhxIUMh3+zf5wQ463rSmDN/8v81tdqBtAW6rH/kzg1GvkaTHXn0 507yEHFzBksk2viAuIxxr7km8+/KARYLIdGtx30EG8cKzAUZOK6WqxtNCsXUJNrVE8CWrCaD icoNu7Fs1c5hmPHdSTnU48ce67449DdnO4neLSNhRiGlMHJgfJUmgrxu/hcYeOZ3haWmEQ2w uW1Mh01OHi8QZHCEyAbABrPs9GUgccc/4eYXX9hIgxfSkYzn8f+8NuIFPWl/0uTvjgqU29FQ SbzOLxHq9439Ox40G5mS5eZXRGxITYR+6TXvRGI6P/264jvflnr/pDGUttaikU+0W+1uxgKH cmYbEc7ATQRbGTU1AQgAn0H6UrFiWcovkh6EXVcl+SeqyO6JHOPm+e9Wu0Vw+VIUvXZVUVVQ La1PQDUi6j00ChlcR66g9/V0sPIcSutacPKfdKYOBvzd4rlhL8rfrdEsQw5ApZxrA8kYZVMh FmBRKAa6wos25moTlMKpCWzTH84+WO5+ziCTsTUZASAToz3RdunTD+vQcHj0GqNTPAHK63sf bAB2I0BslZkXkY1RLb/YhuA6E7JyEd2pilZOrIuBGl/5q2qSakgnAVFWFBR/DO27JuAksYnq +aH8vI0xGvwn75KqSk4UzAkDzWSmO4ZHuahKtQgZNsMYV+PGayRBX9b9zbldzopoLBdqHc4n jQARAQABwsF8BBgBCgAmAhsMFiEEqUDUNJksLo6ZED1QIk+n58yCpmQFAmfIHFQFCRYU6J8A CgkQIk+n58yCpmS2PA//bqN1LfcotmArgElsa+0EGZSQlYgK48pm8WAeTXTngudP9IJ4SuKY HR5RNjHcBeqN+Me0zxRqYzRb8nGanHEkDyf4Im8DQM8d6vbyU+FcPmG4skud4kgS1zMHnlVd SXfSIwKC/hKgdHG8aBV7545Lz9X6Iohea+94wneD0aw/hqF+QWewGZhWJriWAZtvEkzNjQOi 4U9F/trLten/x7bpphDSnDMKJtITbtzATT1Dq7o7VpIUK1nCTQALMuMjKCdi8OdU/+V+R3O4 0PXWvX8qrvqYapVbZ+9KqT74FsuB0Ya9uXwgBF2Q6cRuETZk5vqaqKxzqoQZCO8AOz/58j6O 2RHNy/mZEN+7tJ5Tsq42zVJ4jxsT8b9YplavCMsnBgDeRWhcbYhCyttoL7nYISyWg4kQYZ/P wIV3OuNv2f8iKYsxNsRuClOAF82+gvqOy1/1pprFjy8uo2pkoOrb63aOP3vO5VHnRKgra6dq NcaZ+c6J4H+nEJGi2SkHAUJz5oBzuThvPudLvPA/SK8sKoM01IRxSihev/S/5WLazXB1PGem OCbvzC1IjWJJraxiDJ5IygokapUa2RP7+WBR22skQ3SSl6G107QgWKSyTOGWEaRmV53vxQLV jXuCmzSSasTL60zq5yGrT4/DYQVSNEUiUbG4pYekxJujNeEDkUlky0Y= In-Reply-To: <20260610230417.77D64DBB@davehans-spike.ostc.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 6/11/26 01:04, Dave Hansen wrote: > From: Dave Hansen > > Previously, the per-VMA locking could fail in the face of writers > which necessitate a fallback to mmap_lock. The new > vma_start_read_unlocked() will wait for writers instead of failing. > > Use the new helper. Wait for writers. Remove the fallback to mmap_lock. > > Signed-off-by: Dave Hansen The usage seems fine to me. But since it handles cases where vma is NULL, it seems to support my point for patch 3 that vma_start_read_unlocked() should also allow for and handle vma_lookup() returning NULL. Acked-by: Vlastimil Babka (SUSE) > Acked-by: Lorenzo Stoakes > Reviewed-by: Suren Baghdasaryan > Cc: Andrew Morton > Cc: "Liam R. Howlett" > Cc: Vlastimil Babka > Cc: Shakeel Butt > Cc: linux-mm@kvack.org > Cc: Greg Kroah-Hartman > Cc: Arve Hjønnevåg > Cc: Todd Kjos > Cc: Christian Brauner > Cc: Carlos Llamas > Cc: Alice Ryhl > Cc: "David S. Miller" > Cc: David Ahern > Cc: netdev@vger.kernel.org > > --- > > b/drivers/android/binder_alloc.c | 17 +++++------------ > 1 file changed, 5 insertions(+), 12 deletions(-) > > diff -puN drivers/android/binder_alloc.c~binder-vma-waiter drivers/android/binder_alloc.c > --- a/drivers/android/binder_alloc.c~binder-vma-waiter 2026-06-10 15:57:56.419452721 -0700 > +++ b/drivers/android/binder_alloc.c 2026-06-10 15:57:56.423452863 -0700 > @@ -259,21 +259,14 @@ static int binder_page_insert(struct bin > struct vm_area_struct *vma; > int ret = -ESRCH; > > - /* attempt per-vma lock first */ > - vma = lock_vma_under_rcu(mm, addr); > - if (vma) { > - if (binder_alloc_is_mapped(alloc)) > - ret = vm_insert_page(vma, addr, page); > - vma_end_read(vma); > + vma = vma_start_read_unlocked(mm, addr); > + if (!vma) > return ret; > - } > > - /* fall back to mmap_lock */ > - mmap_read_lock(mm); > - vma = vma_lookup(mm, addr); > - if (vma && binder_alloc_is_mapped(alloc)) > + if (binder_alloc_is_mapped(alloc)) > ret = vm_insert_page(vma, addr, page); > - mmap_read_unlock(mm); > + > + vma_end_read(vma); > > return ret; > } > _