From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFEC3C43381 for ; Sun, 17 Feb 2019 08:10:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AC67721B69 for ; Sun, 17 Feb 2019 08:10:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ndR3GdFo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727144AbfBQIFj (ORCPT ); Sun, 17 Feb 2019 03:05:39 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:55834 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726232AbfBQIFi (ORCPT ); Sun, 17 Feb 2019 03:05:38 -0500 Received: by mail-wm1-f68.google.com with SMTP id q187so1872228wme.5 for ; Sun, 17 Feb 2019 00:05:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=lTAZ9BzYpK3v7jmM/bLuEZcvPMD4fv+XPuQ9AL5BTNU=; b=ndR3GdFodCzHeq/E3WSkD/8i01nB36fthfZ2ZfXFbmmtI9sZoYly/G9cTIG3h/M5Rb AUHCjd72OmPkXGxtF7MikQ0XMJ+yyyMWGwgv7TPU1pG/rTTZEdiBBpAaosnqwmJwQTdb 7KM5qBTEIpJ2HTICj6jonknj4OrZsIg1xCiX7GjhDDDOMNwmRctI1pzOm+MTtr5ob5QL ojMdo5SNUe4jUgDPqn7UD/Nl4F7M/CWo6aqt7C6E3Jt5oV3ZfKa8CBVBw/dE8mTPaL0j HJjSNEQMjzPFWVXfsh/2Vv8W/Sxr+kMtPfOC+U3oaNPru/MeBMTcSakcQBy7Vo7Z95Q+ DoBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=lTAZ9BzYpK3v7jmM/bLuEZcvPMD4fv+XPuQ9AL5BTNU=; b=Mv+CuLm4JXNnofp8onBy7KjF9ZUgD0QpFeQ9CLUqZIIJlBdRlZ4yRnYap9/ycUnNvP qUsa8WQO2Ur5vFbdQ2tu+lYwz+Dgpe9B06pOubs6D1L3SKMfxgcYC4waYIcMLnpwG9WL E6rQAWQ3X5xmdCjgGbyYW6pIb7viZXKJq/TJaP7PPCN44fvVE/OEM4vTUmmA9+WU5g4x 4Zzgk1dSIwCHRxb/avYL81VLsfpP91zqhM7kH64g0dlHJ5F7fXgbmlWLOZ1HvDPbRcxe gRtRw65depWTXJ7qAlwaX5UuflSiWSrvSW1xWyHSbWpSUp63XivUIqY2X1nV3v0aXjYE wDMg== X-Gm-Message-State: AHQUAuZ8syhftJsLtd73I/aP2EWwpXvKeZcge1wCLzEFI1TJKH5yjhlB Ei+6DuTJPszqkL/xa2ba5tBd63FA X-Google-Smtp-Source: AHgI3Ia1vm3GU4zgeJEaphbNr0JA9UUwOYfeOTOijC81oReCYIbNcY9E+F2n9FLfuEYYLSFIl7zDYw== X-Received: by 2002:a1c:b70b:: with SMTP id h11mr12379712wmf.72.1550390736097; Sun, 17 Feb 2019 00:05:36 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:4c36:c930:69b6:c10f? (p200300EA8BF1E2004C36C93069B6C10F.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:4c36:c930:69b6:c10f]) by smtp.googlemail.com with ESMTPSA id j15sm6100283wrt.1.2019.02.17.00.05.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 17 Feb 2019 00:05:35 -0800 (PST) Subject: Re: [PATCH net-next v2 1/2] net: phy: add helper mii_10gbt_stat_mod_linkmode_lpa_t To: Florian Fainelli , Andrew Lunn , David Miller Cc: "netdev@vger.kernel.org" References: From: Heiner Kallweit Message-ID: <81cc00ad-a07a-bd8d-f1f8-eebd4c222569@gmail.com> Date: Sun, 17 Feb 2019 09:02:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 17.02.2019 03:35, Florian Fainelli wrote: > > > On 2/16/2019 8:26 AM, Heiner Kallweit wrote: >> Similar to the existing helpers for the Clause 22 registers add helper >> mii_10gbt_stat_mod_linkmode_lpa_t. >> >> Note that this helper is defined in linux/mdio.h, not like the >> Clause 22 helpers in linux/mii.h. Reason is that the Clause 45 register >> constants are defined in uapi/linux/mdio.h. And uapi/linux/mdio.h >> includes linux/mii.h before defining the C45 register constants. > > Nit: this also processes 2.5G and 5G but I can't suggest a better name, > so this is as good as any. > I also thought about this and eventually decided to go with the register name from the Clause 45 (2015) spec. Not sure whether there's a newer version, but even if I (after 802.3bz was established) doubt that they would rename a register. >> >> v2: >> - remove helpers that don't have users in this series >> >> Signed-off-by: Heiner Kallweit > > Reviewed-by: Florian Fainelli >