From: Florian Fainelli <f.fainelli@gmail.com>
To: Tobias Waldekranz <tobias@waldekranz.com>,
davem@davemloft.net, kuba@kernel.org
Cc: andrew@lunn.ch, vivien.didelot@gmail.com, olteanv@gmail.com,
netdev@vger.kernel.org, robh+dt@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 net-next 1/5] net: dsa: mv88e6xxx: Mark chips with undocumented EDSA tag support
Date: Thu, 15 Apr 2021 09:12:03 -0700 [thread overview]
Message-ID: <81d2b72d-7d77-c668-9102-c0d19be54d74@gmail.com> (raw)
In-Reply-To: <20210415092610.953134-2-tobias@waldekranz.com>
On 4/15/2021 2:26 AM, Tobias Waldekranz wrote:
> All devices are capable of using regular DSA tags. Support for
> Ethertyped DSA tags sort into three categories:
>
> 1. No support. Older chips fall into this category.
>
> 2. Full support. Datasheet explicitly supports configuring the CPU
> port to receive FORWARDs with a DSA tag.
>
> 3. Undocumented support. Datasheet lists the configuration from
> category 2 as "reserved for future use", but does empirically
> behave like a category 2 device.
>
> So, instead of listing the one true protocol that should be used by a
> particular chip, specify the level of support for EDSA (support for
> regular DSA is implicit on all chips). As before, we use EDSA for all
> chips that fully supports it.
>
> In upcoming changes, we will use this information to support
> dynamically changing the tag protocol.
>
> Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2021-04-15 16:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 9:26 [PATCH v2 net-next 0/5] net: dsa: Allow default tag protocol to be overridden from DT Tobias Waldekranz
2021-04-15 9:26 ` [PATCH v2 net-next 1/5] net: dsa: mv88e6xxx: Mark chips with undocumented EDSA tag support Tobias Waldekranz
2021-04-15 16:04 ` Vladimir Oltean
2021-04-15 16:12 ` Florian Fainelli [this message]
2021-04-15 9:26 ` [PATCH v2 net-next 2/5] net: dsa: mv88e6xxx: Allow dynamic reconfiguration of tag protocol Tobias Waldekranz
2021-04-15 16:06 ` Vladimir Oltean
2021-04-15 16:12 ` Florian Fainelli
2021-04-15 9:26 ` [PATCH v2 net-next 3/5] net: dsa: Only notify CPU ports of changes to the " Tobias Waldekranz
2021-04-15 16:07 ` Vladimir Oltean
2021-04-15 16:36 ` Florian Fainelli
2021-04-15 9:26 ` [PATCH v2 net-next 4/5] net: dsa: Allow default tag protocol to be overridden from DT Tobias Waldekranz
2021-04-15 16:54 ` Vladimir Oltean
2021-04-15 9:26 ` [PATCH v2 net-next 5/5] dt-bindings: net: dsa: Document dsa,tag-protocol property Tobias Waldekranz
2021-04-15 21:27 ` Rob Herring
2021-04-19 18:55 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81d2b72d-7d77-c668-9102-c0d19be54d74@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tobias@waldekranz.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).