From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40B1FC001B2 for ; Thu, 22 Dec 2022 14:31:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235736AbiLVObK (ORCPT ); Thu, 22 Dec 2022 09:31:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235694AbiLVObG (ORCPT ); Thu, 22 Dec 2022 09:31:06 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CDDC2A257 for ; Thu, 22 Dec 2022 06:30:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671719415; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Yo59GqjO245jjbdybBDkZsJXQxnZlKsA5iXDQYeufjY=; b=YZ+bHPq/YOo7qxSL9wadozo+2anZtAkFay/9kYPbpEHUpKyrBGW1GVDfTOaGeMYO+z6zy1 JzBvG5dA5cjd321dWElnlHwL0tfJj4GiU1oyhqVhHejJjK8ndloOqhtT99zDHbOxKyH4Jp z2zQK457Hq/55T1QRpgtSbN0k4kfXYE= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-296-QcegOZNYMDayHFYGDtYd2Q-1; Thu, 22 Dec 2022 09:30:14 -0500 X-MC-Unique: QcegOZNYMDayHFYGDtYd2Q-1 Received: by mail-qk1-f200.google.com with SMTP id l16-20020a05620a28d000b00704af700820so1285469qkp.5 for ; Thu, 22 Dec 2022 06:30:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Yo59GqjO245jjbdybBDkZsJXQxnZlKsA5iXDQYeufjY=; b=ywUeeMf52MT8DPfQqsK9ZMcadh0Ivb6BwlKJ83/QY0trROB5f+KlLy9gtWG6CV7ZzX aJ4/y7thV/8Za0CmpuMet+1CV7J364+LVcYnrOK0T9/Jhy8J82F9q8+B8bYfnxs2bHMg 4D0TaNRmYFA4rwrtX2nfeVEIPa3JmR7C0KQ4d2DIhY9YaY36Hqi+w917FFdyzLoMwl7I 9W8sB8GSv4wyS0nJF92KpMwghf7SldRt3Dh9gcI2ymV5y4yIqSIwh32bFHxzQj/F2O2e OU59ZT0++fO8dBjf2zWWF/rLdwTNw7t7XFPY7/5F6j+wQdi52YgqNJPa/H9IeN7bKqs6 8avA== X-Gm-Message-State: AFqh2kqmWK3sk/dVTVLGQ42TRkxQNyXb9Kqdn0M1EKISELHbfCEiWgrs K3r/WqxuGjOloOJe1R41AXknjG0wkK3M0soDpJO2CEVBQSPmWqQXQsl6kh9GSDK4YNRQyNvR749 BsPnXQwXh6YG3y0lZ X-Received: by 2002:ad4:4a0d:0:b0:4c7:595c:9940 with SMTP id m13-20020ad44a0d000000b004c7595c9940mr6960720qvz.51.1671719414000; Thu, 22 Dec 2022 06:30:14 -0800 (PST) X-Google-Smtp-Source: AMrXdXvPyViPBixvVZNakCJM3/xzQlf8XOkmUa8FdRqwh6A4H0LYpabXnVu13PwfDTm3dHMOSlzzHA== X-Received: by 2002:ad4:4a0d:0:b0:4c7:595c:9940 with SMTP id m13-20020ad44a0d000000b004c7595c9940mr6960699qvz.51.1671719413783; Thu, 22 Dec 2022 06:30:13 -0800 (PST) Received: from gerbillo.redhat.com (146-241-101-173.dyn.eolo.it. [146.241.101.173]) by smtp.gmail.com with ESMTPSA id u9-20020a05620a430900b006fba44843a5sm389389qko.52.2022.12.22.06.30.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Dec 2022 06:30:13 -0800 (PST) Message-ID: <81f4b4347be5fa9c0b7a87905e979183aed35acf.camel@redhat.com> Subject: Re: [PATCH] veth: Fix race with AF_XDP exposing old or uninitialized descriptors From: Paolo Abeni To: Jakub Kicinski , Shawn Bohrer Cc: magnus.karlsson@gmail.com, netdev@vger.kernel.org, bpf@vger.kernel.org, bjorn@kernel.org, kernel-team@cloudflare.com, davem@davemloft.net Date: Thu, 22 Dec 2022 15:30:09 +0100 In-Reply-To: <20221221170700.32e5ddc6@kernel.org> References: <20221220185903.1105011-1-sbohrer@cloudflare.com> <20221221170700.32e5ddc6@kernel.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 2022-12-21 at 17:07 -0800, Jakub Kicinski wrote: > On Tue, 20 Dec 2022 12:59:03 -0600 Shawn Bohrer wrote: > > if (stats.xdp_tx > 0) > > veth_xdp_flush(rq, &bq); > > This one does not need similar treatment, right? > Only thing I could spot is potential races in updating stats, > but that seems like a larger issue with veth xdp. Agreed, I think stats would deserve a separate patch (and this one looks correct). Cheers, Paolo