From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Simon Horman <horms@kernel.org>
Cc: <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
Alan Brady <alan.brady@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH iwl-next v1 1/2] igb: simplify pci ops declaration
Date: Tue, 20 Feb 2024 08:48:28 -0800 [thread overview]
Message-ID: <823fdfe2-7c8c-4440-bc6a-3896c542f0e4@intel.com> (raw)
In-Reply-To: <20240219091542.GS40273@kernel.org>
On 2/19/2024 1:15 AM, Simon Horman wrote:
> On Sat, Feb 10, 2024 at 02:01:08PM -0800, Jesse Brandeburg wrote:
>> The igb driver was pre-declaring tons of functions just so that it could
>> have an early declaration of the pci_driver struct.
>>
>> Delete a bunch of the declarations and move the struct to the bottom of the
>> file, after all the functions are declared.
>>
>> Reviewed-by: Alan Brady <alan.brady@intel.com>
>> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
>> - .probe = igb_probe,
>> - .remove = igb_remove,
>> -#ifdef CONFIG_PM
>> - .driver.pm = &igb_pm_ops,
>> -#endif
>> - .shutdown = igb_shutdown,
>> + .probe = igb_probe,
>> + .remove = igb_remove,
>> + .driver.pm = &igb_pm_ops,
>
> Hi Jesse,
>
> the line above causes a build failure if CONFIG_PM is not set.
Hi Simon, thanks!
Yeah I missed that, but do we care since patch 2/2 then fixes it?
next prev parent reply other threads:[~2024-02-20 16:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-10 22:01 [PATCH iwl-next v1 0/2] net: intel: cleanup power ops Jesse Brandeburg
2024-02-10 22:01 ` [PATCH iwl-next v1 1/2] igb: simplify pci ops declaration Jesse Brandeburg
2024-02-14 10:32 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2024-02-19 9:15 ` Simon Horman
2024-02-20 16:48 ` Jesse Brandeburg [this message]
2024-02-21 10:35 ` Simon Horman
2024-02-21 11:02 ` [Intel-wired-lan] " Paul Menzel
2024-02-10 22:01 ` [PATCH iwl-next v1 2/2] net: intel: implement modern PM ops declarations Jesse Brandeburg
2024-02-14 10:37 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2024-02-19 9:22 ` Simon Horman
2024-02-22 13:05 ` [Intel-wired-lan] " Romanowski, Rafal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=823fdfe2-7c8c-4440-bc6a-3896c542f0e4@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=alan.brady@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).