Netdev List
 help / color / mirror / Atom feed
From: "imagedong(董梦龙)" <imagedong@tencent.com>
To: Eric Dumazet <edumazet@google.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ian Rogers <irogers@google.com>
Cc: "Menglong Dong" <menglong8.dong@gmail.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"David Miller" <davem@davemloft.net>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Ingo Molnar" <mingo@redhat.com>,
	"David Ahern" <dsahern@kernel.org>,
	"flyingpeng(彭浩)" <flyingpeng@tencent.com>,
	"Dongli Zhang" <dongli.zhang@oracle.com>,
	"robh@kernel.org" <robh@kernel.org>,
	"Pavel Begunkov" <asml.silence@gmail.com>,
	"Luiz Augusto von Dentz" <luiz.von.dentz@intel.com>,
	"Vasily Averin" <vasily.averin@linux.dev>,
	LKML <linux-kernel@vger.kernel.org>,
	netdev <netdev@vger.kernel.org>
Subject: Re: [Internet]Re: [PATCH net-next v2] net: skb: export skb drop reaons to user by TRACE_DEFINE_ENUM
Date: Fri, 28 Oct 2022 02:26:02 +0000	[thread overview]
Message-ID: <82699D69-00C8-4C0B-BEA2-32284EB63B63@tencent.com> (raw)
In-Reply-To: <CANn89iL7EvdBhZGtxDOATeznLUwVaFm2gf4XCYeMPXE5CR=BTw@mail.gmail.com>

> On 2022/10/28 00:29,“Eric Dumazet”<edumazet@google.com> write:
> 
> On Thu, Oct 27, 2022 at 8:43 AM Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > On Thu, 27 Oct 2022 08:32:02 -0700
> > Eric Dumazet <edumazet@google.com> wrote:
> >
> > > This seems broken again (tried on latest net-next tree)
> > >
> > > perf script
> >
> > Do you also have the latest perf and the latest libtraceevent installed?
> >
> 
> I tried a more recent perf binary we have, but it is also not right.
> 
> I guess I will have to request a new perf binary at Google :/
> 

Ennn...I just have a try, and it seems fine:

sudo perf script
         swapper     0 [049] 401460.138078: skb:kfree_skb: skbaddr=0xffff8881076d2400 protocol=2048 location=0xffffffff81d86546 reason: TCP_INVALID_SEQUENCE
              nc 429418 [006] 401465.652282: skb:kfree_skb: skbaddr=0xffff8881ea66cf00 protocol=0 location=0xffffffff81e0b48f reason: NOT_SPECIFIED
              nc 429418 [006] 401465.652293: skb:kfree_skb: skbaddr=0xffff8881ea66cf00 protocol=0 location=0xffffffff81e0b48f reason: NOT_SPECIFIED
              nc 429418 [006] 401465.652538: skb:kfree_skb: skbaddr=0xffff888133c014e8 protocol=2048 location=0xffffffff81d983a1 reason: NO_SOCKET

The version of the perf I used is 6.0.3-1:

  sudo apt info linux-perf
  Package: linux-perf
  Version: 6.0.3-1


Thanks!
Menglong Dong

> perf5 script
>          swapper     0 [030]  4147.704606: skb:kfree_skb: [UNKNOWN EVENT]
>  kworker/30:1-ev   308 [030]  4147.704615: skb:kfree_skb: [UNKNOWN EVENT]
>          swapper     0 [030]  4148.048173: skb:kfree_skb: [UNKNOWN EVENT]
>  kworker/30:1-ev   308 [030]  4148.048179: skb:kfree_skb: [UNKNOWN EVENT]
>          swapper     0 [008]  4148.048773: skb:kfree_skb: [UNKNOWN EVENT]
>          swapper     0 [030]  4148.112271: skb:kfree_skb: [UNKNOWN EVENT]
>  kworker/30:1-ev   308 [030]  4148.112280: skb:kfree_skb: [UNKNOWN EVENT]
>          swapper     0 [030]  4148.720149: skb:kfree_skb: [UNKNOWN EVENT]
>  kworker/30:1-ev   308 [030]  4148.720155: skb:kfree_skb: [UNKNOWN EVENT]
>          swapper     0 [030]  4149.072141: skb:kfree_skb: [UNKNOWN EVENT]
>  kworker/30:1-ev   308 [030]  4149.072149: skb:kfree_skb: [UNKNOWN EVENT]


      parent reply	other threads:[~2022-10-28  2:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-02 14:17 [PATCH net-next v2] net: skb: export skb drop reaons to user by TRACE_DEFINE_ENUM menglong8.dong
2022-09-02 15:43 ` Eric Dumazet
2022-09-04  4:34   ` Menglong Dong
2022-09-05 14:38   ` Steven Rostedt
2022-10-27 15:32     ` Eric Dumazet
2022-10-27 15:44       ` Steven Rostedt
2022-10-27 16:28         ` Eric Dumazet
2022-10-27 16:38           ` Steven Rostedt
2022-10-28  2:26           ` imagedong(董梦龙) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82699D69-00C8-4C0B-BEA2-32284EB63B63@tencent.com \
    --to=imagedong@tencent.com \
    --cc=asml.silence@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dongli.zhang@oracle.com \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=flyingpeng@tencent.com \
    --cc=irogers@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luiz.von.dentz@intel.com \
    --cc=menglong8.dong@gmail.com \
    --cc=mingo@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=vasily.averin@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox