From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D406F383B1; Wed, 11 Sep 2024 16:58:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726073886; cv=none; b=K6EAhrsSYDLDzmYB8ySOiQhkcuZPm46MWYPJ0a/2BKYBhyR3U1Lu2SfkK9ZURHeqgvLj8SY3OO2bkDG0aSDun5npiVFDg8O/C0hiI34ad1xJhbgMgzh5EGvv8HPUvqzF8kbjf5cMoZWRVSpCLBn6nzWanQ43r6G0Dj/NuIwpehU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726073886; c=relaxed/simple; bh=3BA8CII8ozvN36TheCpKcb00djcu5pWrM/ZNnb/B0BM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hK+l7xM5T1twLIlz+J/2KApzOvFhgXAgZmxJCozCeFU9ucftoKxSMO+GStN7aCssay2iwnB2IKjBvQVodT44sCCKM6k7W68PpqJ/AD4fHOYx64m7QAqh2Xdb/pyED7LyNKGg1xsBNoqRHZrcAq6zvmJkQH0OPyNlfz7gB/uYhe8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=aF9/SEtZ; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="aF9/SEtZ" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=W+/LEUKP/xtU0+T0eqY7BQH8KV8T8pZ4KeigsgrDIe0=; b=aF9/SEtZbC2PG/Or6pQLM1bOVU GLwMtrQa/QuDn8ca5V1YXoWiAo3XyGh+DYx2EPquErO/VGpRNIDARLGc7UECApwVz6+or8zu7VPzW NafaE5bU00njOZDHbm4TSDs6ZTjyAl1D7smaxafG85rMw043wmGjc6YFWvbHNB8K4BkE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1soQf5-007Eag-UR; Wed, 11 Sep 2024 18:57:47 +0200 Date: Wed, 11 Sep 2024 18:57:47 +0200 From: Andrew Lunn To: Lorenzo Stoakes Cc: Hans de Goede , Andrew Morton , Richard Narron , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman , Marcin Wojtas , Russell King , "David S . Miller" , Arnd Bergmann , Linus Torvalds , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-mm@kvack.org, stable@vger.kernel.org Subject: Re: [PATCH hotfix 6.11] minmax: reduce egregious min/max macro expansion Message-ID: <827b2d90-d23f-41c8-8e72-ecd5ca9ee534@lunn.ch> References: <20240911153457.1005227-1-lorenzo.stoakes@oracle.com> <181dec64-5906-4cdd-bb29-40bc7c02d63e@redhat.com> <3f622e05-9843-4763-9191-c980feb831d2@lucifer.local> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3f622e05-9843-4763-9191-c980feb831d2@lucifer.local> > > I think that you can then also replace clamp_t() with clamp() > > The use of clamp_t() is to avoid egregious macro expansion in > clamp(). After the series improving min/max the clamp() is probably > equivalent. But in 5.15 it will likely not be. So this is, in line with the > purpose of this change, I believe necesasry. Maybe that should be in the commit message? Andrew