From: "Arnd Bergmann" <arnd@arndb.de>
To: "Arthur Crépin Leblond" <arthur@marmottus.net>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>
Cc: Netdev <netdev@vger.kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] w5100: restore GPIO-based link detection
Date: Tue, 04 Aug 2026 20:44:16 +0200 [thread overview]
Message-ID: <8295f924-1b74-4a10-b9e2-47f70df02938@app.fastmail.com> (raw)
In-Reply-To: <20260804-wiznet-link-gpio-v2-1-3b1d0c870f35@marmottus.net>
On Tue, Aug 4, 2026, at 19:40, Arthur Crépin Leblond wrote:
> Commit dacf281771a9 ("w5100: remove unused gpio link detection")
> dropped the link_gpio/link_irq handling on the grounds that no
> devicetree user passed a "link" GPIO at the time.
>
> This isn't a plain revert of that removal. The link GPIO is now
> bound from the device tree link-gpios property using the resource
> managed GPIO descriptors.
>
> The link IRQ is also requested with devm_request_threaded_irq()
> instead of request_any_context_irq(), so it is released automatically
> on driver removal or probe failure.
>
> Signed-off-by: Arthur Crépin Leblond <arthur@marmottus.net>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2026-08-04 18:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 17:40 [PATCH v2 0/2] w5100: restore GPIO-based link detection Arthur Crépin Leblond
2026-08-04 17:40 ` [PATCH v2 1/2] " Arthur Crépin Leblond
2026-08-04 18:44 ` Arnd Bergmann [this message]
2026-08-04 20:58 ` Jakub Kicinski
2026-08-05 7:56 ` Arnd Bergmann
2026-08-04 17:40 ` [PATCH v2 2/2] dt-bindings: net: convert wiznet,w5x00 to YAML Arthur Crépin Leblond
2026-08-04 18:49 ` Rob Herring (Arm)
2026-08-05 11:08 ` Krzysztof Kozlowski
2026-08-05 17:23 ` Arthur Crépin Leblond
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8295f924-1b74-4a10-b9e2-47f70df02938@app.fastmail.com \
--to=arnd@arndb.de \
--cc=andrew+netdev@lunn.ch \
--cc=arthur@marmottus.net \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox