From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87FDCC433B4 for ; Thu, 20 May 2021 09:47:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 682256145E for ; Thu, 20 May 2021 09:47:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234172AbhETJso (ORCPT ); Thu, 20 May 2021 05:48:44 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:4768 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233833AbhETJqj (ORCPT ); Thu, 20 May 2021 05:46:39 -0400 Received: from dggems701-chm.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4Fm4WY03tVzqVFT; Thu, 20 May 2021 17:41:45 +0800 (CST) Received: from dggpemm500005.china.huawei.com (7.185.36.74) by dggems701-chm.china.huawei.com (10.3.19.178) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 20 May 2021 17:45:15 +0800 Received: from [127.0.0.1] (10.69.30.204) by dggpemm500005.china.huawei.com (7.185.36.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Thu, 20 May 2021 17:45:15 +0800 Subject: Re: [Linuxarm] [PATCH RFC v4 0/3] Some optimization for lockless qdisc From: Yunsheng Lin To: , , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , References: <1621502873-62720-1-git-send-email-linyunsheng@huawei.com> Message-ID: <829cc4c1-46cc-c96c-47ba-438ae3534b94@huawei.com> Date: Thu, 20 May 2021 17:45:14 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <1621502873-62720-1-git-send-email-linyunsheng@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.69.30.204] X-ClientProxiedBy: dggeme717-chm.china.huawei.com (10.1.199.113) To dggpemm500005.china.huawei.com (7.185.36.74) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2021/5/20 17:27, Yunsheng Lin wrote: > Patch 1: remove unnecessary seqcount operation. > Patch 2: implement TCQ_F_CAN_BYPASS. > Patch 3: remove qdisc->empty. > > RFC v4: Use STATE_MISSED and STATE_DRAINING to indicate non-empty > qdisc, and add patch 1 and 3. @Vladimir, Ahmad It would be good to run your testcase to see if there are any out of order for this version, because this version has used STATE_MISSED and STATE_DRAINING to indicate non-empty qdisc, thanks. It is based on newest net branch with qdisc stuck patchset. Some performance data as below: pktgen + dummy netdev: threads without+this_patch with+this_patch delta 1 2.60Mpps 3.18Mpps +22% 2 3.84Mpps 5.72Mpps +48% 4 5.52Mpps 5.52Mpps +0.0% 8 2.77Mpps 2.81Mpps +1.4% 16 2.24Mpps 2.29Mpps +2.2% IP forward testing: 1.05Mpps increases to 1.15Mpps > > Yunsheng Lin (3): > net: sched: avoid unnecessary seqcount operation for lockless qdisc > net: sched: implement TCQ_F_CAN_BYPASS for lockless qdisc > net: sched: remove qdisc->empty for lockless qdisc > > include/net/sch_generic.h | 26 +++++++++++++------------- > net/core/dev.c | 22 ++++++++++++++++++++-- > net/sched/sch_generic.c | 23 ++++++++++++++++------- > 3 files changed, 49 insertions(+), 22 deletions(-) >