From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58CD2D530 for ; Wed, 5 Mar 2025 00:19:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741133991; cv=none; b=W+B3Qb2mbyzBHFweCTviISyJcNpT//jDtygXs1QR/+VSfNat1feZgFFJACREB5tUls7uNhs3sGo1aTIAT7k4C+PYfWJUx4d056+vdWskrSNoE110quAi4h4WV6xw9fH3+iLNdN0HtDrS3gZ+n7tu+0rfZZ6BPl7HluUg31zPxpM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741133991; c=relaxed/simple; bh=ZK68s+96odAp9mghpE9eTFA98cGvGR3nuInRJl6fJPM=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=V/oFfU+cp8YJ3/REScKdAxvTt83iRwIuxYtskkPXtttrDjuEfXQutBLAOe7pqZgK3fN7KJ+eziSXlukl3E8Nkle6JqXEt5DTLYPNYceXyuSlT+5OPo9bqKLGqTlUxeqUAFrtN6KEGdn7nUlyjDqV1uy2baS+aD1Ki2cFwZt1mBc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=openvpn.net; spf=pass smtp.mailfrom=openvpn.com; dkim=pass (2048-bit key) header.d=openvpn.net header.i=@openvpn.net header.b=KDKq6ARw; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=openvpn.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=openvpn.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=openvpn.net header.i=@openvpn.net header.b="KDKq6ARw" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-5e549af4927so4786963a12.2 for ; Tue, 04 Mar 2025 16:19:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1741133987; x=1741738787; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=6D4CeO3v05+ZBtc5CEcrGKWIhNna/EuPVsXiAB6x+mw=; b=KDKq6ARw53HPLVILzGlRUebxTCAbzMQ9Owvkc33Smwfmk6U+evXkvQTWY8zGBFNpCb l60YZokhss/Y0jrPpjaEDHY6LjXbdYNeQGq5XzvvgLLiNH1VTiWpEeubEBx45a6sNukm YNvhPn97d3GwbLa+TLTqMYPB/ahiXIqbLSEsnVTWi0NIbbrAssO+LUeQ3ltopNlDypz4 pqpsT2fdG/c+1VhtHGLWJtWcCJvY407coN2RIBqatmyFqv6eDdzsqpfRA4LFtocAmsbw qH757tCFzP6W2GIfV1y68ALbVMU/h0rHLWmMGTMxpMG6cxnwAKVQJLaEOup1VLXM6Upy U+IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741133987; x=1741738787; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=6D4CeO3v05+ZBtc5CEcrGKWIhNna/EuPVsXiAB6x+mw=; b=mvL21S59pDU3oNbNRoKz5Mfk0r0QALOWep8OpOUDZUwwf+8aAllOQ4zi2tFr6xoSRL 0n61PYc/EbiSZlj4mhHzDLcoJ0ueA6fYYgIHIBF64I8/03RE9DEWtnmRSPGAOFmnmRNd ZhGB9pMGAxrEvOeywTL1Ktpw9wzGG72wuacvJ2THBWJGW4jNL8ClC8G08SJFixFWxO/0 YN9e2L6MBkL5OwVUxlXj74lF/xIdrPUtioztgwPJCWACIR+vSfGl9XbZTZFP75ujtrg8 0dFwIv8PlSo7PK9VZKO2gWCd+Rn8x9zRqeffH0o3j3okzZaMFRl+yJM31DG7BhTnCzSU 2EGg== X-Gm-Message-State: AOJu0Yxm3ry2ivYJuOh++wXxElaRpZKRqDb3J9r+K0fND7omA9dNj3Oo S2Tbouw35tVavUvR+CwSuSjJ7MYy9llRexzDBqEt0zOe+JHau56hZLGsnwFt+ui95uPJWHDYWwV i X-Gm-Gg: ASbGncsoJurHvnBnY7kT/xo+zjYlFJ7MFSfQve5VT2SsEwI+/zeBg2Qj6yp0ouJ9QgH cIPk1dcryJ9eFLOBaxBjglK89Aabs31mS1DVaCcYHVJqQihz6k7wOfL9NphF9Yzuei536B6t4SA Hjmg8cjmv3MqEU3AIb/TdoyE44W9AxIWxbtwwG6+OjvzUQY62FQR2FWFoVStt0yisJuQeBVC7cQ PEoXdxJ+tEvhMrMgZdoM3EUZXxOkT31QP6JeKPfmBy8GTM7pXFQWOhZ/Zeai/p7A9NXDq9iP6tx QRArsKW1JKcxhDueScpFaC1ki5/D83GZuO46aZJt6ZTKt8YVOXzgCPB78sES5LUsCynGWQ6m9zC cZptWgvY= X-Google-Smtp-Source: AGHT+IGUKpII5ucG6P2P0Im4u16sx6ubJmJfDIB+rxJ8m//Mn7nLKISpOLu5ZLftwyo3mtLq9b8Kug== X-Received: by 2002:a05:6402:5203:b0:5e1:9725:bb3e with SMTP id 4fb4d7f45d1cf-5e59f4869femr1173648a12.28.1741133987449; Tue, 04 Mar 2025 16:19:47 -0800 (PST) Received: from ?IPV6:2001:67c:2fbc:1:2107:3d4f:958a:fa5f? ([2001:67c:2fbc:1:2107:3d4f:958a:fa5f]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e50fcfe981sm6051928a12.27.2025.03.04.16.19.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Mar 2025 16:19:45 -0800 (PST) Message-ID: <82aa82df-e378-4cf8-a296-1ebd1ab14413@openvpn.net> Date: Wed, 5 Mar 2025 01:19:43 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v21 18/24] ovpn: add support for peer floating From: Antonio Quartulli To: Sabrina Dubroca Cc: netdev@vger.kernel.org, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Donald Hunter , Shuah Khan , ryazanov.s.a@gmail.com, Andrew Lunn , Simon Horman , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Xiao Liang References: <20250304-b4-ovpn-tmp-v21-0-d3cbb74bb581@openvpn.net> <20250304-b4-ovpn-tmp-v21-18-d3cbb74bb581@openvpn.net> <9c919407-fb91-48d7-bf2d-8437c2f3f4da@openvpn.net> Content-Language: en-US Autocrypt: addr=antonio@openvpn.net; keydata= xsFNBFN3k+ABEADEvXdJZVUfqxGOKByfkExNpKzFzAwHYjhOb3MTlzSLlVKLRIHxe/Etj13I X6tcViNYiIiJxmeHAH7FUj/yAISW56lynAEt7OdkGpZf3HGXRQz1Xi0PWuUINa4QW+ipaKmv voR4b1wZQ9cZ787KLmu10VF1duHW/IewDx9GUQIzChqQVI3lSHRCo90Z/NQ75ZL/rbR3UHB+ EWLIh8Lz1cdE47VaVyX6f0yr3Itx0ZuyIWPrctlHwV5bUdA4JnyY3QvJh4yJPYh9I69HZWsj qplU2WxEfM6+OlaM9iKOUhVxjpkFXheD57EGdVkuG0YhizVF4p9MKGB42D70pfS3EiYdTaKf WzbiFUunOHLJ4hyAi75d4ugxU02DsUjw/0t0kfHtj2V0x1169Hp/NTW1jkqgPWtIsjn+dkde dG9mXk5QrvbpihgpcmNbtloSdkRZ02lsxkUzpG8U64X8WK6LuRz7BZ7p5t/WzaR/hCdOiQCG RNup2UTNDrZpWxpwadXMnJsyJcVX4BAKaWGsm5IQyXXBUdguHVa7To/JIBlhjlKackKWoBnI Ojl8VQhVLcD551iJ61w4aQH6bHxdTjz65MT2OrW/mFZbtIwWSeif6axrYpVCyERIDEKrX5AV rOmGEaUGsCd16FueoaM2Hf96BH3SI3/q2w+g058RedLOZVZtyQARAQABzSdBbnRvbmlvIFF1 YXJ0dWxsaSA8YW50b25pb0BvcGVudnBuLm5ldD7Cwa0EEwEIAFcCGwMFCwkIBwMFFQoJCAsF FgIDAQACHgECF4AFCRWQ2TIWIQTKvaEoIBfCZyGYhcdI8My2j1nRTAUCYRUquBgYaGtwczov L2tleXMub3BlbnBncC5vcmcACgkQSPDMto9Z0UzmcxAAjzLeD47We0R4A/14oDKlZxXO0mKL fCzaWFsdhQCDhZkgxoHkYRektK2cEOh4Vd+CnfDcPs/iZ1i2+Zl+va79s4fcUhRReuwi7VCg 7nHiYSNC7qZo84Wzjz3RoGYyJ6MKLRn3zqAxUtFECoS074/JX1sLG0Z3hi19MBmJ/teM84GY IbSvRwZu+VkJgIvZonFZjbwF7XyoSIiEJWQC+AKvwtEBNoVOMuH0tZsgqcgMqGs6lLn66RK4 tMV1aNeX6R+dGSiu11i+9pm7sw8tAmsfu3kQpyk4SB3AJ0jtXrQRESFa1+iemJtt+RaSE5LK 5sGLAO+oN+DlE0mRNDQowS6q/GBhPCjjbTMcMfRoWPCpHZZfKpv5iefXnZ/xVj7ugYdV2T7z r6VL2BRPNvvkgbLZgIlkWyfxRnGh683h4vTqRqTb1wka5pmyBNAv7vCgqrwfvaV1m7J9O4B5 PuRjYRelmCygQBTXFeJAVJvuh2efFknMh41R01PP2ulXAQuVYEztq3t3Ycw6+HeqjbeqTF8C DboqYeIM18HgkOqRrn3VuwnKFNdzyBmgYh/zZx/dJ3yWQi/kfhR6TawAwz6GdbQGiu5fsx5t u14WBxmzNf9tXK7hnXcI24Z1z6e5jG6U2Swtmi8sGSh6fqV4dBKmhobEoS7Xl496JN2NKuaX jeWsF2rOwE0EZmhJFwEIAOAWiIj1EYkbikxXSSP3AazkI+Y/ICzdFDmiXXrYnf/mYEzORB0K vqNRQOdLyjbLKPQwSjYEt1uqwKaD1LRLbA7FpktAShDK4yIljkxhvDI8semfQ5WE/1Jj/I/Q U+4VXhkd6UvvpyQt/LiWvyAfvExPEvhiMnsg2zkQbBQ/M4Ns7ck0zQ4BTAVzW/GqoT2z03mg p1FhxkfzHMKPQ6ImEpuY5cZTQwrBUgWif6HzCtQJL7Ipa2fFnDaIHQeiJG0RXl/g9x3YlwWG sxOFrpWWsh6GI0Mo2W2nkinEIts48+wNDBCMcMlOaMYpyAI7fT5ziDuG2CBA060ZT7qqdl6b aXUAEQEAAcLBfAQYAQgAJhYhBMq9oSggF8JnIZiFx0jwzLaPWdFMBQJmaEkXAhsMBQkB4TOA AAoJEEjwzLaPWdFMbRUP/0t5FrjF8KY6uCU4Tx029NYKDN9zJr0CVwSGsNfC8WWonKs66QE1 pd6xBVoBzu5InFRWa2ed6d6vBw2BaJHC0aMg3iwwBbEgPn4Jx89QfczFMJvFm+MNc2DLDrqN zaQSqBzQ5SvUjxh8lQ+iqAhi0MPv4e2YbXD0ROyO+ITRgQVZBVXoPm4IJGYWgmVmxP34oUQh BM7ipfCVbcOFU5OPhd9/jn1BCHzir+/i0fY2Z/aexMYHwXUMha/itvsBHGcIEYKk7PL9FEfs wlbq+vWoCtUTUc0AjDgB76AcUVxxJtxxpyvES9aFxWD7Qc+dnGJnfxVJI0zbN2b37fX138Bf 27NuKpokv0sBnNEtsD7TY4gBz4QhvRNSBli0E5bGUbkM31rh4Iz21Qk0cCwR9D/vwQVsgPvG ioRqhvFWtLsEt/xKolOmUWA/jP0p8wnQ+3jY6a/DJ+o5LnVFzFqbK3fSojKbfr3bY33iZTSj DX9A4BcohRyqhnpNYyHL36gaOnNnOc+uXFCdoQkI531hXjzIsVs2OlfRufuDrWwAv+em2uOT BnRX9nFx9kPSO42TkFK55Dr5EDeBO3v33recscuB8VVN5xvh0GV57Qre+9sJrEq7Es9W609a +M0yRJWJEjFnMa/jsGZ+QyLD5QTL6SGuZ9gKI3W1SfFZOzV7hHsxPTZ6 Organization: OpenVPN Inc. In-Reply-To: <9c919407-fb91-48d7-bf2d-8437c2f3f4da@openvpn.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 05/03/2025 00:19, Antonio Quartulli wrote: > On 04/03/2025 19:37, Sabrina Dubroca wrote: >> 2025-03-04, 01:33:48 +0100, Antonio Quartulli wrote: >>> A peer connected via UDP may change its IP address without reconnecting >>> (float). >> >> Should that trigger a reset of the peer->dst_cache? And same when >> userspace updates the remote address? Otherwise it seems we could be >> stuck with a cached dst that cannot reach the peer. > > Yeah, that make sense, otherwise ovpn_udpX_output would just try over > and over to re-use the cached source address (unless it becomes > unavailable). I spent some more time thinking about this. It makes sense to reset the dst cache when the local address changes, but not in case of float (remote address changed). That's because we always want to first attempt sending packets using the address where the remote peer sent the traffic to. Should that not work (quite rare), then we have code in ovpn_udpX_output that will reset the cache and attempt a different address. Cheers, -- Antonio Quartulli OpenVPN Inc.