From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53B27F510 for ; Wed, 18 Jun 2025 15:13:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750259631; cv=none; b=DDlik5NSR136n4FfAyGfXjRGAgUFNz0E8m03GE0w1kO4jp9f3pty2ZO9KKU1GKusnpij6fLCGUViCDGtiEpqfvrP5xeqmLBq87zAynT5BOJTU0OCyJcApRqHkD9h2OSnJTgM5DVc9PCOI6GG4L3I5dpWVWaRXwAIRwhHQEz1KU8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750259631; c=relaxed/simple; bh=Vn9iBRZx/9vbTN0sjYLHUj8pAqYVdflJQ14VCJDqr/E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NHzg82IroeTR2glmaSBb1tdvLLvleuZ++tJ0DCOfa8pJNwPQ0gylzYnCuzxdWoriE1YLdfD/K0I4EBmZ1l0A1sKdGn9dO7dxMe3gicyvVIDEzqU5wBNlhZneOHNuk4eemZ5zjA9wffIaF7IcWnY18Kj+sIpT4k1bCSKMI5M0h3c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=blackwall.org; spf=none smtp.mailfrom=blackwall.org; dkim=pass (2048-bit key) header.d=blackwall-org.20230601.gappssmtp.com header.i=@blackwall-org.20230601.gappssmtp.com header.b=3Hk42bHI; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=blackwall.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=blackwall.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=blackwall-org.20230601.gappssmtp.com header.i=@blackwall-org.20230601.gappssmtp.com header.b="3Hk42bHI" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-ade4679fba7so1286268066b.2 for ; Wed, 18 Jun 2025 08:13:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=blackwall-org.20230601.gappssmtp.com; s=20230601; t=1750259628; x=1750864428; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=O+F9qb0WoqT4O8g9mE9Zc/ggeTeVcLZ0CP5p+3+ztus=; b=3Hk42bHIdT8jPgeEuQ0o05zRHi6b+0+CdPEkcYgqnYRDXvN+FXh/R0204Ny+Ej3rEj 2+YiWi0f4mDRssrYmSCmvzftRYaepNx7p0sQAqXEE6bk8EBaDuR1MyX7bg2oi6SbkGIt 6dR1PbfYcTu79b5GUbyzNeaXQPFaNaM2WOmWPONcfSueOpb4PYzMH4IGyTfKnKy+1Cwm jLimWSFuXVv5VlOBu8wmAxBI+4lsU/MFY7JRygZRyRAlGxSgW+d7md9pEd29tBWzpwZD HPe8FvSfRARiJRWg4ghHwZZbsQA3QePa6mge04sdEu1Vt4u9CLXqBTAjpVVrKPotjPfj 3/1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750259628; x=1750864428; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=O+F9qb0WoqT4O8g9mE9Zc/ggeTeVcLZ0CP5p+3+ztus=; b=Lhaw2dKMEFeYNMhgh/f6F7EZ1lQgFTpFDmGsX64fo6Mt99vKE72Z+PWlIXOrmerRhy 3iMu1I1XWPzjh2MyqkLCn02zb2x95f/MSe0gthjKQWI3RRSyyW90bgSsR2q4jdJbcjlx unZgwFcQAkhVIKW0O0CV4bBMRFDRi2a94q0snOkRYuY6JIW4q16wg+xXsipQZV1g6sHO l30dgKLLaAsg/kc7s8uwjJvC2BkhpPNSFoQHXgQhgfuYNmJX9MUKxH/6QFthe9wU7KIk QAgWu9ymTtGC5jbYhe5w5PsfZoZVy7VTRdalWSYyFS8o62r4aUna1QZz6Kc60qaRR1z4 74cQ== X-Forwarded-Encrypted: i=1; AJvYcCXTH4DZwRIxBsu5nsQWBwOyiklptaqMmazOnyODWnYTPIyI/Uuf61YUGAsIOJ9D4nfkaMt18hk=@vger.kernel.org X-Gm-Message-State: AOJu0YyG+C0s7LBfAoBQmufPoFZPTQ3yQjHqns7Gf29MGOVGYhIyIced H7oHjtOW/sM4QdZYLGm5KcEOGCllkX6r17qYLaDAga51YMfNRunOxZ1gh6N8+RzpK60= X-Gm-Gg: ASbGncvaxoj9mDZsiFjK8UESgF1pdDcF0+GVGeF64PbFYLrOxUPi+JacgtplkIEgW/z 9NJZlj6cDqoAfMRgtkpY1Feb5S+ScMQIMgZK++KXndze9ZJrduvd/y6UVEBBVlPmIuEyoFecCbu BNEAJCGYaeLZtLUB8DL6LbH0/p7POVSlmjGn8GVfEXAhvj5xWQAo5LFhFmPHStacOnN65ApyXD5 g5KDFo5XjkFg4/+zNa04TgEfyAlrKkKgDlcZQPj1JuU33UMnkMIlW9J1xi9u6Im5Sp3zQN8bEGP of3jXkJd89qQ5mtUg5QfAXFYHb4ZHyL0CRqTDrT2Y/l1soIGnbvE3inRYYn7zpsMJ9ie0ow0nN4 ntLPzILTUx9R3IjwzTg== X-Google-Smtp-Source: AGHT+IFP5VYYTJdfIK01Sjykg0ObgRPDVxQKO2zjJ45JW2hF+daM15wGjp6eoU5BXmzHVJq/enFDkw== X-Received: by 2002:a17:907:3c94:b0:ad5:5210:749c with SMTP id a640c23a62f3a-adfad3cda7dmr1548731566b.22.1750259627178; Wed, 18 Jun 2025 08:13:47 -0700 (PDT) Received: from [192.168.0.205] (78-154-15-142.ip.btc-net.bg. [78.154.15.142]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-adec88fe907sm1076757366b.93.2025.06.18.08.13.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Jun 2025 08:13:46 -0700 (PDT) Message-ID: <82caca13-7970-4f44-a68f-1efcf3e9a0f9@blackwall.org> Date: Wed, 18 Jun 2025 18:13:44 +0300 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v5 2/6] vxlan: drop sock_lock To: Stanislav Fomichev , netdev@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, skalluru@marvell.com, manishc@marvell.com, andrew+netdev@lunn.ch, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, ajit.khaparde@broadcom.com, sriharsha.basavapatna@broadcom.com, somnath.kotur@broadcom.com, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, tariqt@nvidia.com, saeedm@nvidia.com, louis.peens@corigine.com, shshaikh@marvell.com, GR-Linux-NIC-Dev@marvell.com, ecree.xilinx@gmail.com, horms@kernel.org, dsahern@kernel.org, shuah@kernel.org, tglx@linutronix.de, mingo@kernel.org, ruanjinjie@huawei.com, idosch@nvidia.com, petrm@nvidia.com, kuniyu@google.com, sdf@fomichev.me, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, oss-drivers@corigine.com, linux-net-drivers@amd.com, linux-kselftest@vger.kernel.org, leon@kernel.org References: <20250616162117.287806-1-stfomichev@gmail.com> <20250616162117.287806-3-stfomichev@gmail.com> Content-Language: en-US From: Nikolay Aleksandrov In-Reply-To: <20250616162117.287806-3-stfomichev@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/16/25 19:21, Stanislav Fomichev wrote: > We won't be able to sleep soon in vxlan_offload_rx_ports and won't be > able to grab sock_lock. Instead of having separate spinlock to > manage sockets, rely on rtnl lock. This is similar to how geneve > manages its sockets. > > Signed-off-by: Stanislav Fomichev > --- > drivers/net/vxlan/vxlan_core.c | 35 ++++++++++++----------------- > drivers/net/vxlan/vxlan_private.h | 2 +- > drivers/net/vxlan/vxlan_vnifilter.c | 18 ++++++--------- > 3 files changed, 22 insertions(+), 33 deletions(-) > Reviewed-by: Nikolay Aleksandrov